[Discover] Add Actions header to unified data table (#214366) by AlexGPlay · Pull Request #220824 · elastic/kibana

AlexGPlay · 2025-05-15T10:51:27Z

Summary

For accesibility reasons we need to label all the headers. At this point in time the actions from the unified data table have an empty header, for that we are grouping them in a column and labeling them as "Actions".

Scenario	Before	After (only icon)
1 icon
Multiple icons

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

See some risk examples
...

AlexGPlay · 2025-05-19T10:58:16Z

src/platform/packages/shared/kbn-discover-utils/src/components/custom_control_columns/types.ts

-  headerCellRender?: EuiDataGridControlColumn['headerCellRender'];
-  renderControl: (Control: RowControlComponent, props: RowControlRowProps) => ReactElement;
+  render: (Control: RowControlComponent, props: RowControlRowProps) => ReactElement;
 }


given that all the actions are going to be grouped in one single column I've updated this type to only have an id and the render function

AlexGPlay · 2025-05-19T11:06:27Z

...n-unified-data-table/src/components/custom_control_columns/actions_column/actions_header.tsx

+        <EuiFlexItem grow={false}>
+          <EuiIcon type="iInCircle" />
+        </EuiFlexItem>


do we want a tooltip here?

I'd suggest we hide the icon when the "Actions" text is visible and use "Actions" for the help text on EuiIconTip when only the icon is visible.

elasticmachine · 2025-05-19T11:08:02Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

davismcphee

Just did a quick scan of the code changes and they're looking good overall. Left a couple of comments, but going to defer to @jughosta for the full review since she's most familiar with this code.

davismcphee · 2025-05-19T21:02:29Z

...n-unified-data-table/src/components/custom_control_columns/actions_column/actions_header.tsx

I think we should remove the gutters between the icons to keep it similar to what we had before since the spacing now seems quite far apart based on the screenshots.

davismcphee · 2025-05-19T21:03:30Z

...n-unified-data-table/src/components/custom_control_columns/actions_column/actions_header.tsx

+        <EuiFlexItem grow={false}>
+          <EuiIcon type="iInCircle" />
+        </EuiFlexItem>


I'd suggest we hide the icon when the "Actions" text is visible and use "Actions" for the help text on EuiIconTip when only the icon is visible.

jughosta

Nice refactoring, @AlexGPlay!

...fied-data-table/src/components/custom_control_columns/actions_column/actions_column.test.tsx

jughosta · 2025-05-23T11:47:59Z

...fied-data-table/src/components/custom_control_columns/actions_column/actions_column.test.tsx

+        'Row control column 1',
+        'Row control column 2',
+        'External control column 1',
+        'External control column 2',


Hopefully both types are never used at the same time. We don't want to repetitively render so many actions.

src/platform/packages/shared/kbn-unified-data-table/src/components/data_table.tsx

jughosta · 2025-05-23T12:00:54Z

...unctional/apps/discover/context_awareness/extensions/_get_row_additional_leading_controls.ts

        });
        await discover.waitUntilSearchingHasFinished();
        await testSubjects.existOrFail('exampleLogsControl_visBarVerticalStacked');
-        await testSubjects.existOrFail('unifiedDataTable_additionalRowControl_menuControl');


I think the previous name was more descriptive. Can we keep it?

i've updated it to be unifiedDataTable_additionalRowControl_${columnId} so instead of this it is now unifiedDataTable_additionalRowControl_actions

nit: _menuControl or _actionsMenu would be better imho

..._suites/common/discover/context_awareness/extensions/_get_row_additional_leading_controls.ts

jughosta · 2025-05-23T12:50:18Z

...fied-data-table/src/components/custom_control_columns/actions_column/actions_column.test.tsx

+      description: '2 of each column type',
+    },
+  ])(
+    'given $description',


...n-unified-data-table/src/components/custom_control_columns/actions_column/actions_column.tsx

...fied-data-table/src/components/custom_control_columns/actions_column/actions_header.test.tsx

...n-unified-data-table/src/components/custom_control_columns/actions_column/actions_header.tsx

jughosta · 2025-05-23T13:07:18Z

...n-unified-data-table/src/components/custom_control_columns/actions_column/actions_column.tsx

+        {extraColumns.map((Content, idx) => (
+          <Content key={idx} {...props} />
+        ))}
+      </EuiFlexGroup>


We might need to add some space between "Expand" and other Timeline actions

Also, we could reduce the padding above the checkbox for Timeline.

what do you think is the best approach here - should I let the consumer set the space between actions? Right now it's just set as none for everything.
The checkbox one i have to take a look because i'm not sure of how can i do that just for timeline

We could check that if the first external action was not rendered on the first position, then we add some spacing to the left from it.

Tackled both things here

Before After

jughosta

Almost there! Would be great to address the new header cells alignment issue too.

jughosta · 2025-05-28T12:25:15Z

...unctional/apps/discover/context_awareness/extensions/_get_row_additional_leading_controls.ts

        });
        await discover.waitUntilSearchingHasFinished();
        await testSubjects.existOrFail('exampleLogsControl_visBarVerticalStacked');
-        await testSubjects.existOrFail('unifiedDataTable_additionalRowControl_menuControl');


nit: _menuControl or _actionsMenu would be better imho

jughosta · 2025-05-28T12:43:20Z

src/platform/packages/shared/kbn-unified-data-table/src/components/data_table.tsx

+      externalControlColumns,
+    });
+    if (actionsColumn) {
+      filteredLeadColumns.push(actionsColumn);


The alignment inside the header cells looks off (when Density is Normal or Expanded). Can we improve it?

I didn't realise, i'll take a look

so what's the expected behaviour here? right now the control columns are center aligned but the others are top aligned - centering everything is the simplest thing to do

|

I have not looked closely but on main the checkbox is well aligned with the column headers for all Density options. Maybe now it has something to do with a missing line-height for the actions cell and this is why all the following column headers get taller.

ah, i see now, the sizing depends on the density, i'll update the actions header sizes to take that into account too

updated - there is this ColumnHeaderTruncateContainer component that helps with all of this

Perfect, thanks!

jughosta

Great work! LGTM 👍

...n-unified-data-table/src/components/custom_control_columns/actions_column/actions_header.tsx

jughosta · 2025-05-30T09:32:37Z

src/platform/packages/shared/kbn-unified-data-table/src/components/data_table.tsx

+      externalControlColumns,
+    });
+    if (actionsColumn) {
+      filteredLeadColumns.push(actionsColumn);


Perfect, thanks!

logeekal

Desk tested on behalf of @elastic/security-threat-hunting-investigations team and things are working without any major issues.

There is a very minor issue. Action column label should have same padding as other columns ( see immediate left of the label). Below screenshot if from Security Timeline. Please let me now if more info is needed.

AlexGPlay · 2025-06-02T08:47:21Z

Desk tested on behalf of @elastic/security-threat-hunting-investigations team and things are working without any major issues.

There is a very minor issue. Action column label should have same padding as other columns ( see immediate left of the label). Below screenshot if from Security Timeline. Please let me now if more info is needed.

pushed a change with the padding

logeekal

Thanks for incorporating the feedback. LGTM 🚀

kertal · 2025-06-02T13:13:15Z

Another one resolved, great work @AlexGPlay , qq: this PR resolves this one, right?

#214366

AlexGPlay · 2025-06-02T13:44:27Z

Another one resolved, great work @AlexGPlay , qq: this PR resolves this one, right?

#214366

@kertal partially - i was wondering if i should also raise a PR to add the icon in the doc viewer, it's mentioned in the similar part of that issue

kertal · 2025-06-02T14:04:24Z

I think this makes sense, let's have a short discussion in our sync

kertal · 2025-06-03T06:03:48Z

short summary of our sync, let's raise another PR for the doc viewer, to resolve #214366

elasticmachine · 2025-06-03T09:56:52Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 9509074

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #97 / alerting api integration security and spaces enabled - Group 2 Alerting and Actions Telemetry test telemetry should retrieve telemetry data in the expected format

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`cloudSecurityPosture`	700	703	+3
`discover`	1303	1306	+3
`esqlDataGrid`	434	437	+3
`lens`	1432	1435	+3
`securitySolution`	7451	7454	+3
`slo`	1171	1174	+3
total			+18

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/discover-utils`	310	308	-2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cloudSecurityPosture`	540.8KB	541.8KB	+1010.0B
`discover`	1.1MB	1.1MB	+782.0B
`esqlDataGrid`	159.4KB	160.4KB	+1009.0B
`securitySolution`	9.2MB	9.2MB	+1010.0B
`slo`	985.6KB	986.6KB	+1020.0B
total			+4.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cloudSecurityPosture`	18.5KB	18.5KB	-2.0B
`esqlDataGrid`	9.1KB	9.1KB	-1.0B
total			-3.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/discover-utils`	360	358	-2

History

💔 Build #304414 failed 3181a7e
💚 Build #303989 succeeded 98ed275
💚 Build #303707 succeeded de0ee75
💔 Build #303641 failed f3d2d31
💔 Build #303326 failed 628d791

cc @AlexGPlay

kibanamachine · 2025-06-03T10:07:12Z

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15414479803

…lastic#220824) ## Summary For accesibility reasons we need to label all the headers. At this point in time the actions from the unified data table have an empty header, for that we are grouping them in a column and labeling them as "Actions". | Scenario | Before | After (only icon) | |----------|--------|-----------------| | 1 icon | <img width="1035" alt="image" src="https://github.com/user-attachments/assets/2884904b-42ce-432f-9cf7-90140c349ca2" /> | <img width="1036" alt="image" src="https://github.com/user-attachments/assets/84947522-0426-4317-a642-1fb6cab27306" /> | | Multiple icons | <img width="558" alt="image" src="https://github.com/user-attachments/assets/fe4be017-116d-4586-888d-0e81b0b0395e" /> | <img width="557" alt="image" src="https://github.com/user-attachments/assets/58ea3261-703e-4d17-906c-29ee5a40569f" /> | ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co> (cherry picked from commit b4b49ac)

kibanamachine · 2025-06-03T10:13:47Z

💚 All backports created successfully

Status	Branch	Result
✅	8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…lastic#220824) ## Summary For accesibility reasons we need to label all the headers. At this point in time the actions from the unified data table have an empty header, for that we are grouping them in a column and labeling them as "Actions". | Scenario | Before | After (only icon) | |----------|--------|-----------------| | 1 icon | <img width="1035" alt="image" src="https://github.com/user-attachments/assets/2884904b-42ce-432f-9cf7-90140c349ca2" /> | <img width="1036" alt="image" src="https://github.com/user-attachments/assets/84947522-0426-4317-a642-1fb6cab27306" /> | | Multiple icons | <img width="558" alt="image" src="https://github.com/user-attachments/assets/fe4be017-116d-4586-888d-0e81b0b0395e" /> | <img width="557" alt="image" src="https://github.com/user-attachments/assets/58ea3261-703e-4d17-906c-29ee5a40569f" /> | ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>

kibanamachine · 2025-06-05T10:49:06Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @AlexGPlay

…lastic#220824) ## Summary For accesibility reasons we need to label all the headers. At this point in time the actions from the unified data table have an empty header, for that we are grouping them in a column and labeling them as "Actions". | Scenario | Before | After (only icon) | |----------|--------|-----------------| | 1 icon | <img width="1035" alt="image" src="https://github.com/user-attachments/assets/2884904b-42ce-432f-9cf7-90140c349ca2" /> | <img width="1036" alt="image" src="https://github.com/user-attachments/assets/84947522-0426-4317-a642-1fb6cab27306" /> | | Multiple icons | <img width="558" alt="image" src="https://github.com/user-attachments/assets/fe4be017-116d-4586-888d-0e81b0b0395e" /> | <img width="557" alt="image" src="https://github.com/user-attachments/assets/58ea3261-703e-4d17-906c-29ee5a40569f" /> | ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co> (cherry picked from commit b4b49ac)

kibanamachine · 2025-06-06T10:49:42Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @AlexGPlay

kibanamachine · 2025-06-09T11:48:45Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @AlexGPlay

kibanamachine · 2025-06-10T12:48:57Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @AlexGPlay

…220824) (#222323) # Backport This will backport the following commits from `main` to `8.19`: - [[Discover] Add Actions header to unified data table (#214366) (#220824)](#220824)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  --------- Co-authored-by: Alejandro García Parrondo <31973472+AlexGPlay@users.noreply.github.com> Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co> Co-authored-by: AlexGPlay <alex.garcia@elastic.co>

…lastic#220824) ## Summary For accesibility reasons we need to label all the headers. At this point in time the actions from the unified data table have an empty header, for that we are grouping them in a column and labeling them as "Actions". | Scenario | Before | After (only icon) | |----------|--------|-----------------| | 1 icon | <img width="1035" alt="image" src="https://github.com/user-attachments/assets/2884904b-42ce-432f-9cf7-90140c349ca2" /> | <img width="1036" alt="image" src="https://github.com/user-attachments/assets/84947522-0426-4317-a642-1fb6cab27306" /> | | Multiple icons | <img width="558" alt="image" src="https://github.com/user-attachments/assets/fe4be017-116d-4586-888d-0e81b0b0395e" /> | <img width="557" alt="image" src="https://github.com/user-attachments/assets/58ea3261-703e-4d17-906c-29ee5a40569f" /> | ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>

elasticmachine · 2025-07-18T10:01:36Z

Pinging @elastic/kibana-accessibility (Project:Accessibility)

AlexGPlay force-pushed the 214366-add-actions-to-unified-data-table-header branch from 37fd390 to 00c37d3 Compare May 19, 2025 09:11

AlexGPlay self-assigned this May 19, 2025

AlexGPlay commented May 19, 2025

View reviewed changes

AlexGPlay marked this pull request as ready for review May 19, 2025 11:06

AlexGPlay requested review from a team as code owners May 19, 2025 11:06

AlexGPlay added release_note:fix Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// backport:version Backport to applied version labels v9.1.0 v8.19.0 labels May 19, 2025

davismcphee reviewed May 19, 2025

View reviewed changes

davismcphee requested a review from jughosta May 19, 2025 21:21

kertal requested a review from l-suarez May 22, 2025 05:15

AlexGPlay force-pushed the 214366-add-actions-to-unified-data-table-header branch from 1fb1ae5 to 211b377 Compare May 23, 2025 06:23

jughosta reviewed May 23, 2025

View reviewed changes

AlexGPlay force-pushed the 214366-add-actions-to-unified-data-table-header branch from 211b377 to da80985 Compare May 26, 2025 07:14

jughosta reviewed May 28, 2025

View reviewed changes

AlexGPlay requested a review from a team as a code owner May 28, 2025 14:47

AlexGPlay force-pushed the 214366-add-actions-to-unified-data-table-header branch 2 times, most recently from 628d791 to c27fced Compare May 30, 2025 06:09

jughosta approved these changes May 30, 2025

View reviewed changes

AlexGPlay force-pushed the 214366-add-actions-to-unified-data-table-header branch from 8ac631f to f3d2d31 Compare May 30, 2025 10:15

logeekal reviewed Jun 2, 2025

View reviewed changes

AlexGPlay added 3 commits June 2, 2025 10:47

Add Actions header to unified data table

5a4a5ca

Move actions column to new file

b9c8e04

Update RowControlColumn type to not include header data

3310a25

AlexGPlay added 2 commits June 2, 2025 10:47

Remove unused translations

b9a22ee

Add missing padding

98ed275

AlexGPlay force-pushed the 214366-add-actions-to-unified-data-table-header branch from 0581c04 to 98ed275 Compare June 2, 2025 08:47

logeekal approved these changes Jun 2, 2025

View reviewed changes

kertal added 2 commits June 3, 2025 08:03

Merge branch 'main' into 214366-add-actions-to-unified-data-table-header

3181a7e

Merge branch 'main' into 214366-add-actions-to-unified-data-table-header

9509074

AlexGPlay merged commit b4b49ac into elastic:main Jun 3, 2025
10 checks passed

kibanamachine mentioned this pull request Jun 3, 2025

[8.19] [Discover] Add Actions header to unified data table (#214366) (#220824) #222323

Merged

kibanamachine mentioned this pull request Jun 3, 2025

[Security Solution][Data Quality Dashboard] Remove tour guide #222311

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 5, 2025

davismcphee mentioned this pull request Jun 10, 2025

[Discover] Discover grid column headers are misaligned #223175

Closed

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 10, 2025

florent-leborgne added the Project:Accessibility label Jul 18, 2025

Conversation

AlexGPlay commented May 15, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Identify risks

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented May 19, 2025

Uh oh!

davismcphee left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jughosta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jughosta left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlexGPlay May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jughosta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

logeekal left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

AlexGPlay commented May 15, 2025 •

edited by kibanamachine

Loading

AlexGPlay May 29, 2025 •

edited

Loading

logeekal left a comment •

edited

Loading

kertal commented Jun 2, 2025 •

edited

Loading