Make option list with stats accessible with keyboard#221729
Merged
SoniaSanzV merged 1 commit intoelastic:mainfrom May 29, 2025
Merged
Make option list with stats accessible with keyboard#221729SoniaSanzV merged 1 commit intoelastic:mainfrom
SoniaSanzV merged 1 commit intoelastic:mainfrom
Conversation
SoniaSanzV
added
release_note:skip
Contributor
|
This will also fix #216773 since it uses the same |
peteharverson
approved these changes
May 28, 2025
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested (MacOS Chrome and FF) and LGTM. Also fixes the same issue in the ML 'Add detector' modal in the advanced job wizard since it uses the same component.
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
cc @SoniaSanzV |
alexwizp
reviewed
May 28, 2025
...rm/packages/private/ml/field_stats_flyout/options_list_with_stats/option_list_with_stats.tsx
Show resolved
Hide resolved
Contributor
|
Starting backport for target branches: 9.0 https://github.com/elastic/kibana/actions/runs/15323791605 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 29, 2025
Fixes elastic#219516 ## Summary The Transform plugin has some text fields that are not keyboard accessible and those fields are using the `OptionListWithFieldStats` component. This PR adds the `onKeyDown` event for that component, fixing the problem for Transform plugin. https://github.com/user-attachments/assets/ec527750-b830-41e6-b3e5-c174a1c26311 (cherry picked from commit d6178cd)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
|
Starting backport for target branches: 8.19, 9.0 https://github.com/elastic/kibana/actions/runs/15324319174 |
1 task
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 29, 2025
Fixes elastic#219516 ## Summary The Transform plugin has some text fields that are not keyboard accessible and those fields are using the `OptionListWithFieldStats` component. This PR adds the `onKeyDown` event for that component, fixing the problem for Transform plugin. https://github.com/user-attachments/assets/ec527750-b830-41e6-b3e5-c174a1c26311 (cherry picked from commit d6178cd)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 task
SoniaSanzV
added a commit
to SoniaSanzV/kibana
that referenced
this pull request
May 29, 2025
Fixes elastic#219516 The Transform plugin has some text fields that are not keyboard accessible and those fields are using the `OptionListWithFieldStats` component. This PR adds the `onKeyDown` event for that component, fixing the problem for Transform plugin. https://github.com/user-attachments/assets/ec527750-b830-41e6-b3e5-c174a1c26311 (cherry picked from commit d6178cd)
SoniaSanzV
added a commit
to SoniaSanzV/kibana
that referenced
this pull request
May 29, 2025
Fixes elastic#219516 The Transform plugin has some text fields that are not keyboard accessible and those fields are using the `OptionListWithFieldStats` component. This PR adds the `onKeyDown` event for that component, fixing the problem for Transform plugin. https://github.com/user-attachments/assets/ec527750-b830-41e6-b3e5-c174a1c26311 (cherry picked from commit d6178cd)
kibanamachine
added a commit
that referenced
this pull request
May 29, 2025
…221930) # Backport This will backport the following commits from `main` to `9.0`: - [Make option list with stats accessible with keyboard (#221729)](#221729) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sonia Sanz Vivas","email":"sonia.sanzvivas@elastic.co"},"sourceCommit":{"committedDate":"2025-05-29T12:25:30Z","message":"Make option list with stats accessible with keyboard (#221729)\n\nFixes https://github.com/elastic/kibana/issues/219516\n\n## Summary\nThe Transform plugin has some text fields that are not keyboard\naccessible and those fields are using the `OptionListWithFieldStats`\ncomponent. This PR adds the `onKeyDown` event for that component, fixing\nthe problem for Transform plugin.\n\n\n\n\nhttps://github.com/user-attachments/assets/ec527750-b830-41e6-b3e5-c174a1c26311","sha":"d6178cd680918d310502c48306dbc4b0936fced4","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Transforms","backport:prev-minor","v9.1.0"],"title":"Make option list with stats accessible with keyboard","number":221729,"url":"https://github.com/elastic/kibana/pull/221729","mergeCommit":{"message":"Make option list with stats accessible with keyboard (#221729)\n\nFixes https://github.com/elastic/kibana/issues/219516\n\n## Summary\nThe Transform plugin has some text fields that are not keyboard\naccessible and those fields are using the `OptionListWithFieldStats`\ncomponent. This PR adds the `onKeyDown` event for that component, fixing\nthe problem for Transform plugin.\n\n\n\n\nhttps://github.com/user-attachments/assets/ec527750-b830-41e6-b3e5-c174a1c26311","sha":"d6178cd680918d310502c48306dbc4b0936fced4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221729","number":221729,"mergeCommit":{"message":"Make option list with stats accessible with keyboard (#221729)\n\nFixes https://github.com/elastic/kibana/issues/219516\n\n## Summary\nThe Transform plugin has some text fields that are not keyboard\naccessible and those fields are using the `OptionListWithFieldStats`\ncomponent. This PR adds the `onKeyDown` event for that component, fixing\nthe problem for Transform plugin.\n\n\n\n\nhttps://github.com/user-attachments/assets/ec527750-b830-41e6-b3e5-c174a1c26311","sha":"d6178cd680918d310502c48306dbc4b0936fced4"}}]}] BACKPORT--> Co-authored-by: Sonia Sanz Vivas <sonia.sanzvivas@elastic.co>
SoniaSanzV
added a commit
that referenced
this pull request
May 30, 2025
Contributor
|
This PR didn't make it into the latest 9.0.2 BC. Updating the labels. |
zacharyparikh
pushed a commit
to zacharyparikh/kibana
that referenced
this pull request
Jun 4, 2025
Fixes elastic#219516 ## Summary The Transform plugin has some text fields that are not keyboard accessible and those fields are using the `OptionListWithFieldStats` component. This PR adds the `onKeyDown` event for that component, fixing the problem for Transform plugin. https://github.com/user-attachments/assets/ec527750-b830-41e6-b3e5-c174a1c26311
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Jun 12, 2025
Fixes elastic#219516 ## Summary The Transform plugin has some text fields that are not keyboard accessible and those fields are using the `OptionListWithFieldStats` component. This PR adds the `onKeyDown` event for that component, fixing the problem for Transform plugin. https://github.com/user-attachments/assets/ec527750-b830-41e6-b3e5-c174a1c26311
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #219516
Summary
The Transform plugin has some text fields that are not keyboard accessible and those fields are using the
OptionListWithFieldStatscomponent. This PR adds theonKeyDownevent for that component, fixing the problem for Transform plugin.Screen.Recording.2025-05-28.at.09.53.27.mov