[ResponseOps] consistent-type-imports linting rule for RO packages/plugins - PR1 by georgianaonoleata1904 · Pull Request #212348 · elastic/kibana

georgianaonoleata1904 · 2025-02-25T10:44:50Z

Enabled @typescript-eslint/consistent-type-imports eslint rule for ResponseOps packages and plugins:
- this rule ensures that imports used only for type declarations are consistently written using import type syntax
fixed eslint errors for:
- src/platform/packages/shared/response-ops
- x-pack/platform/plugins/shared/alerting

…r response-ops package

…onoleata1904/kibana into type-imports-eslint-ro

…-fix'

elasticmachine · 2025-03-04T09:28:39Z

Pinging @elastic/response-ops (Team:ResponseOps)

georgianaonoleata1904 · 2025-03-04T09:36:32Z

The is part 1/4. The following PRs have related changes:
#212366
#212498
#212508

adcoelho

This is a nice rule to enable, I had no idea we did this in so many places. 👍

gsoldevila · 2025-03-04T15:38:39Z

Related to #212221

gsoldevila · 2025-03-04T15:43:46Z

I think it is worth addressing this globally for the whole repo, I'll create an issue for it.

If we really want to add this ESLint constraint, best strategy, as Matt suggests, would be a divide & conquer approach:

Make the ESLint rules a warning by default.
Create a list of all Kibana modules (~800 atm), grouped by owning team.
Add this list with each line commented out, as an override in .eslintrc.json, turning the warning into an error.
Create as many PRs as owning teams, and in each PR uncomment the corresponding modules in the eslint overrides.
Address issues with the import/no-duplicates rule, e.g. import type { …, type XXX, }.

…-fix'

umbopepato

Super happy that we're enabling this rule, it'll help a lot. Thank you Georgiana! 🤗
LGTM, just left a comment where a type import is missing

umbopepato · 2025-03-05T09:31:11Z

src/platform/packages/shared/response-ops/rule_form/src/types.ts

-import { FieldsMetadataPublicStart } from '@kbn/fields-metadata-plugin/public';
-import {
+import type { ActionConnector, ActionTypeRegistryContract } from '@kbn/alerts-ui-shared';
+import type {


Seems like the FieldsMetadataPublicStart type import was lost here 🙂

Oh, it was lost at merge. Fixed it, thanks! :)

jeramysoucy

Kibana security changes LGTM - no changes to ESO registration/model versions

georgianaonoleata1904 · 2025-03-10T10:19:47Z

/ci

…-fix'

cnasikas · 2025-03-11T10:03:58Z

@elasticmachine merge upstream

kibanamachine · 2025-03-11T12:57:06Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13788573322

elasticmachine · 2025-03-11T12:57:23Z

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #108 / discover/group1 discover accessibility top nav menu buttons should return focus to the alerts button when dismissing the alerts popover

Metrics [docs]

✅ unchanged

History

💔 Build #282211 failed fffb7ef
💔 Build #282103 failed 5f99e74
💛 Build #281011 was flaky 3795562
💔 Build #280984 failed f81fc02
💔 Build #280977 failed e4e7f58

cc @georgianaonoleata1904

kibanamachine · 2025-03-11T13:02:41Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts You might need to backport the following PRs to 8.x: - [ResponseOps][OnWeek] Investigate isolating flapping feature in the code (#212454) - [ResponseOps][MW] Use date format from settings in MW UI (#211576)

Manual backport

To create the backport manually run:

node scripts/backport --pr 212348

Questions ?

Please refer to the Backport tool documentation

georgianaonoleata1904 · 2025-03-11T14:21:51Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…ugins - PR1 (elastic#212348) - Enabled @typescript-eslint/consistent-type-imports eslint rule for ResponseOps packages and plugins: - this rule ensures that imports used only for type declarations are consistently written using `import type ` syntax - fixed eslint errors for: - `src/platform/packages/shared/response-ops` - `x-pack/platform/plugins/shared/alerting` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit ec3b186) # Conflicts: # x-pack/platform/plugins/shared/alerting/public/pages/maintenance_windows/components/fields/date_picker_range_field.test.tsx # x-pack/platform/plugins/shared/alerting/public/pages/maintenance_windows/components/fields/date_picker_range_field.tsx # x-pack/platform/plugins/shared/alerting/public/pages/maintenance_windows/components/maintenance_windows_list.test.tsx # x-pack/platform/plugins/shared/alerting/public/pages/maintenance_windows/components/recurring_schedule_form/custom_recurring_schedule.tsx # x-pack/platform/plugins/shared/alerting/public/pages/maintenance_windows/components/recurring_schedule_form/recurring_schedule.tsx # x-pack/platform/plugins/shared/alerting/public/pages/maintenance_windows/components/upcoming_events_popover.tsx # x-pack/platform/plugins/shared/alerting/public/pages/maintenance_windows/helpers/convert_to_rrule.ts # x-pack/platform/plugins/shared/alerting/public/pages/maintenance_windows/helpers/parse_schedule.ts # x-pack/platform/plugins/shared/alerting/server/alerts_client/alerts_client.ts # x-pack/platform/plugins/shared/alerting/server/alerts_client/legacy_alerts_client.ts # x-pack/platform/plugins/shared/alerting/server/alerts_client/lib/get_summarized_alerts_query.ts # x-pack/platform/plugins/shared/alerting/server/alerts_client/lib/inject_analyze_wildcard.ts # x-pack/platform/plugins/shared/alerting/server/alerts_client/lib/sanitize_bulk_response.test.ts # x-pack/platform/plugins/shared/alerting/server/alerts_service/default_lifecycle_policy.ts # x-pack/platform/plugins/shared/alerting/server/alerts_service/lib/create_concrete_write_index.test.ts # x-pack/platform/plugins/shared/alerting/server/alerts_service/lib/create_concrete_write_index.ts # x-pack/platform/plugins/shared/alerting/server/alerts_service/lib/create_or_update_component_template.test.ts # x-pack/platform/plugins/shared/alerting/server/alerts_service/lib/create_or_update_component_template.ts # x-pack/platform/plugins/shared/alerting/server/alerts_service/lib/create_or_update_ilm_policy.ts # x-pack/platform/plugins/shared/alerting/server/alerts_service/lib/create_or_update_index_template.ts # x-pack/platform/plugins/shared/alerting/server/application/rule/methods/aggregate/types/index.ts # x-pack/platform/plugins/shared/alerting/server/authorization/alerting_authorization_kuery.ts # x-pack/platform/plugins/shared/alerting/server/lib/determine_delayed_alerts.ts # x-pack/platform/plugins/shared/alerting/server/lib/flapping/delay_recovered_flapping_alerts.ts # x-pack/platform/plugins/shared/alerting/server/lib/flapping/determine_flapping_alerts.ts # x-pack/platform/plugins/shared/alerting/server/lib/flapping/set_flapping_history_and_tracked_alerts.test.ts # x-pack/platform/plugins/shared/alerting/server/lib/flapping/set_flapping_history_and_tracked_alerts.ts # x-pack/platform/plugins/shared/alerting/server/lib/flapping_utils.ts # x-pack/platform/plugins/shared/alerting/server/lib/get_execution_log_aggregation.ts # x-pack/platform/plugins/shared/alerting/server/lib/process_alerts.test.ts # x-pack/platform/plugins/shared/alerting/server/lib/process_alerts.ts # x-pack/platform/plugins/shared/alerting/server/lib/rule_gaps/find_gaps.ts # x-pack/platform/plugins/shared/alerting/server/lib/rule_gaps/types/index.ts # x-pack/platform/plugins/shared/alerting/server/lib/rule_gaps/update/update_gaps.ts # x-pack/platform/plugins/shared/alerting/server/lib/set_flapping.test.ts # x-pack/platform/plugins/shared/alerting/server/lib/set_flapping.ts # x-pack/platform/plugins/shared/alerting/server/lib/to_raw_alert_instances.ts # x-pack/platform/plugins/shared/alerting/server/monitoring/register_cluster_collector.ts # x-pack/platform/plugins/shared/alerting/server/routes/index.ts # x-pack/platform/plugins/shared/alerting/server/rules_client/methods/get_action_error_log.ts # x-pack/platform/plugins/shared/alerting/server/rules_client/methods/get_execution_log.ts # x-pack/platform/plugins/shared/alerting/server/rules_client/tests/get_execution_log.test.ts # x-pack/platform/plugins/shared/alerting/server/saved_objects/partially_update_rule.test.ts # x-pack/platform/plugins/shared/alerting/server/task_runner/action_scheduler/action_scheduler.ts # x-pack/platform/plugins/shared/alerting/server/usage/lib/get_telemetry_from_alerts.ts # x-pack/platform/plugins/shared/alerting/server/usage/lib/get_telemetry_from_event_log.ts # x-pack/platform/plugins/shared/alerting/server/usage/lib/get_telemetry_from_kibana.ts # x-pack/platform/plugins/shared/alerting/server/usage/lib/get_telemetry_from_task_manager.ts # x-pack/platform/plugins/shared/alerting/server/usage/lib/group_connectors_by_consumers.ts

…ges/plugins - PR1 (#212348) (#213929) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps] consistent-type-imports linting rule for RO packages/plugins - PR1 (#212348)](#212348)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

…ugins - PR1 (elastic#212348) - Enabled @typescript-eslint/consistent-type-imports eslint rule for ResponseOps packages and plugins: - this rule ensures that imports used only for type declarations are consistently written using `import type ` syntax - fixed eslint errors for: - `src/platform/packages/shared/response-ops` - `x-pack/platform/plugins/shared/alerting` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

georgianaonoleata1904 and others added 10 commits February 25, 2025 12:41

added eslint rule for consistent-type-imports and fixed the errors fo…

8ec6225

…r response-ops package

removed /

1f26430

fixed eslint type errors for alerting

8573aff

applied type rule only for alerting and response-ops

4992a32

Merge branch 'main' into type-imports-eslint-ro

a31e291

fixed eslint error

5ecd533

Merge branch 'type-imports-eslint-ro' of https://github.com/georgiana…

0bb2516

…onoleata1904/kibana into type-imports-eslint-ro

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

673e430

…-fix'

Merge branch 'main' into type-imports-eslint-ro

c05b224

fixed no_unresolvable_imports issues

4cc7a16

georgianaonoleata1904 self-assigned this Mar 4, 2025

georgianaonoleata1904 added Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// backport:version Backport to applied version labels v9.1.0 v8.19.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 4, 2025

georgianaonoleata1904 marked this pull request as ready for review March 4, 2025 09:28

georgianaonoleata1904 requested review from a team as code owners March 4, 2025 09:28

georgianaonoleata1904 changed the title ~~WIP - [ResponseOps] consistent-type-imports linting rule~~ [ResponseOps] consistent-type-imports linting rule for RO packages/plugins - PR1 Mar 4, 2025

adcoelho approved these changes Mar 4, 2025

View reviewed changes

jbudz approved these changes Mar 4, 2025

View reviewed changes

georgianaonoleata1904 and others added 2 commits March 5, 2025 10:39

Merge branch 'main' into type-imports-eslint-ro

e4e7f58

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

f81fc02

…-fix'

umbopepato approved these changes Mar 5, 2025

View reviewed changes

fixed missing import

3795562

jeramysoucy approved these changes Mar 7, 2025

View reviewed changes

Merge branch 'main' into type-imports-eslint-ro

d2afd27

georgianaonoleata1904 and others added 6 commits March 10, 2025 12:20

Merge branch 'main' into type-imports-eslint-ro

5f99e74

Merge branch 'main' into type-imports-eslint-ro

ea7de36

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

fffb7ef

…-fix'

Merge branch 'main' into type-imports-eslint-ro

a4ff244

Merge branch 'main' into type-imports-eslint-ro

04a0df9

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

53d7db4

…-fix'

Merge branch 'main' into type-imports-eslint-ro

ca170d2

cnasikas enabled auto-merge (squash) March 11, 2025 10:04

cnasikas merged commit ec3b186 into elastic:main Mar 11, 2025
10 checks passed

georgianaonoleata1904 mentioned this pull request Mar 11, 2025

[8.x] [ResponseOps] consistent-type-imports linting rule for RO packages/plugins - PR1 (#212348) #213929

Merged

Conversation

georgianaonoleata1904 commented Feb 25, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Mar 4, 2025

Uh oh!

georgianaonoleata1904 commented Mar 4, 2025

Uh oh!

adcoelho left a comment

Choose a reason for hiding this comment

Uh oh!

gsoldevila commented Mar 4, 2025

Uh oh!

gsoldevila commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

umbopepato left a comment

Choose a reason for hiding this comment

Uh oh!

umbopepato Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

georgianaonoleata1904 Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

jeramysoucy left a comment

Choose a reason for hiding this comment

Uh oh!

georgianaonoleata1904 commented Mar 10, 2025

Uh oh!

cnasikas commented Mar 11, 2025

Uh oh!

Uh oh!

kibanamachine commented Mar 11, 2025

Uh oh!

elasticmachine commented Mar 11, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

History

Uh oh!

kibanamachine commented Mar 11, 2025

💔 All backports failed

Manual backport

Questions ?

Uh oh!

georgianaonoleata1904 commented Mar 11, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

georgianaonoleata1904 commented Feb 25, 2025 •

edited by kibanamachine

Loading

gsoldevila commented Mar 4, 2025 •

edited

Loading