[ResponseOps]consistent-type-imports linting rule for RO packages/plugins - PR4#212508
Merged
georgianaonoleata1904 merged 13 commits intoelastic:mainfrom Mar 26, 2025
Merged
Conversation
georgianaonoleata1904
changed the title
georgianaonoleata1904
added
release_note:skip
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
jbudz
approved these changes
Mar 4, 2025
gergoabraham
approved these changes
Mar 7, 2025
Contributor
gergoabraham
left a comment
gergoabraham
left a comment
There was a problem hiding this comment.
@elastic/security-defend-workflows related changes look good! thank you!
- x-pack/test/alerting_api_integration/security_and_spaces/group2/tests/actions/connector_types/crowdstrike.ts
- x-pack/test/alerting_api_integration/security_and_spaces/group2/tests/actions/connector_types/microsoft_defender_endpoint.ts
- x-pack/test/alerting_api_integration/security_and_spaces/group2/tests/actions/connector_types/sentinelone.ts
adcoelho
approved these changes
Mar 7, 2025
fkanout
approved these changes
Mar 24, 2025
Contributor
fkanout
left a comment
fkanout
left a comment
There was a problem hiding this comment.
Nice work!
I was expecting in the build metrics to see a reduction in the bundle size 🤔
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/14084482033 |
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
georgianaonoleata1904
added a commit
to georgianaonoleata1904/kibana
that referenced
this pull request
Mar 26, 2025
…gins - PR4 (elastic#212508) - Enabled @typescript-eslint/consistent-type-imports eslint rule for ResponseOps packages and plugins: - this rule ensures that imports used only for type declarations are consistently written using import type syntax - fixed type imports for: - x-pack/test/alerting_api_integration - x-pack/test/cases_api_integration - x-pack/test/rule_registry - x-pack/test/api_integration/apis/cases --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit d60335a) # Conflicts: # x-pack/test/alerting_api_integration/security_and_spaces/group1/tests/alerting/backfill/delete.ts # x-pack/test/alerting_api_integration/security_and_spaces/group1/tests/alerting/backfill/test_utils.ts # x-pack/test/alerting_api_integration/security_and_spaces/group4/tests/alerting/alerts.ts # x-pack/test/alerting_api_integration/security_and_spaces/group5/tests/alerting/index.ts # x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group1/alerts_base.ts # x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/alert_severity.ts # x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/alerts_as_data/alerts_as_data.ts # x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/alerts_as_data/alerts_as_data_alert_delay.ts # x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/alerts_as_data/alerts_as_data_conflicts.ts # x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/alerts_as_data/alerts_as_data_flapping.ts # x-pack/test/cases_api_integration/common/lib/alerts.ts # x-pack/test/cases_api_integration/common/lib/api/user_actions.ts # x-pack/test/cases_api_integration/security_and_spaces/tests/common/cases/get_case.ts # x-pack/test/cases_api_integration/security_and_spaces/tests/common/cases/resolve_case.ts # x-pack/test/cases_api_integration/security_and_spaces/tests/common/index_common_trial/index.ts # x-pack/test/cases_api_integration/security_and_spaces/tests/common/user_actions/migrations.ts # x-pack/test/spaces_api_integration/security_and_spaces/copy_to_space_config_basic.ts
delanni
added a commit
that referenced
this pull request
Mar 26, 2025
## Summary Quick fix to a lint error present in main after #212508 - probably a case of merge race condition see: https://buildkite.com/elastic/kibana-on-merge/builds/65208#0195d2a4-1f65-4ecc-9c45-25b789d8ca79
umbopepato
pushed a commit
to umbopepato/kibana
that referenced
this pull request
Mar 26, 2025
…#216047) ## Summary Quick fix to a lint error present in main after elastic#212508 - probably a case of merge race condition see: https://buildkite.com/elastic/kibana-on-merge/builds/65208#0195d2a4-1f65-4ecc-9c45-25b789d8ca79
georgianaonoleata1904
added a commit
that referenced
this pull request
Mar 26, 2025
…es/plugins - PR4 (#212508) (#216046) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps]consistent-type-imports linting rule for RO packages/plugins - PR4 (#212508)](#212508) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Georgiana-Andreea Onoleață","email":"georgiana.onoleata@elastic.co"},"sourceCommit":{"committedDate":"2025-03-26T13:27:06Z","message":"[ResponseOps]consistent-type-imports linting rule for RO packages/plugins - PR4 (#212508)\n\n- Enabled @typescript-eslint/consistent-type-imports eslint rule for\nResponseOps packages and plugins:\n- this rule ensures that imports used only for type declarations are\nconsistently written using import type syntax\n\n- fixed type imports for:\n - x-pack/test/alerting_api_integration\n - x-pack/test/cases_api_integration\n - x-pack/test/rule_registry\n - x-pack/test/api_integration/apis/cases\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d60335a19581c300a5e4123734ab8ba236711abe","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","backport:version","v9.1.0","v8.19.0"],"title":"[ResponseOps]consistent-type-imports linting rule for RO packages/plugins - PR4","number":212508,"url":"https://github.com/elastic/kibana/pull/212508","mergeCommit":{"message":"[ResponseOps]consistent-type-imports linting rule for RO packages/plugins - PR4 (#212508)\n\n- Enabled @typescript-eslint/consistent-type-imports eslint rule for\nResponseOps packages and plugins:\n- this rule ensures that imports used only for type declarations are\nconsistently written using import type syntax\n\n- fixed type imports for:\n - x-pack/test/alerting_api_integration\n - x-pack/test/cases_api_integration\n - x-pack/test/rule_registry\n - x-pack/test/api_integration/apis/cases\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d60335a19581c300a5e4123734ab8ba236711abe"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212508","number":212508,"mergeCommit":{"message":"[ResponseOps]consistent-type-imports linting rule for RO packages/plugins - PR4 (#212508)\n\n- Enabled @typescript-eslint/consistent-type-imports eslint rule for\nResponseOps packages and plugins:\n- this rule ensures that imports used only for type declarations are\nconsistently written using import type syntax\n\n- fixed type imports for:\n - x-pack/test/alerting_api_integration\n - x-pack/test/cases_api_integration\n - x-pack/test/rule_registry\n - x-pack/test/api_integration/apis/cases\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d60335a19581c300a5e4123734ab8ba236711abe"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
…gins - PR4 (elastic#212508) - Enabled @typescript-eslint/consistent-type-imports eslint rule for ResponseOps packages and plugins: - this rule ensures that imports used only for type declarations are consistently written using import type syntax - fixed type imports for: - x-pack/test/alerting_api_integration - x-pack/test/cases_api_integration - x-pack/test/rule_registry - x-pack/test/api_integration/apis/cases --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
…#216047) ## Summary Quick fix to a lint error present in main after elastic#212508 - probably a case of merge race condition see: https://buildkite.com/elastic/kibana-on-merge/builds/65208#0195d2a4-1f65-4ecc-9c45-25b789d8ca79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabled @typescript-eslint/consistent-type-imports eslint rule for ResponseOps packages and plugins:
fixed type imports for: