[IGNORE FOR NOW] Enforce type export/import when possible#207088
Closed
gsoldevila wants to merge 19 commits intoelastic:mainfrom
Closed
[IGNORE FOR NOW] Enforce type export/import when possible#207088gsoldevila wants to merge 19 commits intoelastic:mainfrom
gsoldevila wants to merge 19 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
e5913a8 to
edbe7e8
Compare
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
shahzad31
approved these changes
Jan 22, 2025
Contributor
Author
|
/ci |
Contributor
💔 Build Failed
Failed CI StepsHistory
|
elena-shostak
approved these changes
Jan 27, 2025
Contributor
|
IMO this would be a much smoother transition if it was done a few modules at a time instead of in a monster PR. Generally speaking, we should work in smaller PRs when possible. Its difficult for me to simply see the changes relevant to my team. |
Contributor
The hint is in the title! |
Contributor
Author
|
A more recent attempt has been performed with #212221 |
This was referenced Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PR adds an ESLINT rule that will enforce
export typeandimport typewhenever the referenced member is a type.The goal is to find out if this can bring substantial improvements in:
If that's the case, we'll likely have to break this down into smaller PRs, easier to pass through.
I did not make it a DRAFT PR to allow
--fixfrom CI. You can safely ignore this PR for now 🙏🏼