[ResponseOps] consistent-type-imports linting rule for RO packages/plugins - PR1

.eslintrc.js

@@ -1607,9 +1607,9 @@ module.exports = {
     {
       // typescript for front and back end
       files: [
+        'x-pack/platform/plugins/shared/actions/**/*.{ts,tsx}',
         'x-pack/platform/plugins/shared/alerting/**/*.{ts,tsx}',
         'x-pack/platform/plugins/shared/stack_alerts/**/*.{ts,tsx}',
-        'x-pack/platform/plugins/shared/actions/**/*.{ts,tsx}',
         'x-pack/platform/plugins/shared/task_manager/**/*.{ts,tsx}',
         'x-pack/platform/plugins/shared/event_log/**/*.{ts,tsx}',
       ],
@@ -1628,6 +1628,20 @@ module.exports = {
       },
     },
 
+    /**
+     * ResponseOps overrides
+     */
+
+    {
+      files: [
+        'src/platform/packages/shared/response-ops/**/*.{ts, tsx}',
+        'x-pack/platform/plugins/shared/alerting/**/*.{ts,tsx}',
+      ],
+      rules: {
+        '@typescript-eslint/consistent-type-imports': 'error',
+      },
+    },
+
     /**
      * Lens overrides
      */

src/platform/packages/shared/response-ops/alerts-apis/apis/get_muted_alerts_instances_by_rule.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { HttpStart } from '@kbn/core-http-browser';
+import type { HttpStart } from '@kbn/core-http-browser';
 import { nodeBuilder } from '@kbn/es-query';
 
 const INTERNAL_FIND_RULES_URL = '/internal/alerting/rules/_find';

src/platform/packages/shared/response-ops/alerts-apis/apis/mute_alert_instance.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { HttpSetup } from '@kbn/core/public';
+import type { HttpSetup } from '@kbn/core/public';
 import { BASE_ALERTING_API_PATH } from '../constants';
 
 export interface MuteAlertInstanceParams {

src/platform/packages/shared/response-ops/alerts-apis/apis/unmute_alert_instance.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { HttpSetup } from '@kbn/core/public';
+import type { HttpSetup } from '@kbn/core/public';
 import { BASE_ALERTING_API_PATH } from '../constants';
 
 export interface UnmuteAlertInstanceParams {

src/platform/packages/shared/response-ops/alerts-apis/types.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { IHttpFetchError, ResponseErrorBody } from '@kbn/core-http-browser';
+import type { IHttpFetchError, ResponseErrorBody } from '@kbn/core-http-browser';
 
 export type ServerError = IHttpFetchError<ResponseErrorBody>;
 

src/platform/packages/shared/response-ops/alerts-fields-browser/components/categories_badges/categories_badges.styles.ts

@@ -8,7 +8,7 @@
  */
 
 import { css } from '@emotion/react';
-import { UseEuiTheme } from '@elastic/eui';
+import type { UseEuiTheme } from '@elastic/eui';
 
 export const styles = {
   badgesGroup: ({ euiTheme }: { euiTheme: UseEuiTheme['euiTheme'] }) => css`

src/platform/packages/shared/response-ops/alerts-fields-browser/components/field_table/field_table.styles.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { UseEuiTheme } from '@elastic/eui';
+import type { UseEuiTheme } from '@elastic/eui';
 import { css } from '@emotion/react';
 
 export const styles = {

src/platform/packages/shared/response-ops/alerts-fields-browser/helpers.ts

@@ -7,12 +7,9 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { EcsMetadata } from '@kbn/alerts-as-data-utils/src/field_maps/types';
-import {
-  ALERT_CASE_IDS,
-  ALERT_MAINTENANCE_WINDOW_IDS,
-  DefaultAlertFieldName,
-} from '@kbn/rule-data-utils';
+import type { EcsMetadata } from '@kbn/alerts-as-data-utils/src/field_maps/types';
+import type { DefaultAlertFieldName } from '@kbn/rule-data-utils';
+import { ALERT_CASE_IDS, ALERT_MAINTENANCE_WINDOW_IDS } from '@kbn/rule-data-utils';
 import type { BrowserField, BrowserFields } from '@kbn/rule-registry-plugin/common';
 import { isEmpty } from 'lodash/fp';
 import { CASES, MAINTENANCE_WINDOWS } from './translations';

src/platform/packages/shared/response-ops/alerts-fields-browser/mock.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { MappingRuntimeFields } from '@elastic/elasticsearch/lib/api/types';
+import type { MappingRuntimeFields } from '@elastic/elasticsearch/lib/api/types';
 import type { BrowserFields } from '@kbn/rule-registry-plugin/common';
 
 const DEFAULT_INDEX_PATTERN = [

src/platform/packages/shared/response-ops/alerts-table/apis/bulk_get_cases.ts

@@ -7,8 +7,8 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { CaseStatuses } from '@kbn/cases-components';
-import { HttpStart } from '@kbn/core-http-browser';
+import type { CaseStatuses } from '@kbn/cases-components';
+import type { HttpStart } from '@kbn/core-http-browser';
 
 const INTERNAL_BULK_GET_CASES_URL = '/internal/cases/_bulk_get';
 

src/platform/packages/shared/response-ops/alerts-table/configuration.ts

@@ -20,7 +20,7 @@ import {
   ALERT_STATUS,
   TIMESTAMP,
 } from '@kbn/rule-data-utils';
-import { SortCombinations } from '@elastic/elasticsearch/lib/api/types';
+import type { SortCombinations } from '@elastic/elasticsearch/lib/api/types';
 import { i18n } from '@kbn/i18n';
 import { FEATURE_LABEL } from './translations';
 

src/platform/packages/shared/response-ops/alerts-table/constants.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { EuiIconType } from '@elastic/eui/src/components/icon/icon';
+import type { EuiIconType } from '@elastic/eui/src/components/icon/icon';
 import { AlertConsumers } from '@kbn/rule-data-utils';
 import type { SortCombinations } from '@elastic/elasticsearch/lib/api/types';
 import {
@@ -22,7 +22,7 @@ import {
   STACK_MONITORING_DISPLAY_NAME,
   UPTIME_DISPLAY_NAME,
 } from './translations';
-import { AlertsTableSupportedConsumers } from './types';
+import type { AlertsTableSupportedConsumers } from './types';
 
 interface AlertProducerData {
   displayName: string;

src/platform/packages/shared/response-ops/alerts-table/hooks/toggle_column.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { EuiDataGridColumn } from '@elastic/eui';
+import type { EuiDataGridColumn } from '@elastic/eui';
 import { ALERT_CASE_IDS, ALERT_MAINTENANCE_WINDOW_IDS } from '@kbn/rule-data-utils';
 import * as i18n from '../translations';
 

src/platform/packages/shared/response-ops/alerts-table/hooks/use_bulk_actions.ts

@@ -7,8 +7,9 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import React, { useCallback, useEffect, useMemo } from 'react';
-import { QueryDslQueryContainer } from '@elastic/elasticsearch/lib/api/types';
+import type React from 'react';
+import { useCallback, useEffect, useMemo } from 'react';
+import type { QueryDslQueryContainer } from '@elastic/elasticsearch/lib/api/types';
 import { ALERT_CASE_IDS, isSiemRuleType } from '@kbn/rule-data-utils';
 import type { HttpStart } from '@kbn/core-http-browser';
 import type { NotificationsStart } from '@kbn/core-notifications-browser';
@@ -306,7 +307,7 @@ export function useBulkActions({
     updateBulkActionsState({ action: BulkActionsVerbs.clear });
   }, [updateBulkActionsState]);
   const setIsBulkActionsLoading = useCallback(
-    (isLoading: boolean = true) => {
+    (isLoading = true) => {
       updateBulkActionsState({ action: BulkActionsVerbs.updateAllLoadingState, isLoading });
     },
     [updateBulkActionsState]

src/platform/packages/shared/response-ops/alerts-table/hooks/use_case_view_navigation.ts

@@ -10,7 +10,7 @@
 import { generatePath } from 'react-router-dom';
 import useObservable from 'react-use/lib/useObservable';
 import { useCallback } from 'react';
-import { ApplicationStart } from '@kbn/core-application-browser';
+import type { ApplicationStart } from '@kbn/core-application-browser';
 
 type NavigateToCaseView = (pathParams: { caseId: string }) => void;
 

src/platform/packages/shared/response-ops/alerts-table/hooks/use_columns.ts

@@ -8,9 +8,9 @@
  */
 
 import { type MutableRefObject, useCallback, useEffect, useMemo, useRef, useState } from 'react';
-import { EuiDataGridColumn, EuiDataGridOnColumnResizeData } from '@elastic/eui';
-import { IStorageWrapper } from '@kbn/kibana-utils-plugin/public';
-import { BrowserField, BrowserFields } from '@kbn/alerting-types';
+import type { EuiDataGridColumn, EuiDataGridOnColumnResizeData } from '@elastic/eui';
+import type { IStorageWrapper } from '@kbn/kibana-utils-plugin/public';
+import type { BrowserField, BrowserFields } from '@kbn/alerting-types';
 import { isEmpty } from 'lodash';
 import { useFetchAlertsFieldsQuery } from '@kbn/alerts-ui-shared/src/common/hooks/use_fetch_alerts_fields_query';
 import { AlertsQueryContext } from '@kbn/alerts-ui-shared/src/common/contexts/alerts_query_context';

src/platform/packages/shared/response-ops/alerts-table/hooks/use_pagination.test.ts

@@ -7,7 +7,8 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 import { renderHook, act } from '@testing-library/react';
-import { PaginationProps, usePagination } from './use_pagination';
+import type { PaginationProps } from './use_pagination';
+import { usePagination } from './use_pagination';
 
 describe('usePagination', () => {
   const onPageChange = jest.fn();

src/platform/packages/shared/response-ops/alerts-table/hooks/use_pagination.ts

@@ -10,7 +10,7 @@
 import { useCallback, useEffect, useState } from 'react';
 import type { RuleRegistrySearchRequestPagination } from '@kbn/rule-registry-plugin/common';
 import { BulkActionsVerbs } from '../types';
-import { AdditionalContext, RenderContext } from '../types';
+import type { AdditionalContext, RenderContext } from '../types';
 
 export type PaginationProps = RuleRegistrySearchRequestPagination & {
   bulkActionsStore: RenderContext<AdditionalContext>['bulkActionsStore'];

src/platform/packages/shared/response-ops/alerts-table/hooks/use_sorting.ts

@@ -9,7 +9,7 @@
 
 import type { SortCombinations } from '@elastic/elasticsearch/lib/api/types';
 import type { EuiDataGridSorting } from '@elastic/eui';
-import { EuiDataGridColumnSortingConfig } from '@elastic/eui/src/components/datagrid/data_grid_types';
+import type { EuiDataGridColumnSortingConfig } from '@elastic/eui/src/components/datagrid/data_grid_types';
 import { useCallback, useMemo, useState } from 'react';
 import { defaultSort } from '../constants';
 

src/platform/packages/shared/response-ops/alerts-table/reducers/bulk_actions_reducer.ts

@@ -7,7 +7,8 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { BulkActionsReducerAction, BulkActionsState, BulkActionsVerbs } from '../types';
+import type { BulkActionsReducerAction, BulkActionsState } from '../types';
+import { BulkActionsVerbs } from '../types';
 
 const getAllRowsInPage = (rowCount: number) =>
   new Map(Array.from(Array(rowCount).keys()).map((idx) => [idx, { isLoading: false }]));

src/platform/packages/shared/response-ops/alerts-table/types.ts

@@ -20,7 +20,7 @@ import type {
   RefAttributes,
   SetStateAction,
 } from 'react';
-import {
+import type {
   AlertConsumers,
   ALERT_CASE_IDS,
   ALERT_STATUS,

src/platform/packages/shared/response-ops/alerts-table/utils/react.ts

@@ -7,7 +7,9 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import React, { forwardRef, memo, ReactElement } from 'react';
+import type { ReactElement } from 'react';
+import type React from 'react';
+import { forwardRef, memo } from 'react';
 
 /**
  * A `React.memo` variant that keeps generic type information

src/platform/packages/shared/response-ops/alerts-table/utils/storage.test.ts

@@ -9,7 +9,7 @@
 
 import type { MockedKeys } from '@kbn/utility-types-jest';
 import { Storage } from './storage';
-import { IStorageWrapper, IStorage } from '@kbn/kibana-utils-plugin/public';
+import type { IStorageWrapper, IStorage } from '@kbn/kibana-utils-plugin/public';
 
 const payload = { first: 'john', last: 'smith' };
 const createMockStore = (): MockedKeys<IStorage> => {

src/platform/packages/shared/response-ops/alerts-table/utils/storage.ts

@@ -33,7 +33,7 @@ export class Storage implements IStorageWrapper {
     }
   };
 
-  public set = (key: string, value: any, includeUndefined: boolean = false) => {
+  public set = (key: string, value: any, includeUndefined = false) => {
     const replacer = includeUndefined
       ? (_: string, currentValue: any) =>
           typeof currentValue === 'undefined' ? null : currentValue

src/platform/packages/shared/response-ops/alerts-table/utils/test.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { DeepPartial } from 'utility-types';
+import type { DeepPartial } from 'utility-types';
 import MaybeMockedDeep = jest.MaybeMockedDeep;
 
 /**

src/platform/packages/shared/response-ops/rule_form/src/common/apis/create_rule/create_rule.test.ts

@@ -8,9 +8,9 @@
  */
 
 import { httpServiceMock } from '@kbn/core/public/mocks';
-import { RuleTypeParams } from '../../types';
+import type { RuleTypeParams } from '../../types';
 import { createRule } from './create_rule';
-import { CreateRuleBody } from './types';
+import type { CreateRuleBody } from './types';
 
 const http = httpServiceMock.createStartContract();
 

src/platform/packages/shared/response-ops/rule_form/src/common/apis/create_rule/create_rule.ts

@@ -10,7 +10,8 @@
 import type { HttpSetup } from '@kbn/core/public';
 import type { AsApiContract } from '@kbn/actions-types';
 import type { Rule } from '../../types';
-import { CreateRuleBody, transformCreateRuleBody } from '.';
+import type { CreateRuleBody } from '.';
+import { transformCreateRuleBody } from '.';
 import { BASE_ALERTING_API_PATH } from '../../../constants';
 import { transformRule } from '../../transformations';
 

src/platform/packages/shared/response-ops/rule_form/src/common/apis/create_rule/transform_create_rule_body.ts

@@ -7,9 +7,9 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { RewriteResponseCase } from '@kbn/actions-types';
-import { CreateRuleBody } from './types';
-import { Rule } from '../../types';
+import type { RewriteResponseCase } from '@kbn/actions-types';
+import type { CreateRuleBody } from './types';
+import type { Rule } from '../../types';
 
 const transformCreateRuleFlapping = (flapping: Rule['flapping']) => {
   if (!flapping) {

src/platform/packages/shared/response-ops/rule_form/src/common/apis/create_rule/types.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { Rule, RuleTypeParams } from '../../types';
+import type { Rule, RuleTypeParams } from '../../types';
 
 export interface CreateRuleBody<Params extends RuleTypeParams = RuleTypeParams> {
   name: Rule<Params>['name'];

src/platform/packages/shared/response-ops/rule_form/src/common/apis/fetch_rule_types.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { HttpSetup } from '@kbn/core/public';
+import type { HttpSetup } from '@kbn/core/public';
 import type { AsApiContract, RewriteRequestCase } from '@kbn/actions-types';
 import type { RuleType } from '@kbn/triggers-actions-ui-types';
 import { BASE_ALERTING_API_PATH } from '../../constants';

src/platform/packages/shared/response-ops/rule_form/src/common/apis/fetch_ui_config/fetch_ui_config.ts

@@ -9,7 +9,7 @@
 
 import type { HttpStart } from '@kbn/core-http-browser';
 import { BASE_TRIGGERS_ACTIONS_UI_API_PATH } from '../../../constants';
-import { UiConfig } from '.';
+import type { UiConfig } from '.';
 
 export const fetchUiConfig = async ({ http }: { http: HttpStart }): Promise<UiConfig> => {
   return http.get<UiConfig>(`${BASE_TRIGGERS_ACTIONS_UI_API_PATH}/_config`);

src/platform/packages/shared/response-ops/rule_form/src/common/apis/resolve_rule/resolve_rule.ts

@@ -7,11 +7,11 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { HttpSetup } from '@kbn/core-http-browser';
-import { AsApiContract } from '@kbn/actions-types';
+import type { HttpSetup } from '@kbn/core-http-browser';
+import type { AsApiContract } from '@kbn/actions-types';
 import { INTERNAL_BASE_ALERTING_API_PATH } from '../../../constants';
 import { transformResolvedRule } from '../../transformations';
-import { ResolvedRule } from '../../types';
+import type { ResolvedRule } from '../../types';
 
 export async function resolveRule({
   http,

src/platform/packages/shared/response-ops/rule_form/src/common/apis/update_rule/transform_update_rule_body.test.ts

@@ -7,9 +7,9 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { RuleTypeParams } from '../../types';
+import type { RuleTypeParams } from '../../types';
 import { transformUpdateRuleBody } from './transform_update_rule_body';
-import { UpdateRuleBody } from './types';
+import type { UpdateRuleBody } from './types';
 
 const ruleToUpdate: UpdateRuleBody<RuleTypeParams> = {
   params: {

src/platform/packages/shared/response-ops/rule_form/src/common/apis/update_rule/transform_update_rule_body.ts

@@ -7,9 +7,9 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { RewriteResponseCase } from '@kbn/actions-types';
-import { UpdateRuleBody } from './types';
-import { Rule } from '../../types';
+import type { RewriteResponseCase } from '@kbn/actions-types';
+import type { UpdateRuleBody } from './types';
+import type { Rule } from '../../types';
 
 const transformUpdateRuleFlapping = (flapping: Rule['flapping']) => {
   if (!flapping) {

src/platform/packages/shared/response-ops/rule_form/src/common/apis/update_rule/update_rule.test.ts

@@ -8,7 +8,8 @@
  */
 
 import { httpServiceMock } from '@kbn/core/public/mocks';
-import { updateRule, UpdateRuleBody } from '.';
+import type { UpdateRuleBody } from '.';
+import { updateRule } from '.';
 
 const http = httpServiceMock.createStartContract();