Skip to content

Comments

[Security Solution][Sourcerer] Add dedicated scope for explore pages#226545

Merged
lgestc merged 12 commits intoelastic:mainfrom
lgestc:explore_data_view_manager_scope
Jul 9, 2025
Merged

[Security Solution][Sourcerer] Add dedicated scope for explore pages#226545
lgestc merged 12 commits intoelastic:mainfrom
lgestc:explore_data_view_manager_scope

Conversation

@lgestc
Copy link
Contributor

@lgestc lgestc commented Jul 4, 2025

Summary

This PR adds dedicated ad-hoc data view and scope for explore pages.

Testing

Flip the flag, then navigate to Explore section of the security plugin.

xpack.securitySolution.enableExperimental: ['newDataViewPickerEnabled']

You should see "Explore Data View" in the new picker on top of the page. Using inspector widget on every visualisation / table should show the updated index pattern that does not hit the alerts. You can try going back and forth between the default security data view and the explore one and compare the pattern rendered in the inspector to confirm that.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@lgestc lgestc marked this pull request as ready for review July 8, 2025 06:59
@lgestc lgestc requested review from a team as code owners July 8, 2025 06:59
@lgestc lgestc added v9.0.0 Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team backport:version Backport to applied version labels v9.1.0 v8.19.0 v9.2.0 labels Jul 8, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@lgestc lgestc added the release_note:skip Skip the PR/issue when compiling release notes label Jul 8, 2025
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Desk tested and everything looks to be working well. I left a couple of comments in the code.

Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Desk tested and code LGTM. Nice work!

One small thing I noticed is that we show a Temporary label next to this new dataView. We briefly talked about it on Slack and we should probably show Managed instead.
This will be tackled in a follow-up PR (as this code is still behind a disabled feature flag).
Screenshot 2025-07-09 at 1 06 48 PM

@PhilippeOberti
Copy link
Contributor

PhilippeOberti commented Jul 9, 2025

@lgestc shouldn't we remove the 9.0.0 label? I think we want this only in 8.19, 9.1 and main (9.2) right?

@lgestc lgestc merged commit 9a45666 into elastic:main Jul 9, 2025
12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/16169111516

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #38 / Unified Tabs Examples Managing Unified Tabs can edit tab label with keyboard events

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 7809 7810 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.8MB 9.8MB +998.0B

History

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.19:
- [Investigations] - Improve useFieldBrowser performance (#225859)
9.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.0:
- [SecuritySolution] Numbers of Network KPI metric are cropped (#211460)
9.1 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.1:
- [Investigations] - Improve useFieldBrowser performance (#225859)
- [Security Solution] Fix initial data view flash (#225675)
- [Security Solution] [EUI Refresh] [Explore page] Migrate styled-components (#207318)

Manual backport

To create the backport manually run:

node scripts/backport --pr 226545

Questions ?

Please refer to the Backport tool documentation

@lgestc lgestc removed the v9.0.0 label Jul 9, 2025
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 10, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 226545 locally
cc: @lgestc

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 226545 locally
cc: @lgestc

@lgestc lgestc added backport:version Backport to applied version labels and removed backport:version Backport to applied version labels labels Jul 14, 2025
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16266286636

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts
9.1 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.1:
- [Security Solution] Fix initial data view flash (#225675)
- [Security Solution] [EUI Refresh] [Explore page] Migrate styled-components (#207318)

Manual backport

To create the backport manually run:

node scripts/backport --pr 226545

Questions ?

Please refer to the Backport tool documentation

lgestc added a commit to lgestc/kibana that referenced this pull request Jul 14, 2025
…lastic#226545)

This PR adds dedicated ad-hoc data view and scope for explore pages.

Flip the flag, then navigate to Explore section of the security plugin.

```
xpack.securitySolution.enableExperimental: ['newDataViewPickerEnabled']
```

You should see "Explore Data View" in the new picker on top of the page.
Using `inspector` widget on every visualisation / table should show the
updated index pattern that does not hit the alerts. You can try going
back and forth between the default security data view and the explore
one and compare the pattern rendered in the inspector to confirm that.

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 9a45666)
@lgestc
Copy link
Contributor Author

lgestc commented Jul 14, 2025

💚 All backports created successfully

Status Branch Result
9.1
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

lgestc added a commit to lgestc/kibana that referenced this pull request Jul 14, 2025
…lastic#226545)

## Summary

This PR adds dedicated ad-hoc data view and scope for explore pages.

## Testing
Flip the flag, then navigate to Explore section of the security plugin.

```
xpack.securitySolution.enableExperimental: ['newDataViewPickerEnabled']
```

You should see "Explore Data View" in the new picker on top of the page.
Using `inspector` widget on every visualisation / table should show the
updated index pattern that does not hit the alerts. You can try going
back and forth between the default security data view and the explore
one and compare the pattern rendered in the inspector to confirm that.

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 9a45666)

# Conflicts:
#	x-pack/solutions/security/plugins/security_solution/public/explore/hosts/pages/details/index.tsx
#	x-pack/solutions/security/plugins/security_solution/public/explore/network/pages/network.tsx
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @lgestc

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @lgestc

lgestc added a commit that referenced this pull request Jul 16, 2025
… pages (#226545) (#227813)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Security Solution][Sourcerer] Add dedicated scope for explore pages
(#226545)](#226545)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Luke
Gmys","email":"11671118+lgestc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-09T12:18:50Z","message":"[Security
Solution][Sourcerer] Add dedicated scope for explore pages
(#226545)\n\n## Summary\n\nThis PR adds dedicated ad-hoc data view and
scope for explore pages.\n\n## Testing\nFlip the flag, then navigate to
Explore section of the security
plugin.\n\n```\nxpack.securitySolution.enableExperimental:
['newDataViewPickerEnabled']\n```\n\nYou should see \"Explore Data
View\" in the new picker on top of the page.\nUsing `inspector` widget
on every visualisation / table should show the\nupdated index pattern
that does not hit the alerts. You can try going\nback and forth between
the default security data view and the explore\none and compare the
pattern rendered in the inspector to confirm that.\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"9a45666aff2611a459faf6f03e1741ba6e0ad24a","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","Team:Threat
Hunting:Investigations","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Security
Solution][Sourcerer] Add dedicated scope for explore
pages","number":226545,"url":"https://github.com/elastic/kibana/pull/226545","mergeCommit":{"message":"[Security
Solution][Sourcerer] Add dedicated scope for explore pages
(#226545)\n\n## Summary\n\nThis PR adds dedicated ad-hoc data view and
scope for explore pages.\n\n## Testing\nFlip the flag, then navigate to
Explore section of the security
plugin.\n\n```\nxpack.securitySolution.enableExperimental:
['newDataViewPickerEnabled']\n```\n\nYou should see \"Explore Data
View\" in the new picker on top of the page.\nUsing `inspector` widget
on every visualisation / table should show the\nupdated index pattern
that does not hit the alerts. You can try going\nback and forth between
the default security data view and the explore\none and compare the
pattern rendered in the inspector to confirm that.\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"9a45666aff2611a459faf6f03e1741ba6e0ad24a"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226545","number":226545,"mergeCommit":{"message":"[Security
Solution][Sourcerer] Add dedicated scope for explore pages
(#226545)\n\n## Summary\n\nThis PR adds dedicated ad-hoc data view and
scope for explore pages.\n\n## Testing\nFlip the flag, then navigate to
Explore section of the security
plugin.\n\n```\nxpack.securitySolution.enableExperimental:
['newDataViewPickerEnabled']\n```\n\nYou should see \"Explore Data
View\" in the new picker on top of the page.\nUsing `inspector` widget
on every visualisation / table should show the\nupdated index pattern
that does not hit the alerts. You can try going\nback and forth between
the default security data view and the explore\none and compare the
pattern rendered in the inspector to confirm that.\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"9a45666aff2611a459faf6f03e1741ba6e0ad24a"}}]}]
BACKPORT-->
lgestc added a commit that referenced this pull request Jul 16, 2025
…pages (#226545) (#227811)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Security Solution][Sourcerer] Add dedicated scope for explore pages
(#226545)](#226545)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Luke
Gmys","email":"11671118+lgestc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-09T12:18:50Z","message":"[Security
Solution][Sourcerer] Add dedicated scope for explore pages
(#226545)\n\n## Summary\n\nThis PR adds dedicated ad-hoc data view and
scope for explore pages.\n\n## Testing\nFlip the flag, then navigate to
Explore section of the security
plugin.\n\n```\nxpack.securitySolution.enableExperimental:
['newDataViewPickerEnabled']\n```\n\nYou should see \"Explore Data
View\" in the new picker on top of the page.\nUsing `inspector` widget
on every visualisation / table should show the\nupdated index pattern
that does not hit the alerts. You can try going\nback and forth between
the default security data view and the explore\none and compare the
pattern rendered in the inspector to confirm that.\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"9a45666aff2611a459faf6f03e1741ba6e0ad24a","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","Team:Threat
Hunting:Investigations","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Security
Solution][Sourcerer] Add dedicated scope for explore
pages","number":226545,"url":"https://github.com/elastic/kibana/pull/226545","mergeCommit":{"message":"[Security
Solution][Sourcerer] Add dedicated scope for explore pages
(#226545)\n\n## Summary\n\nThis PR adds dedicated ad-hoc data view and
scope for explore pages.\n\n## Testing\nFlip the flag, then navigate to
Explore section of the security
plugin.\n\n```\nxpack.securitySolution.enableExperimental:
['newDataViewPickerEnabled']\n```\n\nYou should see \"Explore Data
View\" in the new picker on top of the page.\nUsing `inspector` widget
on every visualisation / table should show the\nupdated index pattern
that does not hit the alerts. You can try going\nback and forth between
the default security data view and the explore\none and compare the
pattern rendered in the inspector to confirm that.\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"9a45666aff2611a459faf6f03e1741ba6e0ad24a"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226545","number":226545,"mergeCommit":{"message":"[Security
Solution][Sourcerer] Add dedicated scope for explore pages
(#226545)\n\n## Summary\n\nThis PR adds dedicated ad-hoc data view and
scope for explore pages.\n\n## Testing\nFlip the flag, then navigate to
Explore section of the security
plugin.\n\n```\nxpack.securitySolution.enableExperimental:
['newDataViewPickerEnabled']\n```\n\nYou should see \"Explore Data
View\" in the new picker on top of the page.\nUsing `inspector` widget
on every visualisation / table should show the\nupdated index pattern
that does not hit the alerts. You can try going\nback and forth between
the default security data view and the explore\none and compare the
pattern rendered in the inspector to confirm that.\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ] Any text
added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"9a45666aff2611a459faf6f03e1741ba6e0ad24a"}}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 16, 2025
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
…lastic#226545)

## Summary

This PR adds dedicated ad-hoc data view and scope for explore pages.

## Testing
Flip the flag, then navigate to Explore section of the security plugin.

```
xpack.securitySolution.enableExperimental: ['newDataViewPickerEnabled']
```

You should see "Explore Data View" in the new picker on top of the page.
Using `inspector` widget on every visualisation / table should show the
updated index pattern that does not hit the alerts. You can try going
back and forth between the default security data view and the explore
one and compare the pattern rendered in the inspector to confirm that.


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.19.0 v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants