Skip to content

Comments

[8.x] [Security Solution] [EUI Refresh] [Explore page] Migrate styled-components (#207318)#208928

Merged
kibanamachine merged 2 commits intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-207318
Feb 11, 2025
Merged

[8.x] [Security Solution] [EUI Refresh] [Explore page] Migrate styled-components (#207318)#208928
kibanamachine merged 2 commits intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-207318

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@kapral18 kapral18 force-pushed the backport/8.x/pr-207318 branch 3 times, most recently from ce9b053 to 1915a0b Compare February 11, 2025 06:43
agusruidiazgd and others added 2 commits February 11, 2025 19:01
…nents (elastic#207318)

Addresses [elastic#206437](elastic#206437)
This PR migrates `explore page` from `styled-components` to
`@emotion/styled`.
In the process I also convert the kbn/ui-theme json tokens to euiTheme
counterparts.

https://github.com/user-attachments/assets/f1702c0d-78f7-4e17-a8d6-c7c9ae19d3b7

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 1e63b5a)
@kapral18 kapral18 force-pushed the backport/8.x/pr-207318 branch from 8c4ace8 to 1922cbd Compare February 11, 2025 18:01
@kapral18 kapral18 assigned kapral18 and unassigned agusruidiazgd Feb 11, 2025
@kibanamachine kibanamachine merged commit ad10df9 into elastic:8.x Feb 11, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 18.7MB 18.7MB -3.4KB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 577 578 +1

Total ESLint disabled count

id before after diff
securitySolution 660 661 +1

History

  • 💔 Build #274974 failed 1915a0b82846a604f125c08e7bf2022f9f5dc93e
  • 💔 Build #273687 failed ce9b053f67517667f3826b21612d7750d40c5c4a
  • 💔 Build #273126 failed 9d4c8f45d3d2231b0600fa4199b9c27ff3a37bed
  • 💔 Build #271955 failed 22846e8a39fcd9e30b189426a7bf6d2356108aba

cc @kapral18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants