Sustainable Kibana Architecture: Move modules owned by @elastic/security-threat-hunting#203046
Merged
PhilippeOberti merged 5 commits intoelastic:mainfrom Dec 13, 2024
Conversation
gsoldevila
added
Team:Core
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
gsoldevila
force-pushed
the
kbn-team-1309-move-security-threat-hunting
branch
from
88ba31b to
764bb32
Compare
Ikuni17
approved these changes
Dec 11, 2024
PhilippeOberti
force-pushed
the
kbn-team-1309-move-security-threat-hunting
branch
from
d4ba2e2 to
7cc85d2
Compare
PhilippeOberti
approved these changes
Dec 12, 2024
Contributor
PhilippeOberti
left a comment
PhilippeOberti
left a comment
There was a problem hiding this comment.
desk tested and code LGTM!
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
|
PhilippeOberti
added
v8.18.0
backport:version
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12309614864 |
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12309614865 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 similar comment
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
1 task
PhilippeOberti
added a commit
that referenced
this pull request
Dec 13, 2024
…c/security-threat-hunting` (#203046) (#204169) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Move modules owned by `@elastic/security-threat-hunting` (#203046)](#203046) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2024-12-13T04:29:21Z","message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/security-threat-hunting` (#203046)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> * This PR has been auto-generated.\r\n> * Any manual contributions will be lost if the 'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews / approvals before applying manual\r\nfixes, and/or keep your changes in a .patch / git stash.\r\n> * Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n#### 2 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/data-stream-adapter` |\r\n`x-pack/solutions/security/packages/kbn-data-stream-adapter` |\r\n| `@kbn/index-adapter` |\r\n`x-pack/solutions/security/packages/kbn-index-adapter` |\r\n\r\n---------\r\n\r\nCo-authored-by: PhilippeOberti <philippe.oberti@elastic.co>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a9f076cb1f73fb6b4045f3218e9181e424625b29","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","Team:Threat Hunting","backport:version","v8.18.0"],"number":203046,"url":"https://github.com/elastic/kibana/pull/203046","mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/security-threat-hunting` (#203046)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> * This PR has been auto-generated.\r\n> * Any manual contributions will be lost if the 'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews / approvals before applying manual\r\nfixes, and/or keep your changes in a .patch / git stash.\r\n> * Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n#### 2 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/data-stream-adapter` |\r\n`x-pack/solutions/security/packages/kbn-data-stream-adapter` |\r\n| `@kbn/index-adapter` |\r\n`x-pack/solutions/security/packages/kbn-index-adapter` |\r\n\r\n---------\r\n\r\nCo-authored-by: PhilippeOberti <philippe.oberti@elastic.co>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a9f076cb1f73fb6b4045f3218e9181e424625b29"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203046","number":203046,"mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/security-threat-hunting` (#203046)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> * This PR has been auto-generated.\r\n> * Any manual contributions will be lost if the 'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews / approvals before applying manual\r\nfixes, and/or keep your changes in a .patch / git stash.\r\n> * Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n#### 2 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/data-stream-adapter` |\r\n`x-pack/solutions/security/packages/kbn-data-stream-adapter` |\r\n| `@kbn/index-adapter` |\r\n`x-pack/solutions/security/packages/kbn-index-adapter` |\r\n\r\n---------\r\n\r\nCo-authored-by: PhilippeOberti <philippe.oberti@elastic.co>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a9f076cb1f73fb6b4045f3218e9181e424625b29"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>
rudolf
added
the
plugin groups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.
Important
packages[\/\\]andplugins[\/\\]patterns in the source code (Babel and Eslint config files), and update them appropriately..buildkite/scripts/pipelines/pull_request/pipeline.tsto ensure that any CI pipeline customizations continue to be correctly applied after the changed path names.tsand.jsfiles listed in the sections below, as some of them contain relative paths that have been updated.Note
2 packages(s) are going to be relocated:
@kbn/data-stream-adapterx-pack/solutions/security/packages/kbn-data-stream-adapter@kbn/index-adapterx-pack/solutions/security/packages/kbn-index-adapterUpdated references
Updated relative paths