Sustainable Kibana Architecture: Move modules owned by @elastic/security-threat-hunting-investigations#202855
Merged
PhilippeOberti merged 8 commits intoelastic:mainfrom Dec 12, 2024
Conversation
Contributor
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
gsoldevila
added
Team:Core
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
PhilippeOberti
approved these changes
Dec 4, 2024
Contributor
PhilippeOberti
left a comment
PhilippeOberti
left a comment
There was a problem hiding this comment.
code LGTM and smoke tested locally everything looks to be working (tested alerts page, timeline, timelines page, cases interaction with alerts, intelligence page, alert/host/user/rule flyouts...)
Thank you for making this change, excited about where Kibana is going!!
PhilippeOberti
requested changes
Dec 4, 2024
Contributor
There was a problem hiding this comment.
@gsoldevila actually I have a few questions and want to make sure we answer them before merging (sorry for approving too quickly above):
- I see that the
data-tablepackage was moved underx-pack/solutions/security/packages/security-solution/data_tablebut wouldn't it make sense to have it directly underx-pack/solutions/security/packages/data_table. What was the idea behind nesting it under one moresecurity-solutionfolder at the end?
- also I wonder what's the value in keeping the word
kbnin thekbn-expandable-flyoutpackage now that it's moved under/solutions/security? - we are actually in the process of nuking the timelines plugin entirely (@kqualters-elastic has a local branch with those changes). Should we wait before merging this PR? If we remove it first this PR would be a lot less involved...
What's the urgency in merging this?
Finally, let me know if you need help making some of the changes, and fixing the build (it seems to be some jest config issues as well as some translations).
I'm happy to take a look and help out if you want!
gsoldevila
force-pushed
the
kbn-team-1309-move-kibana-security-threat-hunting-investigations
branch
from
50e4271 to
a1ec7cc
Compare
rudolf
approved these changes
Dec 9, 2024
gsoldevila
force-pushed
the
kbn-team-1309-move-kibana-security-threat-hunting-investigations
branch
from
b053e6f to
8d5b171
Compare
Contributor
|
@gsoldevila I'm going to wait before re-reviewing this PR as the |
Ikuni17
approved these changes
Dec 10, 2024
PhilippeOberti
force-pushed
the
kbn-team-1309-move-kibana-security-threat-hunting-investigations
branch
from
c5e5026 to
35f6c67
Compare
…ranslations with securitySolutionPackages.
PhilippeOberti
added
backport:prev-minor
and removed
backport:skip
…omponents_files.js`
PhilippeOberti
approved these changes
Dec 12, 2024
Contributor
PhilippeOberti
left a comment
PhilippeOberti
left a comment
There was a problem hiding this comment.
desk tested aND CODE LGTM! Only small miss is the yarn storybook expandable_flyout command does not work anymore. Using yarn storybook security_solution_packages works just fine though and renders the expandable flyout stories we we're good.
We'll have to remember to remove the expandable_flyout alias from the storybook options, but that can be done in a follow up PR (to save the CI to run another time)
PhilippeOberti
added
v9.0.0
v8.18.0
Team:Threat Hunting:Investigations
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12305802059 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
PhilippeOberti
pushed a commit
to PhilippeOberti/kibana
that referenced
this pull request
Dec 13, 2024
…rity-threat-hunting-investigations` (elastic#202855) ## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. #### 2 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/threat-intelligence-plugin` | `x-pack/solutions/security/plugins/threat_intelligence` | | `@kbn/timelines-plugin` | `x-pack/solutions/security/plugins/timelines` | #### 2 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/expandable-flyout` | `x-pack/solutions/security/packages/kbn-expandable-flyout` | | `@kbn/securitysolution-data-table` | `x-pack/solutions/security/packages/data_table` | Co-authored-by: PhilippeOberti <philippe.oberti@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 33c18c7) # Conflicts: # .github/CODEOWNERS # x-pack/solutions/security/packages/expandable-flyout/src/with_provider.test.tsx # x-pack/solutions/security/packages/expandable-flyout/src/with_provider.tsx
PhilippeOberti
added a commit
that referenced
this pull request
Dec 13, 2024
…c/security-threat-hunting-investigations` (#202855) (#204150) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Move modules owned by `@elastic/security-threat-hunting-investigations` (#202855)](#202855) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2024-12-12T22:22:03Z","message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/security-threat-hunting-investigations` (#202855)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> * This PR has been auto-generated.\r\n> * Any manual contributions will be lost if the 'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews / approvals before applying manual\r\nfixes, and/or keep your changes in a .patch / git stash.\r\n> * Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n#### 2 plugin(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/threat-intelligence-plugin` |\r\n`x-pack/solutions/security/plugins/threat_intelligence` |\r\n| `@kbn/timelines-plugin` |\r\n`x-pack/solutions/security/plugins/timelines` |\r\n\r\n#### 2 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/expandable-flyout` |\r\n`x-pack/solutions/security/packages/kbn-expandable-flyout` |\r\n| `@kbn/securitysolution-data-table` |\r\n`x-pack/solutions/security/packages/data_table` |\r\n\r\nCo-authored-by: PhilippeOberti <philippe.oberti@elastic.co>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"33c18c72fa019430c6b73503dc3176e0136e3861","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Investigations","backport:prev-minor","v8.18.0"],"number":202855,"url":"https://github.com/elastic/kibana/pull/202855","mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/security-threat-hunting-investigations` (#202855)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> * This PR has been auto-generated.\r\n> * Any manual contributions will be lost if the 'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews / approvals before applying manual\r\nfixes, and/or keep your changes in a .patch / git stash.\r\n> * Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n#### 2 plugin(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/threat-intelligence-plugin` |\r\n`x-pack/solutions/security/plugins/threat_intelligence` |\r\n| `@kbn/timelines-plugin` |\r\n`x-pack/solutions/security/plugins/timelines` |\r\n\r\n#### 2 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/expandable-flyout` |\r\n`x-pack/solutions/security/packages/kbn-expandable-flyout` |\r\n| `@kbn/securitysolution-data-table` |\r\n`x-pack/solutions/security/packages/data_table` |\r\n\r\nCo-authored-by: PhilippeOberti <philippe.oberti@elastic.co>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"33c18c72fa019430c6b73503dc3176e0136e3861"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202855","number":202855,"mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/security-threat-hunting-investigations` (#202855)\n\n## Summary\r\n\r\nThis PR aims at relocating some of the Kibana modules (plugins and\r\npackages) into a new folder structure, according to the _Sustainable\r\nKibana Architecture_ initiative.\r\n\r\n> [!IMPORTANT]\r\n> * We kindly ask you to:\r\n> * Manually fix the errors in the error section below (if there are\r\nany).\r\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\r\nsource code (Babel and Eslint config files), and update them\r\nappropriately.\r\n> * Manually review\r\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\r\nany CI pipeline customizations continue to be correctly applied after\r\nthe changed path names\r\n> * Review all of the updated files, specially the `.ts` and `.js` files\r\nlisted in the sections below, as some of them contain relative paths\r\nthat have been updated.\r\n> * Think of potential impact of the move, including tooling and\r\nconfiguration files that can be pointing to the relocated modules. E.g.:\r\n> * customised eslint rules\r\n> * docs pointing to source code\r\n\r\n> [!NOTE]\r\n> * This PR has been auto-generated.\r\n> * Any manual contributions will be lost if the 'relocate' script is\r\nre-run.\r\n> * Try to obtain the missing reviews / approvals before applying manual\r\nfixes, and/or keep your changes in a .patch / git stash.\r\n> * Please use\r\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\r\nSlack channel for feedback.\r\n\r\n#### 2 plugin(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/threat-intelligence-plugin` |\r\n`x-pack/solutions/security/plugins/threat_intelligence` |\r\n| `@kbn/timelines-plugin` |\r\n`x-pack/solutions/security/plugins/timelines` |\r\n\r\n#### 2 packages(s) are going to be relocated:\r\n\r\n| Id | Target folder |\r\n| -- | ------------- |\r\n| `@kbn/expandable-flyout` |\r\n`x-pack/solutions/security/packages/kbn-expandable-flyout` |\r\n| `@kbn/securitysolution-data-table` |\r\n`x-pack/solutions/security/packages/data_table` |\r\n\r\nCo-authored-by: PhilippeOberti <philippe.oberti@elastic.co>\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"33c18c72fa019430c6b73503dc3176e0136e3861"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>
rudolf
added
the
plugin groups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.
Important
packages[\/\\]andplugins[\/\\]patterns in the source code (Babel and Eslint config files), and update them appropriately..buildkite/scripts/pipelines/pull_request/pipeline.tsto ensure that any CI pipeline customizations continue to be correctly applied after the changed path names.tsand.jsfiles listed in the sections below, as some of them contain relative paths that have been updated.Note
2 plugin(s) are going to be relocated:
@kbn/threat-intelligence-pluginx-pack/solutions/security/plugins/threat_intelligence@kbn/timelines-pluginx-pack/solutions/security/plugins/timelines2 packages(s) are going to be relocated:
@kbn/expandable-flyoutx-pack/solutions/security/packages/kbn-expandable-flyout@kbn/securitysolution-data-tablex-pack/solutions/security/packages/data_tableUpdated references
Updated relative paths