Skip to content

[FAILED - DISREGARD] Sustainable Kibana Architecture: Move modules owned by @elastic/security-threat-hunting#202859

Closed
gsoldevila wants to merge 0 commit intoelastic:mainfrom
gsoldevila:kbn-team-1309-move-kibana-security-threat-hunting
Closed

[FAILED - DISREGARD] Sustainable Kibana Architecture: Move modules owned by @elastic/security-threat-hunting#202859
gsoldevila wants to merge 0 commit intoelastic:mainfrom
gsoldevila:kbn-team-1309-move-kibana-security-threat-hunting

Conversation

@gsoldevila
Copy link
Copy Markdown
Contributor

@gsoldevila gsoldevila commented Dec 4, 2024

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

  • We kindly ask you to:
    • Manually fix the errors in the error section below (if there are any).
    • Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
    • Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
    • Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
    • Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
      • customised eslint rules
      • docs pointing to source code

Note

This PR has been auto-generated.
Do not attempt to push any changes unless you know what you are doing.
Please use #sustainable_kibana_architecture Slack channel for feedback.

2 package(s) are going to be relocated:

Id Target folder
@kbn/data-stream-adapter x-pack/solutions/security/packages/kbn-data-stream-adapter
@kbn/index-adapter x-pack/solutions/security/packages/kbn-index-adapter
Updated references
./.eslintrc.js
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./tsconfig.base.json
./tsconfig.base.type_check.json
./tsconfig.refs.json
./x-pack/plugins/ecs_data_quality_dashboard/tsconfig.type_check.json
./x-pack/plugins/elastic_assistant/tsconfig.type_check.json
./x-pack/solutions/security/packages/kbn-data-stream-adapter/jest.config.js
./x-pack/solutions/security/packages/kbn-index-adapter/jest.config.js
./yarn.lock
Updated relative paths
x-pack/solutions/security/packages/kbn-data-stream-adapter/jest.config.js:12
x-pack/solutions/security/packages/kbn-data-stream-adapter/tsconfig.json:2
x-pack/solutions/security/packages/kbn-data-stream-adapter/tsconfig.type_check.json:2
x-pack/solutions/security/packages/kbn-data-stream-adapter/tsconfig.type_check.json:25
x-pack/solutions/security/packages/kbn-index-adapter/jest.config.js:12
x-pack/solutions/security/packages/kbn-index-adapter/tsconfig.json:2
Script errors

@gsoldevila gsoldevila added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Threat Hunting Security Solution Threat Hunting Team labels Dec 4, 2024
@gsoldevila gsoldevila marked this pull request as ready for review December 4, 2024 08:21
@gsoldevila gsoldevila requested review from a team as code owners December 4, 2024 08:21
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

.eslintrc.js Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a nested x-pack?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error in my relocation script, will re-run to auto fix. Sorry about that

@michaelolo24
Copy link
Copy Markdown
Contributor

@gsoldevila - Although security created this adapter, the hope was that this would become a shared platform level utility. What is the process for starting those discussions and moving this into the platform?

Thanks!

@gsoldevila gsoldevila closed this Dec 5, 2024
@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-kibana-security-threat-hunting branch from caef4e6 to 1ab7d42 Compare December 5, 2024 04:51
@gsoldevila
Copy link
Copy Markdown
Contributor Author

@gsoldevila - Although security created this adapter, the hope was that this would become a shared platform level utility. What is the process for starting those discussions and moving this into the platform?

Thanks!

Please refer to #sustaninable-kibana-architecture Slack channel, thanks!

@gsoldevila gsoldevila changed the title Sustainable Kibana Architecture: Move modules owned by @elastic/security-threat-hunting [FAILED - DISREGARD] Sustainable Kibana Architecture: Move modules owned by @elastic/security-threat-hunting Dec 5, 2024
@gsoldevila gsoldevila deleted the kbn-team-1309-move-kibana-security-threat-hunting branch December 5, 2024 05:10
@gsoldevila
Copy link
Copy Markdown
Contributor Author

@michaelolo24 this PR has been replaced by #203046, sorry for the inconvenience.
Could you please review again? TIA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Team:Threat Hunting Security Solution Threat Hunting Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants