[Synthetics] migrate first set of tests by dominiqueclarke · Pull Request #198950 · elastic/kibana

dominiqueclarke · 2024-11-05T13:49:47Z

Summary

Relates to #196229

Migrates Synthetics tests to deployment agnostic

dominiqueclarke · 2024-11-08T21:21:17Z

/ci

…ynthetics-deployment-agnostic

dominiqueclarke · 2024-11-14T14:39:50Z

...ck/plugins/observability_solution/synthetics/server/synthetics_service/synthetics_service.ts

    const { apiKey, isValid } = await getAPIKeyForSyntheticsService({ server: this.server });
-    if (!isValid) {
+    // do not check for api key validity if inspecting
+    if (!isValid && !inspect) {


I noticed when I was adjusting the inspect tests, that they would sometime fail on api key not valid. No need to check api key when doing an inspect.

x-pack/test/api_integration/apis/synthetics/add_monitor_private_location.ts

…e_location.ts

dominiqueclarke · 2024-11-14T14:41:29Z

x-pack/test/api_integration/deployment_agnostic/apis/observability/synthetics/create_monitor.ts

+import { getFixtureJson } from './helpers/get_fixture_json';
+import { SyntheticsMonitorTestService } from '../../../services/synthetics_monitor';
+
+// adjust the type of samlAuth


I realized I left this as a comment for myself because samlAuth is set to any here. Didn't get to fixing it.

I like to preface comments like this with TODO to signify that the PR has new tech debt to resolve before merging.

It's a nice reminder to the author themselves and it gives a much stronger indicator to reviewers that something is unfinished.

dominiqueclarke · 2024-11-25T15:43:07Z

/ci

…iniqueclarke/kibana into chore/synthetics-deployment-agnostic

dominiqueclarke · 2024-11-25T20:02:36Z

/ci

dominiqueclarke · 2024-11-25T22:55:15Z

/ci

...st/api_integration/deployment_agnostic/apis/observability/synthetics/create_update_params.ts

…lity/synthetics/create_update_params.ts

dominiqueclarke · 2024-11-26T02:46:57Z

/ci

…-fix'

dominiqueclarke · 2024-11-26T13:08:55Z

/ci

…iniqueclarke/kibana into chore/synthetics-deployment-agnostic

dominiqueclarke · 2024-11-27T15:59:56Z

/ci

elasticmachine · 2024-12-11T15:24:14Z

💚 Build Succeeded

Buildkite Build
Commit: 7bce1ca
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-198950-7bce1ca2d862

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`@kbn/test-suites-xpack`	727	729	+2

Total ESLint disabled count

id	before	after	diff
`@kbn/test-suites-xpack`	752	754	+2

History

💔 Build #258980 failed 7cd6037
💔 Build #258903 failed d79879a
💔 Build #258552 failed 2dc3537
💔 Build #258012 failed 9f8ab54
💚 Build #256425 succeeded 80e24dc

wayneseymour

Left a question.

wayneseymour · 2024-12-11T16:57:50Z

x-pack/test/api_integration/deployment_agnostic/services/synthetics_monitor.ts

+    this.supertest = getService('supertestWithoutAuth');
+    this.samlAuth = getService('samlAuth');
+    this.getService = getService;
+    this.supertestWithoutAuth = getService('supertestWithoutAuth');


Looks like it's still imported twice?

wayneseymour

CR only, LGTM

kibanamachine · 2024-12-12T14:41:23Z

Starting backport for target branches: 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12298691592

kibanamachine · 2024-12-12T14:51:08Z

💔 All backports failed

Status	Branch	Result
❌	8.17	Backport failed because of merge conflicts You might need to backport the following PRs to 8.17: - [UA] Remove 7->8 multitype check (#203995) - [UA] `kibana-core` ownership (#203410)
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 198950

Questions ?

Please refer to the Backport tool documentation

dominiqueclarke · 2024-12-12T16:50:41Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x
✅	8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

## Summary Relates to elastic#196229 Migrates Synthetics tests to deployment agnostic --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Shahzad <shahzad31comp@gmail.com> (cherry picked from commit b74b935) # Conflicts: # .github/CODEOWNERS # x-pack/test/api_integration/deployment_agnostic/default_configs/serverless.config.base.ts

# Backport This will backport the following commits from `main` to `8.x`: - [[Synthetics] migrate first set of tests (#198950)](#198950)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)

kibanamachine · 2024-12-16T17:48:55Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2024-12-17T17:49:16Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2024-12-18T18:48:47Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

dominiqueclarke added 4 commits November 5, 2024 08:49

migrate first set of tests

ca12729

add additional deployment agnostic tests

5719991

add additional tests

54cfd8b

add additional tests

378e585

dominiqueclarke added 3 commits November 10, 2024 22:05

merge main

5dd98c4

Merge branch 'main' of https://github.com/elastic/kibana into chore/s…

67ad892

…ynthetics-deployment-agnostic

adjust tests

7561381

dominiqueclarke commented Nov 14, 2024

View reviewed changes

x-pack/test/api_integration/apis/synthetics/add_monitor_private_location.ts Outdated Show resolved Hide resolved

dominiqueclarke commented Nov 14, 2024

View reviewed changes

x-pack/test/api_integration/apis/synthetics/add_monitor_private_location.ts Outdated Show resolved Hide resolved

dominiqueclarke added 2 commits November 14, 2024 09:40

Update x-pack/test/api_integration/apis/synthetics/add_monitor_privat…

2753191

…e_location.ts

Update x-pack/test/api_integration/apis/synthetics/add_monitor_privat…

cd199d2

…e_location.ts

dominiqueclarke commented Nov 14, 2024

View reviewed changes

dominiqueclarke added 3 commits November 25, 2024 14:29

adjust types

835999c

Merge branch 'chore/synthetics-deployment-agnostic' of github.com:dom…

9f6932e

…iniqueclarke/kibana into chore/synthetics-deployment-agnostic

merge main

c79ce67

adjust types

54674a8

dominiqueclarke commented Nov 26, 2024

View reviewed changes

...st/api_integration/deployment_agnostic/apis/observability/synthetics/create_update_params.ts Outdated Show resolved Hide resolved

Update x-pack/test/api_integration/deployment_agnostic/apis/observabi…

9a35f07

…lity/synthetics/create_update_params.ts

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

4c4a86c

…-fix'

dominiqueclarke added 2 commits November 27, 2024 10:53

update test

a3f500b

Merge branch 'chore/synthetics-deployment-agnostic' of github.com:dom…

f139c1d

…iniqueclarke/kibana into chore/synthetics-deployment-agnostic

adjust enablement tests

75dfa79

dominiqueclarke added 3 commits December 10, 2024 11:39

adjust tests for MKI

d79879a

Merge branch 'main' into chore/synthetics-deployment-agnostic

7cd6037

Merge branch 'main' into chore/synthetics-deployment-agnostic

7bce1ca

wayneseymour suggested changes Dec 11, 2024

View reviewed changes

wayneseymour approved these changes Dec 12, 2024

View reviewed changes

dominiqueclarke merged commit b74b935 into elastic:main Dec 12, 2024

dominiqueclarke deleted the chore/synthetics-deployment-agnostic branch December 12, 2024 14:41

This was referenced Dec 12, 2024

[8.x] [Synthetics] migrate first set of tests (#198950) #204083

Merged

[8.17] [Synthetics] migrate first set of tests (#198950) #204086

Closed

wayneseymour mentioned this pull request Dec 13, 2024

[FLAKY ON MKI] x-pack/test/api_integration/deployment_agnostic/apis/observability/synthetics/create_monitor_private_location.ts #204204

Open

This was referenced Dec 13, 2024

Sustainable Kibana Architecture: Move modules owned by @elastic/security-defend-workflows #202840

Merged

Sustainable Kibana Architecture: Move modules owned by @elastic/obs-knowledge-team #202766

Merged

kibanamachine added v8.18.0 backport missing Added to PRs automatically when the are determined to be missing a backport. labels Dec 13, 2024

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 19, 2024

kibanamachine mentioned this pull request Feb 17, 2025

[Obs AI Assistant] Add KB re-indexing when encountering semantic_text bug #210386

Merged

dominiqueclarke mentioned this pull request Mar 3, 2025

Migrate Synthetics Synthetics CRUD API integration tests to deployment agnostic solution #196229

Closed

Conversation

dominiqueclarke commented Nov 5, 2024 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

dominiqueclarke commented Nov 8, 2024

Uh oh!

dominiqueclarke Nov 14, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dominiqueclarke Nov 14, 2024

Choose a reason for hiding this comment

Uh oh!

justinkambic Nov 14, 2024

Choose a reason for hiding this comment

Uh oh!

dominiqueclarke commented Nov 25, 2024

Uh oh!

dominiqueclarke commented Nov 25, 2024

Uh oh!

dominiqueclarke commented Nov 25, 2024

Uh oh!

Uh oh!

dominiqueclarke commented Nov 26, 2024

Uh oh!

dominiqueclarke commented Nov 26, 2024

Uh oh!

dominiqueclarke commented Nov 27, 2024

Uh oh!

elasticmachine commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Metrics [docs]

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

wayneseymour left a comment

Choose a reason for hiding this comment

Uh oh!

wayneseymour Dec 11, 2024

Choose a reason for hiding this comment

Uh oh!

wayneseymour left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Dec 12, 2024

Uh oh!

kibanamachine commented Dec 12, 2024

💔 All backports failed

Manual backport

Questions ?

Uh oh!

dominiqueclarke commented Dec 12, 2024

💚 All backports created successfully

Questions ?

Uh oh!

kibanamachine commented Dec 16, 2024

Uh oh!

kibanamachine commented Dec 17, 2024

Uh oh!

kibanamachine commented Dec 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dominiqueclarke commented Nov 5, 2024 •

edited by kibanamachine

Loading

elasticmachine commented Dec 11, 2024 •

edited

Loading