[Inference Endpoints View] Adds Alibaba AI Search to Deletion, search and filtering of inference endpoints by weizijun · Pull Request #190783 · elastic/kibana

weizijun · 2024-08-20T11:16:30Z

Summary
Adds Alibaba AI Search support to the #186206 (relevance/inference_endpoints) management list view.

The Elasticsearch PR is: elastic/elasticsearch#111181

I'm not very familiar with kibana. I made this PR from #188670.

sphilipse · 2024-08-22T07:56:52Z

      return mistralAttributes(endpoint);
    case ServiceProviderKeys.googleaistudio:
      return googleAIStudioAttributes(endpoint);
+      case ServiceProviderKeys.alibabaaisearch:


nitpick: formatting is off here.

sphilipse

Thanks @weizijun! We probably want to wait with merging this until your Elasticsearch PR has been merged, but this looks good overall. A couple of questions/nitpicks but nothing serious.

weizijun · 2024-08-22T12:06:51Z

Thanks @weizijun! We probably want to wait with merging this until your Elasticsearch PR has been merged, but this looks good overall. A couple of questions/nitpicks but nothing serious.

Thanks for your review. I will resolve these conversations.

darnautov

ML changes LGTM

weizijun · 2024-08-29T02:26:50Z

hi, @sphilipse @darnautov , the elasticsearch PR has been merged. Can this PR be merged?

darnautov · 2024-08-29T11:42:04Z

hey @weizijun, yes, it can be merged now. Thanks!

weizijun · 2024-09-03T08:51:34Z

hey @weizijun, yes, it can be merged now. Thanks!

Hi, @darnautov, is the CI check OK? Can the PR be merged?

darnautov · 2024-09-03T08:55:01Z

hi @weizijun , I see you merged the latest main, it will be merged automatically on a green build

weizijun · 2024-09-10T02:46:44Z

hi @weizijun , I see you merged the latest main, it will be merged automatically on a green build

Hi @darnautov how can I run the ci build to get all checks green?

darnautov · 2024-09-10T08:33:55Z

@elasticmachine merge upstream

weizijun · 2024-09-11T02:58:17Z

/ci

weizijun · 2024-09-12T02:42:17Z

Hi @darnautov, the kibana-ci is not running, is there any problem?

darnautov · 2024-09-13T13:18:02Z

@elasticmachine merge upstream

darnautov · 2024-09-13T17:22:42Z

buildkite test this

darnautov · 2024-09-16T13:38:12Z

hey @weizijun, you have some failing tests, TS and linting issues. Please check the CI output. Could you please make sure it's fixed and the latest main is merged? After pushing the fixes you can comment buildkite test this on this PR to trigger the CI again.

darnautov · 2024-09-23T10:20:32Z

hi @weizijun , sure, could you please resolve conflicts with the latest main? I'll make sure the CI is green then

* main: (176 commits) [ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (elastic#193420) Bump maximum supported package spec version to 3.2 (elastic#193574) [ES|QL] new pattern for `SORT` autocomplete (elastic#193595) [Inventory][ECO] Entities page search bar (elastic#193546) [Synthetics] Remove extra overview route (elastic#192449) [Obs Alerts table] Fix error on clicking alert reason message (elastic#193693) [Migrations] Remove tests that are not applicable in 9.x (elastic#193699) [EDR Workflows] Set Agent Tamper Protection to false on policy unassignment (elastic#193017) [Inventory][ECO] Enable elastic entity model from inventory (elastic#193557) [EDR Workflows] The host isolation exception tab is hidden on the basic license if no artifacts (elastic#192562) [Entity Analytics] Ensuring definition transforms are managed (elastic#193408) [Automatic Import] Do not remove message field for unstructured logs (elastic#193678) [Fleet] Add missing permissions for connector package (elastic#193573) [Fleet] using @kbn/config-schema part 2 (outputs and other apis) (elastic#193326) [Migrations] Provide testing archives + tooling for migrations integration tests (elastic#193328) [ES|QL] Renames the textbased editor to esql editor (elastic#193521) [ES|QL] Update function metadata (elastic#193662) [Security Solution][Entity Analytics] Scoping the entity store to spaces (elastic#193303) [Docs] Update Sharing docs (elastic#190318) [ML] AIOps: Move Log Rate Analysis results callout to help popover. (elastic#192243) ... # Conflicts: # x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.test.tsx # x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.tsx

weizijun · 2024-09-23T15:07:00Z

hi @weizijun , sure, could you please resolve conflicts with the latest main? I'll make sure the CI is green then

I resolve the conflicts, and I see the PR: #193493. I don’t know if there is anything else that needs to be modified in the Alibaba AI Search Inference code.

darnautov · 2024-09-24T09:48:09Z

buildkite test this

darnautov · 2024-09-26T12:52:46Z

@weizijun you still have failing tests. Run locally to check.

node scripts/jest --config=x-pack/plugins/search_inference_endpoints/jest.config.js --runInBand --coverage=false --passWithNoTests

Could you please make sure all of your tests are passing?

…l_inference_endpoints/render_table_columns/render_service_provider/service_provider.test.tsx Co-authored-by: Dima Arnautov <arnautov.dima@gmail.com>

darnautov · 2024-09-30T10:47:33Z

buildkite test this

darnautov · 2024-09-30T12:05:22Z

buildkite test this

…-fix'

darnautov · 2024-10-01T09:08:33Z

buildkite test this

kibana-ci · 2024-10-01T10:38:44Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 6f6292d

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`searchInferenceEndpoints`	91	92	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`searchInferenceEndpoints`	61.6KB	67.1KB	+5.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

weizijun · 2024-10-01T14:34:26Z

hi, @darnautov, All checks have passed, can this PR be merged?

darnautov

LGTM

darnautov · 2024-10-01T14:38:37Z

hey @weizijun! yes, you can merge it now! 🎉

weizijun · 2024-10-01T14:39:58Z

hey @weizijun! yes, you can merge it now! 🎉

hi, @darnautov, I don't have merge permissions.

kibanamachine · 2024-10-01T14:40:38Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11127698139

weizijun · 2024-10-01T14:41:45Z

Thanks @darnautov !

… and filtering of inference endpoints (elastic#190783) Summary Adds Alibaba AI Search support to the elastic#186206 (relevance/inference_endpoints) management list view. The Elasticsearch PR is: elastic/elasticsearch#111181 I'm not very familiar with kibana. I made this PR from elastic#188670. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Dima Arnautov <arnautov.dima@gmail.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 12205d5)

kibanamachine · 2024-10-01T14:45:02Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…search and filtering of inference endpoints (#190783) (#194597) # Backport This will backport the following commits from `main` to `8.x`: - [[Inference Endpoints View] Adds Alibaba AI Search to Deletion, search and filtering of inference endpoints (#190783)](#190783)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: weizijun <weizijun1989@gmail.com>

add alibaba ai search inference

01e7d8b

weizijun requested review from a team as code owners August 20, 2024 11:16

kibanamachine added the 💝community label Aug 20, 2024

weizijun added 2 commits August 20, 2024 19:16

Merge branch 'main' into add-alibaba-inference

b089d40

Merge branch 'main' into add-alibaba-inference

29d2972

sphilipse reviewed Aug 22, 2024

View reviewed changes

Merge branch 'main' into add-alibaba-inference

57674e5

improve

0413c69

darnautov approved these changes Aug 22, 2024

View reviewed changes

darnautov added the release_note:enhancement label Aug 22, 2024

Merge branch 'main' into add-alibaba-inference

a235909

sphilipse approved these changes Aug 29, 2024

View reviewed changes

Merge branch 'main' into add-alibaba-inference

90cd194

darnautov enabled auto-merge (squash) September 3, 2024 08:53

Merge branch 'main' into add-alibaba-inference

83bb24b

Merge branch 'main' into add-alibaba-inference

b231b1d

darnautov added v9.0.0 v8.16.0 backport:version Backport to applied version labels labels Sep 24, 2024

darnautov reviewed Sep 26, 2024

View reviewed changes

Comment thread ...l_inference_endpoints/render_table_columns/render_service_provider/service_provider.test.tsx Outdated

darnautov self-requested a review September 26, 2024 13:04

weizijun and others added 2 commits September 30, 2024 14:26

Update x-pack/plugins/search_inference_endpoints/public/components/al…

296dcc2

…l_inference_endpoints/render_table_columns/render_service_provider/service_provider.test.tsx Co-authored-by: Dima Arnautov <arnautov.dima@gmail.com>

Merge branch 'main' into add-alibaba-inference

609fbde

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

6f6292d

…-fix'

darnautov approved these changes Oct 1, 2024

View reviewed changes

darnautov merged commit 12205d5 into elastic:main Oct 1, 2024

kibanamachine mentioned this pull request Oct 1, 2024

[8.x] [Inference Endpoints View] Adds Alibaba AI Search to Deletion, search and filtering of inference endpoints (#190783) #194597

Merged

mdefazio mentioned this pull request Oct 2, 2024

Update Alibaba Cloud logo for Inference Endpoints #194725

Closed

Conversation

weizijun commented Aug 20, 2024 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sphilipse Aug 22, 2024

Choose a reason for hiding this comment

Uh oh!

weizijun Aug 22, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sphilipse left a comment

Choose a reason for hiding this comment

Uh oh!

weizijun commented Aug 22, 2024

Uh oh!

darnautov left a comment

Choose a reason for hiding this comment

Uh oh!

weizijun commented Aug 29, 2024

Uh oh!

darnautov commented Aug 29, 2024

Uh oh!

weizijun commented Sep 3, 2024

Uh oh!

darnautov commented Sep 3, 2024

Uh oh!

weizijun commented Sep 10, 2024

Uh oh!

darnautov commented Sep 10, 2024

Uh oh!

weizijun commented Sep 11, 2024

Uh oh!

weizijun commented Sep 12, 2024

Uh oh!

darnautov commented Sep 13, 2024

Uh oh!

darnautov commented Sep 13, 2024

Uh oh!

darnautov commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

darnautov commented Sep 23, 2024

Uh oh!

weizijun commented Sep 23, 2024

Uh oh!

darnautov commented Sep 24, 2024

Uh oh!

darnautov commented Sep 26, 2024

Uh oh!

Uh oh!

darnautov commented Sep 30, 2024

Uh oh!

darnautov commented Sep 30, 2024

Uh oh!

darnautov commented Oct 1, 2024

Uh oh!

kibana-ci commented Oct 1, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

weizijun commented Oct 1, 2024

Uh oh!

darnautov left a comment

Choose a reason for hiding this comment

Uh oh!

darnautov commented Oct 1, 2024

Uh oh!

weizijun commented Oct 1, 2024

Uh oh!

kibanamachine commented Oct 1, 2024

Uh oh!

weizijun commented Oct 1, 2024

Uh oh!

kibanamachine commented Oct 1, 2024

weizijun commented Aug 20, 2024 •

edited by kibanamachine

Loading

darnautov commented Sep 16, 2024 •

edited

Loading