[Inference Endpoints View] Deletion, search and filtering of inference endpoints by saikatsarkar056 · Pull Request #186206 · elastic/kibana

saikatsarkar056 · 2024-06-13T17:55:12Z

This PR consists of the following changes:

An option to delete an existing inference endpoint
Filtering the endpoints based on 'provider' and 'type'
Search option
Display the trained models deployment status
Display additional 3rd party providers (Mistral, Azure OpenAI, Azure AI Studio)
Add licensing for gating enterprise licensed users

Stack Management

Serverless

leemthompo

Copyedit :)

…l_inference_endpoints/render_table_columns/render_actions/actions/delete/confirm_delete_endpoint/translations.ts Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>

elasticmachine · 2024-07-09T14:27:48Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: bb846ff

Failed CI Steps

Jest Tests #3

Test Failures

[job] [logs] Jest Tests #3 / Fleet integration policy endpoint security event filters card should show the card when no permissions but results

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`searchInferenceEndpoints`	89	115	+26

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`enterpriseSearch`	2.5MB	2.5MB	+213.0B
`searchInferenceEndpoints`	45.7KB	84.7KB	+38.9KB
total			+39.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`enterpriseSearch`	51.7KB	51.9KB	+219.0B

Unknown metric groups

miscellaneous assets size

id	before	after	diff
`searchInferenceEndpoints`	697.1KB	731.9KB	+34.8KB

History

💚 Build #220238 succeeded b235eb6220ab642a971c42dd16a1b8ab651208aa
💛 Build #220136 was flaky 6ab65052924f46a3b44782924b3d7d0b9e763eaa
💛 Build #219893 was flaky 07baeb5a3105f3a158609659831461013a36760e
💛 Build #219700 was flaky 425e6e6918100d39446f3dcf74801e525028f85c
💚 Build #219544 succeeded f26515cd92dd349c994bd7f3b961decc6b7dcd13
💚 Build #219529 succeeded 014b068c05067f2219b2114ebe04e29e48fae889

cc @saikatsarkar056

saikatsarkar056 · 2024-07-09T14:42:46Z

Merging the PR for now since we have 5 approvals. I will address additional suggestions in a subsequent PR. Thank you.

saikatsarkar056 · 2024-07-09T16:20:46Z

💚 All backports created successfully

Status	Branch	Result
✅	8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

saikatsarkar056 self-assigned this Jun 13, 2024

saikatsarkar056 requested review from a team as code owners June 13, 2024 17:55

saikatsarkar056 marked this pull request as draft June 13, 2024 17:55

saikatsarkar056 added backport:skip This PR does not require backporting v8.15.0 release_note:skip Skip the PR/issue when compiling release notes labels Jun 17, 2024

saikatsarkar056 force-pushed the deletion_and_filtering_of_inference_endpoints branch 4 times, most recently from 46fad6d to 3a77f6b Compare June 20, 2024 15:42

saikatsarkar056 marked this pull request as ready for review June 20, 2024 15:46

saikatsarkar056 requested review from a team as code owners June 20, 2024 15:46

saikatsarkar056 added the Team:EnterpriseSearch label Jun 20, 2024

saikatsarkar056 force-pushed the deletion_and_filtering_of_inference_endpoints branch 5 times, most recently from 8149f5f to 7ad573a Compare June 20, 2024 20:28

saikatsarkar056 changed the title ~~Deletion and filtering of inference endpoints~~ [Inference Endpoints View] Deletion and filtering of inference endpoints Jun 20, 2024

saikatsarkar056 force-pushed the deletion_and_filtering_of_inference_endpoints branch from 7ad573a to 4e55c43 Compare June 21, 2024 00:48

darnautov approved these changes Jun 21, 2024

View reviewed changes

saikatsarkar056 force-pushed the deletion_and_filtering_of_inference_endpoints branch 4 times, most recently from 99bd8b5 to ea9cbe3 Compare June 24, 2024 14:31

saikatsarkar056 commented Jun 24, 2024

View reviewed changes

Comment thread ...s/render_table_columns/render_actions/actions/delete/confirm_delete_endpoint/translations.ts Outdated

leemthompo reviewed Jun 24, 2024

View reviewed changes

Comment thread x-pack/plugins/search_inference_endpoints/public/hooks/translations.ts Outdated

Comment thread ...s/render_table_columns/render_actions/actions/delete/confirm_delete_endpoint/translations.ts Outdated

saikatsarkar056 force-pushed the deletion_and_filtering_of_inference_endpoints branch from ea9cbe3 to 7acdac3 Compare June 24, 2024 18:15

saikatsarkar056 and others added 23 commits July 9, 2024 06:58

Apply License fixes

72cfd05

Refactor the code

432c203

Move the checking for selectedOptionKeys

9c49796

Remove css for delete modal

db38a81

Display inference endpoints view to the new solution nav

09dac74

Explicitly handle try-catch for the createInferenceEndointMutation

152cb9c

Remove generics from the multi_select_filter

cf6ca2b

Fix model deployment status

c4aa86d

Use built-in copy

87ac33a

Refactor code

6fdf9a3

Fix the alignment

f539b4e

Show error toast

d2b85b3

Refactor code

332a28a

Add toasts for deletion of endpoints

b4209e3

Remove unused translation

4e16f92

Add tests for use_delete_endpoint

7c81f7c

Add tests for multi_select_filter

537b98e

Refactor the code

a3570b0

Add try-catch

cf4d44e

Refactor code

dce1ab4

Add tests

a4cccb2

Update x-pack/plugins/search_inference_endpoints/common/translations.ts

bb846ff

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>

TattdCodeMonkey approved these changes Jul 9, 2024

View reviewed changes

saikatsarkar056 mentioned this pull request Jul 9, 2024

[8.15] [Inference Endpoints View] Deletion, search and filtering of inference endpoints (#186206) #187887

Merged

markjhoy mentioned this pull request Jul 18, 2024

[Inference Endpoints View] Adds Amazon Bedrock to Deletion, search and filtering of inference endpoints #188670

Merged

1 task

weizijun mentioned this pull request Aug 20, 2024

[Inference Endpoints View] Adds Alibaba AI Search to Deletion, search and filtering of inference endpoints #190783

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Inference Endpoints View] Deletion, search and filtering of inference endpoints#186206

[Inference Endpoints View] Deletion, search and filtering of inference endpoints#186206
saikatsarkar056 merged 48 commits intoelastic:mainfrom
saikatsarkar056:deletion_and_filtering_of_inference_endpoints

saikatsarkar056 commented Jun 13, 2024 •

edited

Loading

Uh oh!

Uh oh!

leemthompo left a comment

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Jul 9, 2024

miscellaneous assets size

Uh oh!

saikatsarkar056 commented Jul 9, 2024

Uh oh!

saikatsarkar056 commented Jul 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

saikatsarkar056 commented Jun 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stack Management

Serverless

Uh oh!

Uh oh!

leemthompo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Jul 9, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

miscellaneous assets size

History

Uh oh!

saikatsarkar056 commented Jul 9, 2024

Uh oh!

saikatsarkar056 commented Jul 9, 2024

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

saikatsarkar056 commented Jun 13, 2024 •

edited

Loading