Skip to content

[Obs Alerts table] Fix error on clicking alert reason message#193693

Merged
benakansara merged 2 commits intoelastic:mainfrom
benakansara:fix/alert-reason-link
Sep 23, 2024
Merged

[Obs Alerts table] Fix error on clicking alert reason message#193693
benakansara merged 2 commits intoelastic:mainfrom
benakansara:fix/alert-reason-link

Conversation

@benakansara
Copy link
Copy Markdown
Contributor

@benakansara benakansara commented Sep 23, 2024 •
edited by kibanamachine
Loading

Resolves #193692

@benakansara benakansara added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.16.0 backport:version Backport to applied version labels labels Sep 23, 2024
@benakansara benakansara self-assigned this Sep 23, 2024
@benakansara benakansara requested a review from a team as a code owner September 23, 2024 10:35
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 23, 2024

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic Bot added the ci:project-deploy-observability Create an Observability project label Sep 23, 2024
@obltmachine
Copy link
Copy Markdown

obltmachine commented Sep 23, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Sep 23, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 467.3KB 467.3KB +62.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @benakansara

dominiqueclarke
dominiqueclarke approved these changes Sep 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benakansara benakansara merged commit 2304fb6 into elastic:main Sep 23, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 23, 2024
@benakansara
[Obs Alerts table] Fix error on clicking alert reason message (elasti…
8122454 
…c#193693)

Resolves elastic#193692

(cherry picked from commit 2304fb6)
@kibanamachine kibanamachine mentioned this pull request Sep 23, 2024
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 23, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 23, 2024
@kibanamachine @benakansara
[8.x] [Obs Alerts table] Fix error on clicking alert reason message (#…
a460623 
…193693) (#193718)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Obs Alerts table] Fix error on clicking alert reason message
(#193693)](#193693)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"69037875+benakansara@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-23T13:08:15Z","message":"[Obs
Alerts table] Fix error on clicking alert reason message
(#193693)\n\nResolves
https://github.com/elastic/kibana/issues/193692","sha":"2304fb67365325bfcb530d3fa2a658544d8a7016","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","backport:version"],"title":"[Obs
Alerts table] Fix error on clicking alert reason
message","number":193693,"url":"https://github.com/elastic/kibana/pull/193693","mergeCommit":{"message":"[Obs
Alerts table] Fix error on clicking alert reason message
(#193693)\n\nResolves
https://github.com/elastic/kibana/issues/193692","sha":"2304fb67365325bfcb530d3fa2a658544d8a7016"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193693","number":193693,"mergeCommit":{"message":"[Obs
Alerts table] Fix error on clicking alert reason message
(#193693)\n\nResolves
https://github.com/elastic/kibana/issues/193692","sha":"2304fb67365325bfcb530d3fa2a658544d8a7016"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <69037875+benakansara@users.noreply.github.com>
weizijun added a commit to weizijun/kibana that referenced this pull request Sep 23, 2024
@weizijun
Merge branch 'main' into add-alibaba-inference
2100828 
* main: (176 commits)
  [ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (elastic#193420)
  Bump maximum supported package spec version to 3.2 (elastic#193574)
  [ES|QL] new pattern for `SORT` autocomplete (elastic#193595)
  [Inventory][ECO] Entities page search bar (elastic#193546)
  [Synthetics] Remove extra overview route (elastic#192449)
  [Obs Alerts table] Fix error on clicking alert reason message (elastic#193693)
  [Migrations] Remove tests that are not applicable in 9.x (elastic#193699)
  [EDR Workflows] Set Agent Tamper Protection to false on policy unassignment (elastic#193017)
  [Inventory][ECO] Enable elastic entity model from inventory (elastic#193557)
  [EDR Workflows] The host isolation exception tab is hidden on the basic license if no artifacts (elastic#192562)
  [Entity Analytics] Ensuring definition transforms are managed (elastic#193408)
  [Automatic Import] Do not remove message field for unstructured logs (elastic#193678)
  [Fleet] Add missing permissions for connector package (elastic#193573)
  [Fleet] using @kbn/config-schema part 2 (outputs and other apis)  (elastic#193326)
  [Migrations] Provide testing archives + tooling for migrations integration tests (elastic#193328)
  [ES|QL] Renames the textbased editor to esql editor (elastic#193521)
  [ES|QL] Update function metadata (elastic#193662)
  [Security Solution][Entity Analytics] Scoping the entity store to spaces (elastic#193303)
  [Docs] Update Sharing docs (elastic#190318)
  [ML] AIOps: Move Log Rate Analysis results callout to help popover. (elastic#192243)
  ...

# Conflicts:
#	x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.test.tsx
#	x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

@benakansara benakansara

Labels

backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.16.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Obs Alerts table] Error on clicking alert reason message

6 participants

@benakansara @elasticmachine @obltmachine @kibana-ci @kibanamachine @dominiqueclarke