Skip to content

[Inference Endpoints View] Adds Amazon Bedrock to Deletion, search and filtering of inference endpoints#188670

Merged
markjhoy merged 19 commits intomainfrom
markjhoy/add_amazon_bedrock_inference_management_ui
Jul 26, 2024
Merged

[Inference Endpoints View] Adds Amazon Bedrock to Deletion, search and filtering of inference endpoints#188670
markjhoy merged 19 commits intomainfrom
markjhoy/add_amazon_bedrock_inference_management_ui

Conversation

@markjhoy
Copy link
Copy Markdown
Contributor

@markjhoy markjhoy commented Jul 18, 2024 •
edited by kibanamachine
Loading

Summary

Adds Amazon Bedrock support to the Inference Endpoints management UI (relevance/inference_endpoints) management list view.

Checklist

@markjhoy markjhoy marked this pull request as ready for review July 23, 2024 20:43
@markjhoy markjhoy requested review from a team as code owners July 23, 2024 20:43
@markjhoy markjhoy added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.15.0 v8.16.0 labels Jul 23, 2024
saikatsarkar056
saikatsarkar056 reviewed Jul 24, 2024
View reviewed changes
Comment thread ...ic/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.tsx Outdated
return [
region && `region: ${region}`,
provider && `provider: ${provider}`,
model && `model: ${model}`,
Copy link
Copy Markdown
Contributor

@saikatsarkar056 saikatsarkar056 Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need to add 'model' information to this array. This should be automatically handled by this code-block. Essentially, we display models using a badge for different inference endpoints.

@markjhoy markjhoy requested a review from saikatsarkar056 July 25, 2024 13:13
@saikatsarkar056
Copy link
Copy Markdown
Contributor

saikatsarkar056 commented Jul 25, 2024

@markjhoy Can you please share a screen-shot of inference endpoints view after applying this change?

The change looks good to me.

@markjhoy
Copy link
Copy Markdown
Contributor Author

markjhoy commented Jul 25, 2024

@markjhoy Can you please share a screen-shot of inference endpoints view after applying this change?

The change looks good to me.

Sure! Here you go:

image

@markjhoy
Copy link
Copy Markdown
Contributor Author

markjhoy commented Jul 26, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jul 26, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
searchInferenceEndpoints 102 103 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchInferenceEndpoints 63.1KB 67.5KB +4.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@markjhoy markjhoy merged commit 25960d2 into main Jul 26, 2024
@markjhoy markjhoy deleted the markjhoy/add_amazon_bedrock_inference_management_ui branch July 26, 2024 21:31
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 26, 2024
@markjhoy @kibanamachine @elasticmachine
[Inference Endpoints View] Adds Amazon Bedrock to Deletion, search an…
f664553 
…d filtering of inference endpoints (elastic#188670)

## Summary

Adds Amazon Bedrock support to the [Inference Endpoints management
UI](elastic#186206)
(`relevance/inference_endpoints`) management list view.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 25960d2)
@kibanamachine kibanamachine mentioned this pull request Jul 26, 2024
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 26, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 26, 2024
@kibanamachine @markjhoy
[8.15] [Inference Endpoints View] Adds Amazon Bedrock to Deletion, se…
d6206c5 
…arch and filtering of inference endpoints (#188670) (#189325)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Inference Endpoints View] Adds Amazon Bedrock to Deletion, search
and filtering of inference endpoints
(#188670)](#188670)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Mark J.
Hoy","email":"mark.hoy@elastic.co"},"sourceCommit":{"committedDate":"2024-07-26T21:31:34Z","message":"[Inference
Endpoints View] Adds Amazon Bedrock to Deletion, search and filtering of
inference endpoints (#188670)\n\n## Summary\r\n\r\nAdds Amazon Bedrock
support to the [Inference Endpoints
management\r\nUI](https://github.com/elastic/kibana/pull/186206)\r\n(`relevance/inference_endpoints`)
management list view.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"25960d251eba27fb9d4c728d79a9bde15bfdb461","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.15.0","v8.16.0"],"title":"[Inference
Endpoints View] Adds Amazon Bedrock to Deletion, search and filtering of
inference
endpoints","number":188670,"url":"https://github.com/elastic/kibana/pull/188670","mergeCommit":{"message":"[Inference
Endpoints View] Adds Amazon Bedrock to Deletion, search and filtering of
inference endpoints (#188670)\n\n## Summary\r\n\r\nAdds Amazon Bedrock
support to the [Inference Endpoints
management\r\nUI](https://github.com/elastic/kibana/pull/186206)\r\n(`relevance/inference_endpoints`)
management list view.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"25960d251eba27fb9d4c728d79a9bde15bfdb461"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188670","number":188670,"mergeCommit":{"message":"[Inference
Endpoints View] Adds Amazon Bedrock to Deletion, search and filtering of
inference endpoints (#188670)\n\n## Summary\r\n\r\nAdds Amazon Bedrock
support to the [Inference Endpoints
management\r\nUI](https://github.com/elastic/kibana/pull/186206)\r\n(`relevance/inference_endpoints`)
management list view.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"25960d251eba27fb9d4c728d79a9bde15bfdb461"}}]}]
BACKPORT-->

Co-authored-by: Mark J. Hoy <mark.hoy@elastic.co>
@saikatsarkar056 saikatsarkar056 mentioned this pull request Aug 7, 2024
Merged
@weizijun weizijun mentioned this pull request Aug 20, 2024
Merged
darnautov added a commit that referenced this pull request Oct 1, 2024
@weizijun @elasticmachine
@darnautov @kibanamachine
[Inference Endpoints View] Adds Alibaba AI Search to Deletion, search…
12205d5 
… and filtering of inference endpoints (#190783)

Summary
Adds Alibaba AI Search support to the
#186206
(relevance/inference_endpoints) management list view.

The Elasticsearch PR is:
elastic/elasticsearch#111181

I'm not very familiar with kibana. I made this PR from
#188670.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Dima Arnautov <arnautov.dima@gmail.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 1, 2024
@weizijun @elasticmachine
@darnautov @kibanamachine
[Inference Endpoints View] Adds Alibaba AI Search to Deletion, search…
f8beee1 
… and filtering of inference endpoints (elastic#190783)

Summary
Adds Alibaba AI Search support to the
elastic#186206
(relevance/inference_endpoints) management list view.

The Elasticsearch PR is:
elastic/elasticsearch#111181

I'm not very familiar with kibana. I made this PR from
elastic#188670.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Dima Arnautov <arnautov.dima@gmail.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 12205d5)
kibanamachine added a commit that referenced this pull request Oct 1, 2024
@kibanamachine @weizijun
[8.x] [Inference Endpoints View] Adds Alibaba AI Search to Deletion, …
5f04936 
…search and filtering of inference endpoints (#190783) (#194597)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inference Endpoints View] Adds Alibaba AI Search to Deletion, search
and filtering of inference endpoints
(#190783)](#190783)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"weizijun","email":"weizijun1989@gmail.com"},"sourceCommit":{"committedDate":"2024-10-01T14:40:18Z","message":"[Inference
Endpoints View] Adds Alibaba AI Search to Deletion, search and filtering
of inference endpoints (#190783)\n\nSummary\r\nAdds Alibaba AI Search
support to
the\r\nhttps://github.com//pull/186206\r\n(relevance/inference_endpoints)
management list view.\r\n\r\nThe Elasticsearch PR
is:\r\nhttps://github.com/elastic/elasticsearch/pull/111181\r\n\r\nI'm
not very familiar with kibana. I made this PR
from\r\nhttps://github.com//pull/188670.\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\r\nCo-authored-by: Dima
Arnautov <arnautov.dima@gmail.com>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"12205d51c5a6ff02737d4312de1ec598f7732608","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","💝community","v9.0.0","v8.16.0","backport:version"],"title":"[Inference
Endpoints View] Adds Alibaba AI Search to Deletion, search and filtering
of inference
endpoints","number":190783,"url":"https://github.com/elastic/kibana/pull/190783","mergeCommit":{"message":"[Inference
Endpoints View] Adds Alibaba AI Search to Deletion, search and filtering
of inference endpoints (#190783)\n\nSummary\r\nAdds Alibaba AI Search
support to
the\r\nhttps://github.com//pull/186206\r\n(relevance/inference_endpoints)
management list view.\r\n\r\nThe Elasticsearch PR
is:\r\nhttps://github.com/elastic/elasticsearch/pull/111181\r\n\r\nI'm
not very familiar with kibana. I made this PR
from\r\nhttps://github.com//pull/188670.\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\r\nCo-authored-by: Dima
Arnautov <arnautov.dima@gmail.com>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"12205d51c5a6ff02737d4312de1ec598f7732608"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190783","number":190783,"mergeCommit":{"message":"[Inference
Endpoints View] Adds Alibaba AI Search to Deletion, search and filtering
of inference endpoints (#190783)\n\nSummary\r\nAdds Alibaba AI Search
support to
the\r\nhttps://github.com//pull/186206\r\n(relevance/inference_endpoints)
management list view.\r\n\r\nThe Elasticsearch PR
is:\r\nhttps://github.com/elastic/elasticsearch/pull/111181\r\n\r\nI'm
not very familiar with kibana. I made this PR
from\r\nhttps://github.com//pull/188670.\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\r\nCo-authored-by: Dima
Arnautov <arnautov.dima@gmail.com>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"12205d51c5a6ff02737d4312de1ec598f7732608"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: weizijun <weizijun1989@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darnautov darnautov darnautov approved these changes

@sphilipse sphilipse sphilipse approved these changes

@saikatsarkar056 saikatsarkar056 saikatsarkar056 approved these changes

@TattdCodeMonkey TattdCodeMonkey Awaiting requested review from TattdCodeMonkey

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.15.0 v8.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@markjhoy @saikatsarkar056 @kibana-ci @kibanamachine @darnautov @sphilipse @elasticmachine