Fix Typecheck & type errors

[delanni]

Summary

These are fixes for Typescript issues that crept in in the past ~1 month, while Typescript was on a summer break.

Summary of the original error

(1) The @kbn/dev-cli-runner and @kbn/dev-proc-runner packages (used to spawn child processes during development and CI) suffered from an issue where if the child process crashes, it would be treated as if it exited with a 0 exit-code (success).

(2) We started hitting memory limits with the type-checking, resulting in out-of-memory (OOM) errors. These would terminate the type-checking code, and our runner (because of (1)) would yield a 0 exit code, thus marking the type-check step green.

With (2) being present, we basically allowed code with type-errors to pass these checks, which in turn has landed in main in the past ~4 weeks.

We've addressed (1), and we're now cleaning up the currently present type errors from the past few weeks.

[vadimkibana]

Shared UX code changes LGTM.

[jbudz]

diff --git a/x-pack/plugins/osquery/cypress/tsconfig.json b/x-pack/plugins/osquery/cypress/tsconfig.json
index 7f4be5e6c8d..35da296d620 100644
--- a/x-pack/plugins/osquery/cypress/tsconfig.json
+++ b/x-pack/plugins/osquery/cypress/tsconfig.json
@@ -19,6 +19,7 @@
     "resolveJsonModule": true,
   },
   "kbn_references": [
+    { "path": "../../../test_serverless/tsconfig.json" },
     "@kbn/cypress-config",
     // cypress projects that are nested inside of other ts project use code
     // from the parent ts project in ways that can't be automatically deteceted

should fix the file overwrite errors

[kibana-ci]

💔 Build Failed

• Buildkite Build
• Commit: c4002f0
• Interpreting CI Failures
• Storybooks Preview

Failed CI Steps

• FTR Configs #26
• Serverless Security Explore Cypress Tests #2
• Checks
• Check Types
• Osquery Cypress Tests #1
• Osquery Cypress Tests #1
• Osquery Cypress Tests #2
• Osquery Cypress Tests #2
• Osquery Cypress Tests #3
• Osquery Cypress Tests #3
• Osquery Cypress Tests #4
• Osquery Cypress Tests #4
• Osquery Cypress Tests #5
• Osquery Cypress Tests #5
• Osquery Cypress Tests #6
• Osquery Cypress Tests #6
• Synthetics @elastic/synthetics Tests
• Synthetics @elastic/synthetics Tests
• Uptime @elastic/synthetics Tests
• Uptime @elastic/synthetics Tests
• Uptime @elastic/synthetics Tests
• Uptime @elastic/synthetics Tests

Test Failures

• [job] [logs] FTR Configs #26 / serverless common UI Index Management Index Templates "before all" hook for "renders the index templates tab"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
observabilityOnboarding	14	16	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
observabilityOnboarding	239.4KB	239.4KB	+10.0B
securitySolution	12.8MB	12.8MB	-427.0B
synthetics	860.8KB	860.8KB	+25.0B
total			-392.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
ml	33	32	-1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
ml	75.6KB	75.7KB	+50.0B
observabilityOnboarding	5.6KB	5.5KB	-57.0B
serverlessSearch	31.2KB	31.1KB	-90.0B
total			-97.0B

Unknown metric groups

API count

id	before	after	diff
observabilityOnboarding	14	17	+3

ESLint disabled line counts

id	before	after	diff
securitySolutionEss	5	6	+1

Total ESLint disabled count

id	before	after	diff
securitySolutionEss	5	6	+1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[delanni]

Closing in favor of all referenced issues :)