Skip to content

Pick Security from #166813#167355

Closed
Ikuni17 wants to merge 5 commits intoelastic:mainfrom
Ikuni17:fix/security-types
Closed

Pick Security from #166813#167355
Ikuni17 wants to merge 5 commits intoelastic:mainfrom
Ikuni17:fix/security-types

Conversation

@Ikuni17
Copy link
Contributor

@Ikuni17 Ikuni17 commented Sep 26, 2023

Summary

We're breaking #166813 up into smaller PRs in the interest of getting PRs through sooner for type fixes. These are the changes for Security teams.

@Ikuni17 Ikuni17 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v8.11.0 labels Sep 26, 2023
@Ikuni17 Ikuni17 requested a review from a team as a code owner September 26, 2023 21:21
@Ikuni17 Ikuni17 requested review from a team as code owners September 26, 2023 21:21
@Ikuni17 Ikuni17 self-assigned this Sep 26, 2023
@Ikuni17 Ikuni17 requested review from gergoabraham and pzl September 26, 2023 21:21
@Ikuni17 Ikuni17 enabled auto-merge (squash) September 26, 2023 21:26
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Ikuni17 !

],
"exclude": [
"target/**/*"
"target/**/*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"target/**/*",
"target/**/*"

@delanni
Copy link
Contributor

delanni commented Sep 27, 2023

after the conflict resolution, it seems the security team fixed their outstanding issues, so this PR is not needed.

I've moved the only relevant fix to another PR: #167369
(@patrykkopycinski please check)

@delanni delanni closed this Sep 27, 2023
auto-merge was automatically disabled September 27, 2023 08:12

Pull request was closed

@kibana-ci
Copy link

kibana-ci commented Sep 27, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #29 / serverless common UI Avatar menu is displayed

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @delanni @Ikuni17

delanni added a commit that referenced this pull request Sep 27, 2023
## Summary
Supposedly, this is the error that's causing these type of errors:/
```
Cannot write file '/Users/alex/Git/kibana/x-pack/test/functional/services/random.js' because it would overwrite input file.
```

Separated off from: #167355

Co-authored-by: Thomas Watson <watson@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@Ikuni17 Ikuni17 deleted the fix/security-types branch February 9, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants