remove duplicative types from search_source types

[nreese]

Found duplicated type ShardFailure in data plugin. Same type removed from src/plugins/data/public/shard_failure_modal/shard_failure_types.ts in #165512.

This PR removes some unneeded types from src/plugins/data/common/search/search_source/types.ts.

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[lukasolson]

LGTM, thanks for the cleanup!

[lukasolson]

Nit: Export type FieldSortOptions and use it here to avoid casting:

    const defaultSortOptions: FieldSortOptions = {
      unmapped_type: 'boolean',
    };

[ppisljar]

LGTM, thanks!

[nreese]

I am going to hold off merging this one until all Kibana TS problems have been sorted out.

[nreese]

@elasticmachine merge upstream

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 760c498

Failed CI Steps

• FTR Configs #20
• FTR Configs #36

Test Failures

• [job] [logs] FTR Configs #36 / core plugins rendering service exposes plugin config settings to unauthenticated users
• [job] [logs] FTR Configs #20 / EPM Endpoints When installing system integration in multiple spaces should install kibana assets

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
data	2577	2553	-24

Unknown metric groups

API count

id	before	after	diff
data	3311	3287	-24

References to deprecated APIs

id	before	after	diff
discover	19	15	-4

History

• 💚 Build #160134 succeeded b77d208
• 💔 Build #160102 failed f33d5e4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream