Skip to content

Pick ML UI from #166813#167354

Merged
delanni merged 2 commits intoelastic:mainfrom
Ikuni17:fix/ml-ui-types
Sep 27, 2023
Merged

Pick ML UI from #166813#167354
delanni merged 2 commits intoelastic:mainfrom
Ikuni17:fix/ml-ui-types

Conversation

@Ikuni17
Copy link
Contributor

@Ikuni17 Ikuni17 commented Sep 26, 2023

Summary

We're breaking #166813 up into smaller PRs in the interest of getting PRs through sooner for type fixes. These are the changes for ML UI.

@Ikuni17 Ikuni17 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v8.11.0 labels Sep 26, 2023
@Ikuni17 Ikuni17 requested a review from a team as a code owner September 26, 2023 21:10
@Ikuni17 Ikuni17 enabled auto-merge (squash) September 26, 2023 21:26
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link

kibana-ci commented Sep 27, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
ml 33 32 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 75.4KB 75.5KB +50.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @delanni @Ikuni17

@delanni
Copy link
Contributor

delanni commented Sep 27, 2023

Admin-merging this, the timing out cypress tests are probably not related to the type fixes.

@delanni delanni disabled auto-merge September 27, 2023 11:04
@delanni delanni merged commit 7d92c16 into elastic:main Sep 27, 2023
@Ikuni17 Ikuni17 deleted the fix/ml-ui-types branch February 9, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants