[Index details page] Implement index actions by yuliacech · Pull Request #164741 · elastic/kibana

yuliacech · 2023-08-24T15:38:54Z

Summary

This PR re-implements index actions in the context menu on the index details page. The actions are implemented without redux which is used in the old index details flyout (to be removed when this work is complete) and in the indices list. The PR introduces a declaration file to list all props of the component IndexActionsContextMenu written in JS. There is also a new component ManageIndexButton that implements index actions specifically to be executed on the new index details page. In the future most of the code in the component ManageIndexButton can be re-used when more refactorings will be made (switching to TS and not using redux in the indices list).

All index actions are async and I added a loading indicator to the context menu button to indicate that requests are in flight updating the index.

Screen recordings

Screen.Recording.2023-08-25.at.21.10.02.mov

Add/remove ILM policy actions with a confirmation modal

Screen.Recording.2023-08-25.at.21.10.27.mov

How to test

Add xpack.index_management.dev.enableIndexDetailsPage: true to your /config/kibana.dev.yml file
Start ES and Kibana with yarn es snapshot and yarn start
Add several indices to test with the command PUT /test_index in Dev Tools Console
Navigate to Index Management and click the name of any index
Check index actions:

Checklist

Unit or functional tests were updated or added to match the most common scenarios

… menu and a new component for manage index button

…es" button

…k to an async sendRequest method

yuliacech · 2023-08-25T18:06:58Z

...s/index_management/public/application/sections/home/index_list/details_page/details_page.tsx

+      <EuiSpacer size="l" />
+      <div>
+        <pre>{JSON.stringify(index, null, 2)}</pre>
+      </div>


dev display: to be deleted when tabs contents are implemented

elasticmachine · 2023-08-25T18:45:11Z

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

kibana-ci · 2023-08-28T09:59:01Z

💚 Build Succeeded

Buildkite Build
Commit: da01578

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`indexManagement`	498	497	-1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`indexManagement`	177	186	+9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`indexManagement`	523.6KB	526.9KB	+3.3KB

Unknown metric groups

API count

id	before	after	diff
`indexManagement`	182	191	+9

History

💚 Build #153692 succeeded 7f2caad
💔 Build #153670 failed 7dcf841
💚 Build #153597 succeeded aad3f7e
💚 Build #153549 succeeded 72dcad8
💛 Build #153305 was flaky d748ff6
💚 Build #153265 succeeded cfbdc05

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alisonelizabeth

Awesome work! Code LGTM. Verified all of the actions, with the exception of unfreeze. It looks like frozen indices were deprecated in 7.14, so we should probably open up a follow-up issue to remove this functionality from the UI.

alisonelizabeth · 2023-08-28T12:48:03Z

...s/index_management/__jest__/client_integration/index_details_page/index_details_page.test.ts

+      expect(testBed.routerMock.history.push).toHaveBeenCalledWith('/indices');
+    });
+
+    it(`unfreezes a frozen index`, async () => {


I think we can remove this functionality (separate PR is OK). AFAICT frozen indices and the unfreeze/freeze APIs were deprecated in 7.14 (docs).

Agree, I created an issue to track this work.

yuliacech · 2023-08-28T14:19:03Z

Thanks a lot for the review, @alisonelizabeth!

## Summary This PR removes the feature flag and enables the new index details page by default. The index details page was implemented in following PRs: - #163521 - #163955 - #164741 - #165027 - #165038 - #165456 In this PR we completely remove now obsolete code for the old index details flyout: react components and corresponding redux code. All related tests are updated and cleaned up. The config value for Index Management plugin `xpack.index_management.dev.enableIndexDetailsPage` is deprecated as unused and can be removed in v9.0. ### How to test 1. Start ES and Kibana with `yarn es snapshot` and `yarn start` 3. Navigate to Index Management and create an index 4. Click the index name in the table and check the tabs of the details page ### Screenshots #### Stateful Overview <img width="1387" alt="Screenshot 2023-09-27 at 14 41 57" src="https://github.com/elastic/kibana/assets/6585477/e58b15e7-d10c-4473-873c-d0f128392404"> Mappings <img width="1392" alt="Screenshot 2023-09-27 at 14 42 05" src="https://github.com/elastic/kibana/assets/6585477/441157cb-5a26-47c3-8da0-b4df51ebec5d"> Settings <img width="1385" alt="Screenshot 2023-09-27 at 14 42 13" src="https://github.com/elastic/kibana/assets/6585477/da66a2eb-1f21-44c1-9356-484c66caab88"> Statistics <img width="1380" alt="Screenshot 2023-09-27 at 14 42 22" src="https://github.com/elastic/kibana/assets/6585477/ec93d85c-e754-4c21-88ab-0124dc114fc9"> Error loading data <img width="1333" alt="Screenshot 2023-09-26 at 19 05 37" src="https://github.com/elastic/kibana/assets/6585477/fc1804b3-6aa0-4019-bae6-e7bb40113b28"> <img width="1327" alt="Screenshot 2023-09-26 at 19 06 07" src="https://github.com/elastic/kibana/assets/6585477/ca711697-cc74-4ba8-b17c-ec9b01f3026e"> <img width="1329" alt="Screenshot 2023-09-26 at 19 06 28" src="https://github.com/elastic/kibana/assets/6585477/0cb46b09-8542-452a-8845-40d060057e95"> <img width="1331" alt="Screenshot 2023-09-26 at 19 06 48" src="https://github.com/elastic/kibana/assets/6585477/87de8d3d-b6e5-4e8f-b27c-18a1c6e950d8"> Error saving index settings <img width="1332" alt="Screenshot 2023-09-26 at 19 07 31" src="https://github.com/elastic/kibana/assets/6585477/e6e4b3d0-c237-4d0a-995a-4562bc78f88e"> ### Serverless Overview <img width="1336" alt="Screenshot 2023-09-26 at 19 51 47" src="https://github.com/elastic/kibana/assets/6585477/6c76c23b-4be6-4ab3-ae1d-c7ae751e100d"> Mappings <img width="1336" alt="Screenshot 2023-09-26 at 19 23 51" src="https://github.com/elastic/kibana/assets/6585477/625fa703-506f-4389-9df0-86441a655074"> Settings <img width="1332" alt="Screenshot 2023-09-26 at 19 24 02" src="https://github.com/elastic/kibana/assets/6585477/c496ab09-f2db-4c1b-9fb6-1e9b64b1c142"> # Release note Index details can now be viewed on a new index details page in Index Management. <img width="1387" alt="Screenshot 2023-09-27 at 14 41 57" src="https://github.com/elastic/kibana/assets/6585477/b90c706d-8b15-49e4-8f6a-cb66f3ed1822"> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

yuliacech and others added 7 commits August 24, 2023 16:10

[Index details page] Implement index actions

405b59d

[Index details page] Add a declaration file for index actions context…

cfbdc05

… menu and a new component for manage index button

Merge branch 'main' into im/details_page/index_actions

d748ff6

[Index details page] Add jest tests for index actions

67a9848

Merge branch 'main' into im/details_page/index_actions

72dcad8

[Index details page] Move the loading indicator to the "back to indic…

aad3f7e

…es" button

[Index details page] Refactor the index loading from a useRequest hoo…

7dcf841

…k to an async sendRequest method

yuliacech commented Aug 25, 2023

View reviewed changes

yuliacech marked this pull request as ready for review August 25, 2023 18:44

yuliacech requested a review from a team as a code owner August 25, 2023 18:44

Merge branch 'main' into im/details_page/index_actions

e8f032d

yuliacech added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes v8.11.0 labels Aug 25, 2023

yuliacech and others added 2 commits August 25, 2023 21:05

[Index details page] Only 1 loading indicator

7f2caad

Merge branch 'main' into im/details_page/index_actions

da01578

alisonelizabeth approved these changes Aug 28, 2023

View reviewed changes

yuliacech merged commit 84b683b into elastic:main Aug 28, 2023

kibanamachine added the backport:skip This PR does not require backporting label Aug 28, 2023

yuliacech mentioned this pull request Aug 29, 2023

[Index details page] Re-implement context menu actions without redux #164546

Closed

yuliacech mentioned this pull request Sep 22, 2023

[Index Management] Implement index details page #165705

Merged

yuliacech deleted the im/details_page/index_actions branch February 15, 2024 12:05

sabarasaba mentioned this pull request Jun 4, 2024

[Console] Address ts-expect-error #184730

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Index details page] Implement index actions#164741

[Index details page] Implement index actions#164741
yuliacech merged 10 commits intoelastic:mainfrom
yuliacech:im/details_page/index_actions

yuliacech commented Aug 24, 2023 •

edited by alisonelizabeth

Loading

Uh oh!

yuliacech Aug 25, 2023

Uh oh!

elasticmachine commented Aug 25, 2023

Uh oh!

kibana-ci commented Aug 28, 2023

API count

Uh oh!

alisonelizabeth left a comment

Uh oh!

alisonelizabeth Aug 28, 2023

Uh oh!

yuliacech Aug 28, 2023

Uh oh!

yuliacech commented Aug 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

yuliacech commented Aug 24, 2023 • edited by alisonelizabeth Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screen recordings

How to test

Checklist

Uh oh!

yuliacech Aug 25, 2023

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Aug 25, 2023

Uh oh!

kibana-ci commented Aug 28, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

API count

History

Uh oh!

alisonelizabeth left a comment

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth Aug 28, 2023

Choose a reason for hiding this comment

Uh oh!

yuliacech Aug 28, 2023

Choose a reason for hiding this comment

Uh oh!

yuliacech commented Aug 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yuliacech commented Aug 24, 2023 •

edited by alisonelizabeth

Loading