[Index Management] Add "Stats" tab by alisonelizabeth · Pull Request #165027 · elastic/kibana

alisonelizabeth · 2023-08-28T17:32:50Z

This PR adds the "Stats" tab to the index details page. This tab will only be visible on stateful, as the index stats API is restricted on serverless.

Fixes #164576

Screenshots

// "Stats" tab will only display on stateful

// On serverless, "Stats" tab should not display

…t/stats_tab

elasticmachine · 2023-08-29T17:05:07Z

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

jrodewig

Docs link LGTM.

…t/stats_tab

gchaps · 2023-08-29T20:48:49Z

...s/index_management/public/application/sections/home/index_list/details_page/details_page.tsx

+
+const statsTab = {
+  id: IndexDetailsSection.Stats,
+  name: <FormattedMessage id="xpack.idxMgmt.indexDetails.statsTitle" defaultMessage="Stats" />,


Elsewhere we spell out statistics. For example, Field Statistics in Discover, and the Statistics tab in the Inspector. Should we spell it out for this tab as well?

That's a good point. I agree we should be consistent if "Statistics" is used elsewhere in Kibana.

This PR is part of a larger effort to make UX improvements to Index Management. I'm going to hold off on making this change here, as @yuliacech had planned to do an overall copy review with the docs team once the initial work is complete.

gchaps · 2023-08-29T21:01:11Z

...x_management/public/application/sections/home/index_list/details_page/details_page_stats.tsx

+            <EuiText color="subdued">
+              <FormattedMessage
+                id="xpack.idxMgmt.indexDetails.stats.errorDescription"
+                defaultMessage="There was an error loading stats for index {indexName}."


How about "We encountered an error loading the stats for index {indexName}."

cc @yuliacech this might also be applicable to the Mappings tab

yuliacech

Thanks a lot for implementing the stats tab, @alisonelizabeth! I tested locally and everything looks great 🎉
The only minor thing I noticed: the stats tab is disabled in the flyout for a closed index. The reason is that the stats request fails for a closed index. We could either disable the tab as well or display a more informative error message when we know that the request fails for this specific reason.

…t/stats_tab

alisonelizabeth · 2023-08-30T14:59:11Z

Thanks for the review @yuliacech! And great catch about the closed index behavior. I addressed that via bbdb196. I had to make some changes to how the data is fetched so that the API won't be called if the index is closed. I also decided to render a warning message, rather than just disabling the tab. Here's a screenshot (will need copy review at some point):

kibana-ci · 2023-08-30T15:57:10Z

💚 Build Succeeded

Buildkite Build
Commit: bbdb196

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`indexManagement`	498	499	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`indexManagement`	529.7KB	533.8KB	+4.1KB
`lists`	146.4KB	146.4KB	+36.0B
total			+4.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	381.1KB	381.1KB	+36.0B

History

💔 Build #154653 failed e3700dd
💚 Build #154585 succeeded 944fb87
💚 Build #154243 succeeded 93cfcd9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

yuliacech · 2023-08-31T08:41:55Z

The new warning for the closed index LGTM, thanks @alisonelizabeth!

## Summary This PR removes the feature flag and enables the new index details page by default. The index details page was implemented in following PRs: - #163521 - #163955 - #164741 - #165027 - #165038 - #165456 In this PR we completely remove now obsolete code for the old index details flyout: react components and corresponding redux code. All related tests are updated and cleaned up. The config value for Index Management plugin `xpack.index_management.dev.enableIndexDetailsPage` is deprecated as unused and can be removed in v9.0. ### How to test 1. Start ES and Kibana with `yarn es snapshot` and `yarn start` 3. Navigate to Index Management and create an index 4. Click the index name in the table and check the tabs of the details page ### Screenshots #### Stateful Overview <img width="1387" alt="Screenshot 2023-09-27 at 14 41 57" src="https://github.com/elastic/kibana/assets/6585477/e58b15e7-d10c-4473-873c-d0f128392404"> Mappings <img width="1392" alt="Screenshot 2023-09-27 at 14 42 05" src="https://github.com/elastic/kibana/assets/6585477/441157cb-5a26-47c3-8da0-b4df51ebec5d"> Settings <img width="1385" alt="Screenshot 2023-09-27 at 14 42 13" src="https://github.com/elastic/kibana/assets/6585477/da66a2eb-1f21-44c1-9356-484c66caab88"> Statistics <img width="1380" alt="Screenshot 2023-09-27 at 14 42 22" src="https://github.com/elastic/kibana/assets/6585477/ec93d85c-e754-4c21-88ab-0124dc114fc9"> Error loading data <img width="1333" alt="Screenshot 2023-09-26 at 19 05 37" src="https://github.com/elastic/kibana/assets/6585477/fc1804b3-6aa0-4019-bae6-e7bb40113b28"> <img width="1327" alt="Screenshot 2023-09-26 at 19 06 07" src="https://github.com/elastic/kibana/assets/6585477/ca711697-cc74-4ba8-b17c-ec9b01f3026e"> <img width="1329" alt="Screenshot 2023-09-26 at 19 06 28" src="https://github.com/elastic/kibana/assets/6585477/0cb46b09-8542-452a-8845-40d060057e95"> <img width="1331" alt="Screenshot 2023-09-26 at 19 06 48" src="https://github.com/elastic/kibana/assets/6585477/87de8d3d-b6e5-4e8f-b27c-18a1c6e950d8"> Error saving index settings <img width="1332" alt="Screenshot 2023-09-26 at 19 07 31" src="https://github.com/elastic/kibana/assets/6585477/e6e4b3d0-c237-4d0a-995a-4562bc78f88e"> ### Serverless Overview <img width="1336" alt="Screenshot 2023-09-26 at 19 51 47" src="https://github.com/elastic/kibana/assets/6585477/6c76c23b-4be6-4ab3-ae1d-c7ae751e100d"> Mappings <img width="1336" alt="Screenshot 2023-09-26 at 19 23 51" src="https://github.com/elastic/kibana/assets/6585477/625fa703-506f-4389-9df0-86441a655074"> Settings <img width="1332" alt="Screenshot 2023-09-26 at 19 24 02" src="https://github.com/elastic/kibana/assets/6585477/c496ab09-f2db-4c1b-9fb6-1e9b64b1c142"> # Release note Index details can now be viewed on a new index details page in Index Management. <img width="1387" alt="Screenshot 2023-09-27 at 14 41 57" src="https://github.com/elastic/kibana/assets/6585477/b90c706d-8b15-49e4-8f6a-cb66f3ed1822"> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

alisonelizabeth added 6 commits August 28, 2023 13:09

init commit: add index stats tab

5676c8f

add config check

3de63d4

add tests

93cfcd9

Merge branch 'main' of github.com:elastic/kibana into index_managemen…

c13f7a5

…t/stats_tab

code cleanup

6f28be4

clean up tests

944fb87

alisonelizabeth added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes labels Aug 29, 2023

alisonelizabeth marked this pull request as ready for review August 29, 2023 16:57

alisonelizabeth requested review from a team as code owners August 29, 2023 16:57

alisonelizabeth requested a review from yuliacech August 29, 2023 16:57

jrodewig approved these changes Aug 29, 2023

View reviewed changes

Merge branch 'main' of github.com:elastic/kibana into index_managemen…

e3700dd

…t/stats_tab

gchaps reviewed Aug 29, 2023

View reviewed changes

yuliacech approved these changes Aug 30, 2023

View reviewed changes

alisonelizabeth added 2 commits August 30, 2023 08:39

Merge branch 'main' of github.com:elastic/kibana into index_managemen…

a6bd23b

…t/stats_tab

show warning if index is closed

bbdb196

alisonelizabeth merged commit 81aceaa into elastic:main Aug 31, 2023

alisonelizabeth deleted the index_management/stats_tab branch August 31, 2023 12:23

kibanamachine added v8.11.0 backport:skip This PR does not require backporting labels Aug 31, 2023

yuliacech mentioned this pull request Sep 22, 2023

[Index Management] Implement index details page #165705

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Index Management] Add "Stats" tab#165027

[Index Management] Add "Stats" tab#165027
alisonelizabeth merged 9 commits intoelastic:mainfrom
alisonelizabeth:index_management/stats_tab

alisonelizabeth commented Aug 28, 2023 •

edited

Loading

Uh oh!

elasticmachine commented Aug 29, 2023

Uh oh!

jrodewig left a comment

Uh oh!

gchaps Aug 29, 2023 •

edited

Loading

Uh oh!

alisonelizabeth Aug 30, 2023

Uh oh!

gchaps Aug 29, 2023 •

edited

Loading

Uh oh!

alisonelizabeth Aug 30, 2023

Uh oh!

alisonelizabeth Aug 30, 2023

Uh oh!

yuliacech left a comment

Uh oh!

alisonelizabeth commented Aug 30, 2023

Uh oh!

kibana-ci commented Aug 30, 2023

Uh oh!

yuliacech commented Aug 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

alisonelizabeth commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

Uh oh!

elasticmachine commented Aug 29, 2023

Uh oh!

jrodewig left a comment

Choose a reason for hiding this comment

Uh oh!

gchaps Aug 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth Aug 30, 2023

Choose a reason for hiding this comment

Uh oh!

gchaps Aug 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth Aug 30, 2023

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth Aug 30, 2023

Choose a reason for hiding this comment

Uh oh!

yuliacech left a comment

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth commented Aug 30, 2023

Uh oh!

kibana-ci commented Aug 30, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

yuliacech commented Aug 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

alisonelizabeth commented Aug 28, 2023 •

edited

Loading

gchaps Aug 29, 2023 •

edited

Loading

gchaps Aug 29, 2023 •

edited

Loading