[Index details page] Implement mappings tab by yuliacech · Pull Request #165038 · elastic/kibana

yuliacech · 2023-08-28T20:01:51Z

Summary

This PR implements the mappings displayed in the Mappings tab of the index details page. The mappings are loaded from the existing route api/index_management/mapping/:indexName. There is a loading indicator and an error prompt for the API request. There is a link to the mappings docs on the right side of the tab. We need to add an Ent Search specific docs link to the right side of the tab which will be addressed as a separate PR (issue). Also any potential performance issues with displaying the mappings object in the code block will be addressed in a separate PR (issue).

Screenshots

Small mappings object

Large mappings object

Loading

Error loading mappings

Checklist

Unit or functional tests were updated or added to match the most common scenarios

…-ref HEAD~1..HEAD --fix'

elasticmachine · 2023-08-29T15:10:22Z

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

alisonelizabeth

Awesome work 🎉 LGTM.

alisonelizabeth · 2023-08-29T16:04:30Z

...anagement/public/application/sections/home/index_list/details_page/details_page_mappings.tsx

+            </EuiFlexItem>
+            <EuiFlexItem>
+              <EuiText>
+                <b>


I used EuiTitle for this in my stats PR. Do you think that's better for a11y purposes? 🤔

Good idea, thanks! I'll use the same

yuliacech · 2023-08-29T16:45:59Z

Thanks a lot for reviewing, @alisonelizabeth!

kibana-ci · 2023-08-29T17:46:13Z

💚 Build Succeeded

Buildkite Build
Commit: dccfc96

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`indexManagement`	497	498	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`indexManagement`	526.9KB	529.7KB	+2.8KB

History

💚 Build #154560 succeeded 0221925
💛 Build #154520 was flaky d276e91
💚 Build #154476 succeeded 6ae2d8d
💔 Build #154434 failed 544cd5f
💔 Build #154273 failed a9f2e7f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

## Summary This PR removes the feature flag and enables the new index details page by default. The index details page was implemented in following PRs: - #163521 - #163955 - #164741 - #165027 - #165038 - #165456 In this PR we completely remove now obsolete code for the old index details flyout: react components and corresponding redux code. All related tests are updated and cleaned up. The config value for Index Management plugin `xpack.index_management.dev.enableIndexDetailsPage` is deprecated as unused and can be removed in v9.0. ### How to test 1. Start ES and Kibana with `yarn es snapshot` and `yarn start` 3. Navigate to Index Management and create an index 4. Click the index name in the table and check the tabs of the details page ### Screenshots #### Stateful Overview <img width="1387" alt="Screenshot 2023-09-27 at 14 41 57" src="https://github.com/elastic/kibana/assets/6585477/e58b15e7-d10c-4473-873c-d0f128392404"> Mappings <img width="1392" alt="Screenshot 2023-09-27 at 14 42 05" src="https://github.com/elastic/kibana/assets/6585477/441157cb-5a26-47c3-8da0-b4df51ebec5d"> Settings <img width="1385" alt="Screenshot 2023-09-27 at 14 42 13" src="https://github.com/elastic/kibana/assets/6585477/da66a2eb-1f21-44c1-9356-484c66caab88"> Statistics <img width="1380" alt="Screenshot 2023-09-27 at 14 42 22" src="https://github.com/elastic/kibana/assets/6585477/ec93d85c-e754-4c21-88ab-0124dc114fc9"> Error loading data <img width="1333" alt="Screenshot 2023-09-26 at 19 05 37" src="https://github.com/elastic/kibana/assets/6585477/fc1804b3-6aa0-4019-bae6-e7bb40113b28"> <img width="1327" alt="Screenshot 2023-09-26 at 19 06 07" src="https://github.com/elastic/kibana/assets/6585477/ca711697-cc74-4ba8-b17c-ec9b01f3026e"> <img width="1329" alt="Screenshot 2023-09-26 at 19 06 28" src="https://github.com/elastic/kibana/assets/6585477/0cb46b09-8542-452a-8845-40d060057e95"> <img width="1331" alt="Screenshot 2023-09-26 at 19 06 48" src="https://github.com/elastic/kibana/assets/6585477/87de8d3d-b6e5-4e8f-b27c-18a1c6e950d8"> Error saving index settings <img width="1332" alt="Screenshot 2023-09-26 at 19 07 31" src="https://github.com/elastic/kibana/assets/6585477/e6e4b3d0-c237-4d0a-995a-4562bc78f88e"> ### Serverless Overview <img width="1336" alt="Screenshot 2023-09-26 at 19 51 47" src="https://github.com/elastic/kibana/assets/6585477/6c76c23b-4be6-4ab3-ae1d-c7ae751e100d"> Mappings <img width="1336" alt="Screenshot 2023-09-26 at 19 23 51" src="https://github.com/elastic/kibana/assets/6585477/625fa703-506f-4389-9df0-86441a655074"> Settings <img width="1332" alt="Screenshot 2023-09-26 at 19 24 02" src="https://github.com/elastic/kibana/assets/6585477/c496ab09-f2db-4c1b-9fb6-1e9b64b1c142"> # Release note Index details can now be viewed on a new index details page in Index Management. <img width="1387" alt="Screenshot 2023-09-27 at 14 41 57" src="https://github.com/elastic/kibana/assets/6585477/b90c706d-8b15-49e4-8f6a-cb66f3ed1822"> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

yuliacech and others added 6 commits August 28, 2023 21:57

[Index details page] Implement mappings tab

59d86ef

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

a9f2e7f

…-ref HEAD~1..HEAD --fix'

Merge branch 'main' into im/details_page/mappings_tab

544cd5f

[Index details page] Add jest tests

6ae2d8d

[Index details page] Fix the documentation link and added tests

c16b723

[Index details page] Fix the code block for the small mappings object

d276e91

This was referenced Aug 29, 2023

[Index Management][Serverless Search] Add a link for searchable content to the mappings tab on the details page #165107

Closed

[Index Management] Mappings tab performance for a large mappings object #165112

Closed

Merge branch 'main' into im/details_page/mappings_tab

0221925

yuliacech marked this pull request as ready for review August 29, 2023 15:09

yuliacech requested a review from a team as a code owner August 29, 2023 15:09

yuliacech added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes labels Aug 29, 2023

yuliacech added the v8.11.0 label Aug 29, 2023

alisonelizabeth approved these changes Aug 29, 2023

View reviewed changes

[Index details page] Use h2 in the docs links

dccfc96

yuliacech enabled auto-merge (squash) August 29, 2023 16:46

yuliacech merged commit 5ee3cd1 into elastic:main Aug 29, 2023

kibanamachine added the backport:skip This PR does not require backporting label Aug 29, 2023

yuliacech mentioned this pull request Sep 22, 2023

[Index Management] Implement index details page #165705

Merged

yuliacech deleted the im/details_page/mappings_tab branch February 15, 2024 12:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Index details page] Implement mappings tab#165038

[Index details page] Implement mappings tab#165038
yuliacech merged 8 commits intoelastic:mainfrom
yuliacech:im/details_page/mappings_tab

yuliacech commented Aug 28, 2023 •

edited

Loading

Uh oh!

elasticmachine commented Aug 29, 2023

Uh oh!

alisonelizabeth left a comment

Uh oh!

alisonelizabeth Aug 29, 2023

Uh oh!

yuliacech Aug 29, 2023

Uh oh!

yuliacech commented Aug 29, 2023

Uh oh!

kibana-ci commented Aug 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

yuliacech commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screenshots

Small mappings object

Large mappings object

Loading

Error loading mappings

Checklist

Uh oh!

elasticmachine commented Aug 29, 2023

Uh oh!

alisonelizabeth left a comment

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth Aug 29, 2023

Choose a reason for hiding this comment

Uh oh!

yuliacech Aug 29, 2023

Choose a reason for hiding this comment

Uh oh!

yuliacech commented Aug 29, 2023

Uh oh!

kibana-ci commented Aug 29, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yuliacech commented Aug 28, 2023 •

edited

Loading