[Console] Address ts-expect-error#184730
Merged
sabarasaba merged 2 commits intoelastic:mainfrom Jun 5, 2024
Merged
Conversation
sabarasaba
added
Feature:Console
Member
Author
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
To update your PR or re-run it, just comment with: cc @sabarasaba |
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
yuliacech
approved these changes
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the TS migration to v4.7.4 we had two lingering errors in our projects. The one in index management was addressed with #164741 and the other one for console was still pending. Given that the
window.autocomplete_traceis just a global window flag used for tracing variables during execution of functional tests, I've left it as ignored and added a comment.