Skip to content

[serverless] Create Security Serverless plugin#156104

Merged
clintandrewhall merged 18 commits intoelastic:mainfrom
clintandrewhall:serverless/security-project-plugin
May 2, 2023
Merged

[serverless] Create Security Serverless plugin#156104
clintandrewhall merged 18 commits intoelastic:mainfrom
clintandrewhall:serverless/security-project-plugin

Conversation

@clintandrewhall
Copy link
Copy Markdown
Contributor

@clintandrewhall clintandrewhall commented Apr 27, 2023

Derived from #153274
Builds upon #155582

Summary

This PR creates the Serverless Security plugin, based on the work from #153274:

  • creates the plugin,
  • adds API to hide the solution navigation from Security,
  • calls that API if the chrome style is project.

Screenshot 2023-04-27 at 12 37 46 PM

Next Steps

@clintandrewhall clintandrewhall added review loe:medium Medium Level of Effort Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// Project:Serverless Work as part of the Serverless project for its initial release v8.9.0 labels Apr 27, 2023
@clintandrewhall clintandrewhall requested review from a team and semd April 27, 2023 20:12
@clintandrewhall clintandrewhall requested review from a team as code owners April 27, 2023 20:12
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 27, 2023

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 27, 2023

Pinging @elastic/security-solution (Team: SecuritySolution)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 27, 2023

Documentation preview:

semd
semd reviewed Apr 28, 2023
View reviewed changes
semd
semd reviewed Apr 28, 2023
View reviewed changes
semd
semd approved these changes Apr 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security changes LGTM! thanks @clintandrewhall

@clintandrewhall clintandrewhall enabled auto-merge (squash) April 28, 2023 15:32
yuliacech
yuliacech approved these changes Apr 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment management changes LGTM

Dosant
Dosant approved these changes May 1, 2023
View reviewed changes
@semd
Copy link
Copy Markdown
Contributor

semd commented May 2, 2023

@elasticmachine merge upstream

@semd semd requested a review from a team as a code owner May 2, 2023 11:03
@semd semd requested review from ashokaditya and paul-tavares May 2, 2023 11:03
kevinlog
kevinlog reviewed May 2, 2023
View reviewed changes
...ck/plugins/security_solution/public/management/cypress/e2e/mocked_data/policy_response.cy.ts

describe('Endpoint Policy Response', () => {
// FLAKY: https://github.com/elastic/security-team/issues/6518
describe.skip('Endpoint Policy Response', () => {
Copy link
Copy Markdown
Contributor

@kevinlog kevinlog May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for linking the relevant ticket - apologies for the flaky test, we will get it fixed

Copy link
Copy Markdown
Contributor

@paul-tavares paul-tavares May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue linked really has no info. about the flakiness or reference a failure in CI. What is going on with these tests? are they failing CI?

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented May 2, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
serverlessSecurity - 4 +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
management 41 43 +2
securitySolution 76 82 +6
serverlessSecurity - 6 +6
total +14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
management 34.0KB 34.0KB +58.0B
securitySolution 9.1MB 9.1MB -2.8KB
total -2.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
management 9.8KB 10.0KB +154.0B
securitySolution 60.4KB 61.6KB +1.2KB
serverless 4.9KB 5.0KB +47.0B
serverlessSecurity - 1.5KB +1.5KB
total +2.9KB
Unknown metric groups

API count

id before after diff
management 41 43 +2
securitySolution 117 123 +6
serverlessSecurity - 6 +6
total +14

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
management 1 0 -1
securitySolution 399 401 +2
serverlessSecurity - 4 +4
total +7

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
management 1 0 -1
securitySolution 479 481 +2
serverlessSecurity - 4 +4
total +7

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@clintandrewhall clintandrewhall merged commit b217dbf into elastic:main May 2, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label May 2, 2023
paul-tavares
paul-tavares reviewed May 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

...ck/plugins/security_solution/public/management/cypress/e2e/mocked_data/policy_response.cy.ts

describe('Endpoint Policy Response', () => {
// FLAKY: https://github.com/elastic/security-team/issues/6518
describe.skip('Endpoint Policy Response', () => {
Copy link
Copy Markdown
Contributor

@paul-tavares paul-tavares May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue linked really has no info. about the flakiness or reference a failure in CI. What is going on with these tests? are they failing CI?

@clintandrewhall clintandrewhall deleted the serverless/security-project-plugin branch May 2, 2023 14:03
@ashokaditya ashokaditya mentioned this pull request Jul 10, 2023
Merged
ashokaditya added a commit to ashokaditya/kibana that referenced this pull request Jul 11, 2023
@ashokaditya
unskip policy response test
de84f27 
indexing host timeout has been increased in elastic/pull/159518
added in elastic/pull/154505
skipped in elastic/pull/156104
ashokaditya added a commit that referenced this pull request Jul 11, 2023
@ashokaditya
[Defend Workflows] Unskip policy response test (#161588)
5d06694 
## Summary

Unskip test that was timing out at indexing test hosts. 
The timeout has since been increased in /pull/159518

Was added in /pull/154505 and skipped in
/pull/156104
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 11, 2023
@ashokaditya
[Defend Workflows] Unskip policy response test (elastic#161588)
f1996a4 
## Summary

Unskip test that was timing out at indexing test hosts.
The timeout has since been increased in elastic/pull/159518

Was added in elastic/pull/154505 and skipped in
elastic/pull/156104

(cherry picked from commit 5d06694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paul-tavares paul-tavares paul-tavares left review comments

@jbudz jbudz jbudz approved these changes

@Dosant Dosant Dosant approved these changes

@semd semd semd approved these changes

@ashokaditya ashokaditya Awaiting requested review from ashokaditya ashokaditya was automatically assigned from elastic/security-defend-workflows

+2 more reviewers

@yuliacech yuliacech yuliacech approved these changes

@kevinlog kevinlog kevinlog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes review Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v8.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@clintandrewhall @elasticmachine @semd @kibana-ci @jbudz @yuliacech @Dosant @kevinlog @paul-tavares @kibanamachine