[Security Solution][Endpoint] Add additional tests for Policy Response by paul-tavares · Pull Request #154505 · elastic/kibana

paul-tavares · 2023-04-05T22:35:11Z

Summary

Adds Cypress tests to validate that recent Policy response errors are bubbled up and shown in Fleet Agent Details.
Updated Fleet Agent Details display of Integrations with data-test-subj's for testing

In support of the above, the following was also introduced:

New standalone EndpointPolicyResponseGenerator which also includes one specific method to retrieve a "connect kernel failure"
New data loaders for Endpoint Policy Responses
Endpoint Emulator CLI was enhanced with a new panel that allows sending policy responses to specific endpoints
Added EndpointMetadataGenerator.custom() static method
- Creates a custom EndpointMetadataGenerator subclass based on input arguments. allows for easier customization of generated endpoint hosts
- currently supports setting Host OS and Agent version
Like the above, added EndpointDocGenerator.custom() which currently allow for setting a custom endpoint generator for use internally
Added version and os to indexEndpointHosts cypress task
new cypress tasks:
- indexEndpointPolicyResponse - load a policy response
- deleteIndexedEndpointPolicyResponse - delete previously loaded policy response

…y-response-tests

…added missing policy response entries

…xtFailure

…s customization of output documents)

…tomization of output documents)

…or using new `.custom()` static methods

…y-response-tests

…electing os type

…atch

elasticmachine · 2023-04-11T20:43:25Z

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

elasticmachine · 2023-04-11T21:35:59Z

Pinging @elastic/fleet (Team:Fleet)

kpollich

Fleet change 🚀

kibana-ci · 2023-04-12T19:52:24Z

💚 Build Succeeded

Buildkite Build
Commit: 82e57b5

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	943.2KB	943.6KB	+416.0B

Unknown metric groups

ESLint disabled in files

id	before	after	diff
`securitySolution`	79	80	+1

ESLint disabled line counts

id	before	after	diff
`securitySolution`	433	436	+3

Total ESLint disabled count

id	before	after	diff
`securitySolution`	512	516	+4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

dasansol92

Looks good to go. Left a question and suggestion but nothing that should block you merging this. 🔥

dasansol92 · 2023-04-13T10:09:53Z

...ck/plugins/security_solution/public/management/cypress/e2e/mocked_data/policy_response.cy.ts

@@ -0,0 +1,94 @@
+/*


Got curious, why is this in the mocked_data folder?

there was no need to actually have a real endpoint for this test, thus I did not include it in the other endpoint suite. Also, the "real endpoint" test suite does not run in CI (yet 🤞 )

dasansol92 · 2023-04-13T10:13:20Z

x-pack/plugins/security_solution/scripts/endpoint/agent_emulator/screens/policy_responder.ts

@@ -0,0 +1,220 @@
+/*


Could you add a bit of explanation here about what this file does and how it works?

Sure. I'll add it in a subsequent PR.

Essentially, it displays a CLI screen that allows you to set a host and then send it a customized policy response action.

dasansol92 · 2023-04-13T10:13:53Z

...gins/security_solution/common/endpoint/data_generators/endpoint_policy_response_generator.ts

+  return mergeWith(destinationObj, srcObj, customizer);
+};
+
+export class EndpointPolicyResponseGenerator extends BaseDataGenerator {


indexing host timeout has been increased in elastic/pull/159518 added in elastic/pull/154505 skipped in elastic/pull/156104

## Summary Unskip test that was timing out at indexing test hosts. The timeout has since been increased in /pull/159518 Was added in /pull/154505 and skipped in /pull/156104

## Summary Unskip test that was timing out at indexing test hosts. The timeout has since been increased in elastic/pull/159518 Was added in elastic/pull/154505 and skipped in elastic/pull/156104 (cherry picked from commit 5d06694)

# Backport This will backport the following commits from `main` to `8.9`: - [[Defend Workflows] Unskip policy response test (#161588)](#161588)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Ashokaditya <1849116+ashokaditya@users.noreply.github.com>

paul-tavares added 6 commits April 4, 2023 17:24

initial cypress test file for policy response

8e08982

Merge remote-tracking branch 'upstream/main' into task/olm-6033-polic…

e178a6f

…y-response-tests

new EndpointPolicyResponseGenerator

9746670

new indexer utility for policy responses

4f0a812

Endpoint Emulator ability to send policy responses

305dc1e

additional setup for cypress test

25a2084

paul-tavares added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.8.0 labels Apr 5, 2023

paul-tavares self-assigned this Apr 5, 2023

paul-tavares added 20 commits April 6, 2023 09:15

update metadata as well after policy response is sent

f6ed879

Adjusted policy generator so that a more realistic mock is created + …

2d95914

…added missing policy response entries

Added method to Policy Response generator for creating a MacosSystemE…

54c50fd

…xtFailure

ability to send connect_kernel failures (macOS system ext. failures)

805c275

show response type on cli panel

b2f8fd4

cli: add prompt to send policy response after configure

2b0fbb8

cli: new layout tagged template literal that processes DataFormatter's

d029dca

cli: show policy responder options horizontally

c3d3ee3

Added .custom() static method to EndpointMetadataGenerator (allow…

31f1f4f

…s customization of output documents)

Updated OSFields type

83a0165

Added .custom() static method to EndpointDocGenerator (allows cus…

be5e2b6

…tomization of output documents)

cli: Updated endpoint emulator to create the custom EndpoingDocGnerat…

6619f50

…or using new `.custom()` static methods

Merge remote-tracking branch 'upstream/main' into task/olm-6033-polic…

e3a442f

…y-response-tests

remove customIndexFn prop from CyLoadEndpointDataOptions

6774e25

Added additional options to Cy indexEndpointHosts data loader for s…

19d55d8

…electing os type

Fix index fleet agents and associated generator to ensure agent ids m…

056ed95

…atch

Policy Response data delete function

6c8e914

Fix index fleet agents and associated generator to ensure agent ids m…

e5092b9

…atch

Fix index fleet agents and associated generator to ensure agent ids m…

4e6abd0

…atch

Cy test to validate policy response errors on fleet agent details

aef3a10

paul-tavares added 2 commits April 11, 2023 16:28

Cy test for policy response from Endpoint details panel

06459ae

Temporarily fix TS error in EndpointDocGenerator

7d0f16f

paul-tavares marked this pull request as ready for review April 11, 2023 20:43

paul-tavares requested review from a team as code owners April 11, 2023 20:43

paul-tavares requested review from ashokaditya and parkiino April 11, 2023 20:43

paul-tavares requested review from dasansol92 and removed request for ashokaditya April 11, 2023 20:43

Fix types + use loadEndpointHost() task method

6295bd2

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Apr 11, 2023

Merge branch 'main' into task/olm-6033-policy-response-tests

dbc2859

kpollich approved these changes Apr 12, 2023

View reviewed changes

Merge branch 'main' into task/olm-6033-policy-response-tests

82e57b5

dasansol92 approved these changes Apr 13, 2023

View reviewed changes

paul-tavares merged commit d6a8a88 into elastic:main Apr 13, 2023

kibanamachine added the backport:skip This PR does not require backporting label Apr 13, 2023

paul-tavares deleted the task/olm-6033-policy-response-tests branch April 13, 2023 13:24

ashokaditya mentioned this pull request Jul 10, 2023

[Defend Workflows] Unskip policy response test #161588

Merged

ashokaditya added a commit to ashokaditya/kibana that referenced this pull request Jul 11, 2023

unskip policy response test

de84f27

indexing host timeout has been increased in elastic/pull/159518 added in elastic/pull/154505 skipped in elastic/pull/156104

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Endpoint] Add additional tests for Policy Response#154505

[Security Solution][Endpoint] Add additional tests for Policy Response#154505
paul-tavares merged 32 commits intoelastic:mainfrom
paul-tavares:task/olm-6033-policy-response-tests

paul-tavares commented Apr 5, 2023 •

edited

Loading

Uh oh!

elasticmachine commented Apr 11, 2023

Uh oh!

elasticmachine commented Apr 11, 2023

Uh oh!

kpollich left a comment

Uh oh!

kibana-ci commented Apr 12, 2023

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

Uh oh!

dasansol92 left a comment

Uh oh!

dasansol92 Apr 13, 2023

Uh oh!

paul-tavares Apr 13, 2023

Uh oh!

dasansol92 Apr 13, 2023

Uh oh!

paul-tavares Apr 13, 2023

Uh oh!

dasansol92 Apr 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

paul-tavares commented Apr 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Apr 11, 2023

Uh oh!

elasticmachine commented Apr 11, 2023

Uh oh!

kpollich left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Apr 12, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

dasansol92 left a comment

Choose a reason for hiding this comment

Uh oh!

dasansol92 Apr 13, 2023

Choose a reason for hiding this comment

Uh oh!

paul-tavares Apr 13, 2023

Choose a reason for hiding this comment

Uh oh!

dasansol92 Apr 13, 2023

Choose a reason for hiding this comment

Uh oh!

paul-tavares Apr 13, 2023

Choose a reason for hiding this comment

Uh oh!

dasansol92 Apr 13, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

paul-tavares commented Apr 5, 2023 •

edited

Loading