[serverless] Create the Serverless Plugin#155582
Merged
clintandrewhall merged 13 commits intoelastic:mainfrom Apr 26, 2023
Merged
[serverless] Create the Serverless Plugin#155582clintandrewhall merged 13 commits intoelastic:mainfrom
clintandrewhall merged 13 commits intoelastic:mainfrom
Conversation
clintandrewhall
added
review
loe:large
Contributor
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Contributor
|
Documentation preview: |
jbudz
approved these changes
Apr 24, 2023
Contributor
jbudz
left a comment
jbudz
left a comment
There was a problem hiding this comment.
limits.yml / storybook aliases
sebelga
reviewed
Apr 24, 2023
packages/core/chrome/core-chrome-browser-internal/src/chrome_service.tsx
Outdated
Show resolved
Hide resolved
sebelga
reviewed
Apr 24, 2023
packages/core/chrome/core-chrome-browser-internal/src/chrome_service.tsx
Show resolved
Hide resolved
semd
reviewed
Apr 24, 2023
semd
approved these changes
Apr 24, 2023
Contributor
semd
left a comment
semd
left a comment
There was a problem hiding this comment.
LGTM for Security Solution requirements
This was referenced Apr 27, 2023
clintandrewhall
added a commit
that referenced
this pull request
May 1, 2023
> Derived from #153274 > Builds upon #155582 ## Summary This PR creates the Serverless Observability plugin, based on the work from #153274: - creates the plugin, - adds API to hide the solution navigation from Enterprise Search, - calls that API if the chrome style is `project`. <img width="1610" alt="Screenshot 2023-04-27 at 5 03 44 PM" src="https://user-images.githubusercontent.com/297604/234990765-d6770650-41b3-4e94-ad7f-c6a22778d39a.png"> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
clintandrewhall
added a commit
that referenced
this pull request
May 2, 2023
> Derived from #153274 > Builds upon #155582 ## Summary This PR creates the Serverless Security plugin, based on the work from #153274: - creates the plugin, - adds API to hide the solution navigation from Security, - calls that API if the chrome style is `project`. <img width="1688" alt="Screenshot 2023-04-27 at 12 37 46 PM" src="https://user-images.githubusercontent.com/297604/234979670-425bfb12-8194-4916-8f92-efff7804b577.png"> ## Next Steps - render the left nav from #153274 using an API provided by @elastic/appex-sharedux - this low-level API should be coming in the next few days. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 26, 2024
…lastic#175565) ## Summary In elastic#155582, an `enabled` option was added to the `Security` plugin. This option is not supported or documented. This PR reverts that change. (cherry picked from commit 4385dc1)
kibanamachine
added a commit
that referenced
this pull request
Jan 26, 2024
…ption (#175565) (#175692) # Backport This will backport the following commits from `main` to `8.12`: - [Reverts erroneous addition of security plugin enabled config option (#175565)](#175565) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jeramy Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2024-01-26T15:16:03Z","message":"Reverts erroneous addition of security plugin enabled config option (#175565)\n\n## Summary\r\n\r\nIn #155582, an `enabled` option was added to the `Security` plugin. This\r\noption is not supported or documented. This PR reverts that change.","sha":"4385dc157bccc42cf8a61801db582c41b6e9b297","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","backport:prev-minor","v8.13.0"],"title":"Reverts erroneous addition of security plugin enabled config option","number":175565,"url":"https://github.com/elastic/kibana/pull/175565","mergeCommit":{"message":"Reverts erroneous addition of security plugin enabled config option (#175565)\n\n## Summary\r\n\r\nIn #155582, an `enabled` option was added to the `Security` plugin. This\r\noption is not supported or documented. This PR reverts that change.","sha":"4385dc157bccc42cf8a61801db582c41b6e9b297"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175565","number":175565,"mergeCommit":{"message":"Reverts erroneous addition of security plugin enabled config option (#175565)\n\n## Summary\r\n\r\nIn #155582, an `enabled` option was added to the `Security` plugin. This\r\noption is not supported or documented. This PR reverts that change.","sha":"4385dc157bccc42cf8a61801db582c41b6e9b297"}}]}] BACKPORT--> Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…lastic#175565) ## Summary In elastic#155582, an `enabled` option was added to the `Security` plugin. This option is not supported or documented. This PR reverts that change.
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
6 similar comments
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
clintandrewhall
added
backport:skip
clintandrewhall
added a commit
that referenced
this pull request
Feb 4, 2025
As titled. The Project Switcher was created in #155582 as a means of allowing a developer to switch between project types without having to restart Kibana. Since that first PR, Kibana *must* be started with a particular project configuration in mind-- the switcher now does nothing. This PR removes it and deprecates the config keys.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 4, 2025
As titled. The Project Switcher was created in elastic#155582 as a means of allowing a developer to switch between project types without having to restart Kibana. Since that first PR, Kibana *must* be started with a particular project configuration in mind-- the switcher now does nothing. This PR removes it and deprecates the config keys. (cherry picked from commit 1f53a84)
kibanamachine
added a commit
that referenced
this pull request
Feb 4, 2025
…209446) # Backport This will backport the following commits from `main` to `9.0`: - [[chore][serverless] Remove dev-mode Project Switcher (#209144)](#209144) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Clint Andrew Hall","email":"clint.hall@elastic.co"},"sourceCommit":{"committedDate":"2025-02-04T04:55:21Z","message":"[chore][serverless] Remove dev-mode Project Switcher (#209144)\n\nAs titled. The Project Switcher was created in #155582 as a means of\nallowing a developer to switch between project types without having to\nrestart Kibana. Since that first PR, Kibana *must* be started with a\nparticular project configuration in mind-- the switcher now does\nnothing. This PR removes it and deprecates the config keys.","sha":"1f53a8484edc0b830a4fa97f0a55547914749759","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","chore","release_note:skip","v9.0.0","Team:SharedUX","backport:prev-major","Project:Serverless","v9.1.0"],"title":"[chore][serverless] Remove dev-mode Project Switcher","number":209144,"url":"https://github.com/elastic/kibana/pull/209144","mergeCommit":{"message":"[chore][serverless] Remove dev-mode Project Switcher (#209144)\n\nAs titled. The Project Switcher was created in #155582 as a means of\nallowing a developer to switch between project types without having to\nrestart Kibana. Since that first PR, Kibana *must* be started with a\nparticular project configuration in mind-- the switcher now does\nnothing. This PR removes it and deprecates the config keys.","sha":"1f53a8484edc0b830a4fa97f0a55547914749759"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209144","number":209144,"mergeCommit":{"message":"[chore][serverless] Remove dev-mode Project Switcher (#209144)\n\nAs titled. The Project Switcher was created in #155582 as a means of\nallowing a developer to switch between project types without having to\nrestart Kibana. Since that first PR, Kibana *must* be started with a\nparticular project configuration in mind-- the switcher now does\nnothing. This PR removes it and deprecates the config keys.","sha":"1f53a8484edc0b830a4fa97f0a55547914749759"}}]}] BACKPORT--> Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co>
drewdaemon
pushed a commit
to drewdaemon/kibana
that referenced
this pull request
Feb 6, 2025
As titled. The Project Switcher was created in elastic#155582 as a means of allowing a developer to switch between project types without having to restart Kibana. Since that first PR, Kibana *must* be started with a particular project configuration in mind-- the switcher now does nothing. This PR removes it and deprecates the config keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates the
serverlessplugin for Kibana Serverless projects.It uses the methodology proven out in the proof-of-concept (#153274) and prepares it for production:
chromeservices.serverlessplugin.yarnscripts to support all project types, and switching between them.Watcherrestarts.Next steps