Skip to content

[Defend Workflows] Unskip policy response test#161588

Merged
ashokaditya merged 3 commits intoelastic:mainfrom
ashokaditya:task/dw-unskip-mocked-cypress-test
Jul 11, 2023
Merged

[Defend Workflows] Unskip policy response test#161588
ashokaditya merged 3 commits intoelastic:mainfrom
ashokaditya:task/dw-unskip-mocked-cypress-test

Conversation

@ashokaditya
Copy link
Copy Markdown
Member

@ashokaditya ashokaditya commented Jul 10, 2023 •
edited by kibanamachine
Loading

Summary

Unskip test that was timing out at indexing test hosts.
The timeout has since been increased in /pull/159518

Was added in /pull/154505 and skipped in /pull/156104

@ashokaditya ashokaditya self-assigned this Jul 10, 2023
@ashokaditya ashokaditya added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution OLM Sprint labels Jul 10, 2023
@ashokaditya ashokaditya force-pushed the task/dw-unskip-mocked-cypress-test branch from cb74a6b to dbefa78 Compare July 10, 2023 18:50
@ashokaditya
unskip policy response test
de84f27 
indexing host timeout has been increased in elastic/pull/159518
added in elastic/pull/154505
skipped in elastic/pull/156104
@ashokaditya ashokaditya force-pushed the task/dw-unskip-mocked-cypress-test branch from dbefa78 to de84f27 Compare July 11, 2023 07:35
@ashokaditya ashokaditya marked this pull request as ready for review July 11, 2023 07:35
@ashokaditya ashokaditya requested a review from a team as a code owner July 11, 2023 07:35
@ashokaditya ashokaditya requested review from joeypoon and pzl July 11, 2023 07:35
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 11, 2023

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jul 11, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Tests #3 / Alert details expandable flyout right panel overview tab insights section should display threat intelligence section
  • [job] [logs] Security Solution Tests #3 / Exceptions viewer read only "before each" hook for "Cannot take actions on exception"

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 409 413 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 488 492 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

@ashokaditya ashokaditya merged commit 5d06694 into elastic:main Jul 11, 2023
@ashokaditya ashokaditya deleted the task/dw-unskip-mocked-cypress-test branch July 11, 2023 11:58
@kibanamachine kibanamachine mentioned this pull request Jul 11, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 11, 2023
@ashokaditya
[Defend Workflows] Unskip policy response test (elastic#161588)
f1996a4 
## Summary

Unskip test that was timing out at indexing test hosts.
The timeout has since been increased in elastic/pull/159518

Was added in elastic/pull/154505 and skipped in
elastic/pull/156104

(cherry picked from commit 5d06694)
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 11, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 11, 2023
@kibanamachine @ashokaditya
[8.9] [Defend Workflows] Unskip policy response test (#161588) (#161644)
c233d5f 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Defend Workflows] Unskip policy response test
(#161588)](#161588)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Ashokaditya","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-07-11T11:58:42Z","message":"[Defend
Workflows] Unskip policy response test (#161588)\n\n##
Summary\r\n\r\nUnskip test that was timing out at indexing test hosts.
\r\nThe timeout has since been increased in
/pull/159518\r\n\r\nWas added in
/pull/154505 and skipped
in\r\nelastic/kibana/pull/156104","sha":"5d066944fcef558eacc858bb807acb2fb783eaee","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend
Workflows","OLM
Sprint","v8.9.0","v8.10.0"],"number":161588,"url":"https://github.com/elastic/kibana/pull/161588","mergeCommit":{"message":"[Defend
Workflows] Unskip policy response test (#161588)\n\n##
Summary\r\n\r\nUnskip test that was timing out at indexing test hosts.
\r\nThe timeout has since been increased in
/pull/159518\r\n\r\nWas added in
/pull/154505 and skipped
in\r\nelastic/kibana/pull/156104","sha":"5d066944fcef558eacc858bb807acb2fb783eaee"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161588","number":161588,"mergeCommit":{"message":"[Defend
Workflows] Unskip policy response test (#161588)\n\n##
Summary\r\n\r\nUnskip test that was timing out at indexing test hosts.
\r\nThe timeout has since been increased in
/pull/159518\r\n\r\nWas added in
/pull/154505 and skipped
in\r\nelastic/kibana/pull/156104","sha":"5d066944fcef558eacc858bb807acb2fb783eaee"}}]}]
BACKPORT-->

Co-authored-by: Ashokaditya <1849116+ashokaditya@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomsonpl tomsonpl tomsonpl approved these changes

@gergoabraham gergoabraham gergoabraham approved these changes

@pzl pzl Awaiting requested review from pzl pzl was automatically assigned from elastic/security-defend-workflows

@joeypoon joeypoon Awaiting requested review from joeypoon joeypoon was automatically assigned from elastic/security-defend-workflows

Assignees

@ashokaditya ashokaditya

Labels

OLM Sprint release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.9.0 v8.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ashokaditya @elasticmachine @kibana-ci @kibanamachine @tomsonpl @gergoabraham