Skip to content

[chore][serverless] Remove dev-mode Project Switcher#209144

Merged
clintandrewhall merged 9 commits intoelastic:mainfrom
clintandrewhall:chore/remove-project-switcher
Feb 4, 2025
Merged

[chore][serverless] Remove dev-mode Project Switcher#209144
clintandrewhall merged 9 commits intoelastic:mainfrom
clintandrewhall:chore/remove-project-switcher

Conversation

@clintandrewhall
Copy link
Copy Markdown
Contributor

@clintandrewhall clintandrewhall commented Jan 31, 2025

As titled. The Project Switcher was created in #155582 as a means of allowing a developer to switch between project types without having to restart Kibana. Since that first PR, Kibana must be started with a particular project configuration in mind-- the switcher now does nothing. This PR removes it and deprecates the config keys.

@clintandrewhall clintandrewhall added review chore v9.0.0 Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// backport:prev-major Project:Serverless Work as part of the Serverless project for its initial release labels Jan 31, 2025
@clintandrewhall clintandrewhall requested review from a team as code owners January 31, 2025 16:23
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@clintandrewhall clintandrewhall added the release_note:skip Skip the PR/issue when compiling release notes label Jan 31, 2025
@clintandrewhall clintandrewhall enabled auto-merge (squash) January 31, 2025 16:24
Copy link
Copy Markdown
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@kc13greiner kc13greiner self-requested a review February 3, 2025 18:20
Copy link
Copy Markdown
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 3, 2025

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #6 / compileConfigStack adds dev configs to the stack
  • [job] [logs] Jest Tests #6 / compileConfigStack adds dev configs to the stack
  • [job] [logs] Jest Tests #6 / compileConfigStack defaults to "es" if --serverless and --dev are there
  • [job] [logs] Jest Tests #6 / compileConfigStack defaults to "es" if --serverless and --dev are there
  • [job] [logs] Jest Tests #6 / compileConfigStack respects persisted project-switcher decision when --serverless && --dev true
  • [job] [logs] Jest Tests #6 / compileConfigStack respects persisted project-switcher decision when --serverless && --dev true
  • [job] [logs] Jest Tests #8 / CustomFieldsForm renders text as default custom field type
  • [job] [logs] FTR Configs #53 / dashboard app - esql controls dashboard - add an value type ES|QL control should update the Lens chart accordingly

History

Copy link
Copy Markdown
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on CI green

@clintandrewhall clintandrewhall merged commit 1f53a84 into elastic:main Feb 4, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.16, 8.17, 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/13128631290

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 4, 2025
As titled. The Project Switcher was created in elastic#155582 as a means of
allowing a developer to switch between project types without having to
restart Kibana. Since that first PR, Kibana *must* be started with a
particular project configuration in mind-- the switcher now does
nothing. This PR removes it and deprecates the config keys.

(cherry picked from commit 1f53a84)
kibanamachine added a commit that referenced this pull request Feb 4, 2025
…209446)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[chore][serverless] Remove dev-mode Project Switcher
(#209144)](#209144)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Clint Andrew
Hall","email":"clint.hall@elastic.co"},"sourceCommit":{"committedDate":"2025-02-04T04:55:21Z","message":"[chore][serverless]
Remove dev-mode Project Switcher (#209144)\n\nAs titled. The Project
Switcher was created in #155582 as a means of\nallowing a developer to
switch between project types without having to\nrestart Kibana. Since
that first PR, Kibana *must* be started with a\nparticular project
configuration in mind-- the switcher now does\nnothing. This PR removes
it and deprecates the config
keys.","sha":"1f53a8484edc0b830a4fa97f0a55547914749759","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","chore","release_note:skip","v9.0.0","Team:SharedUX","backport:prev-major","Project:Serverless","v9.1.0"],"title":"[chore][serverless]
Remove dev-mode Project
Switcher","number":209144,"url":"https://github.com/elastic/kibana/pull/209144","mergeCommit":{"message":"[chore][serverless]
Remove dev-mode Project Switcher (#209144)\n\nAs titled. The Project
Switcher was created in #155582 as a means of\nallowing a developer to
switch between project types without having to\nrestart Kibana. Since
that first PR, Kibana *must* be started with a\nparticular project
configuration in mind-- the switcher now does\nnothing. This PR removes
it and deprecates the config
keys.","sha":"1f53a8484edc0b830a4fa97f0a55547914749759"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209144","number":209144,"mergeCommit":{"message":"[chore][serverless]
Remove dev-mode Project Switcher (#209144)\n\nAs titled. The Project
Switcher was created in #155582 as a means of\nallowing a developer to
switch between project types without having to\nrestart Kibana. Since
that first PR, Kibana *must* be started with a\nparticular project
configuration in mind-- the switcher now does\nnothing. This PR removes
it and deprecates the config
keys.","sha":"1f53a8484edc0b830a4fa97f0a55547914749759"}}]}] BACKPORT-->

Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co>
@clintandrewhall clintandrewhall added backport:version Backport to applied version labels and removed backport:prev-major labels Feb 4, 2025
@elastic elastic deleted a comment from kibanamachine Feb 4, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/13137309426

drewdaemon pushed a commit to drewdaemon/kibana that referenced this pull request Feb 6, 2025
As titled. The Project Switcher was created in elastic#155582 as a means of
allowing a developer to switch between project types without having to
restart Kibana. Since that first PR, Kibana *must* be started with a
particular project configuration in mind-- the switcher now does
nothing. This PR removes it and deprecates the config keys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels chore Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes review Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v9.0.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants