Skip to content

[serverless] Add ability to disable certain plugins for Serverless.#155583

Merged
clintandrewhall merged 9 commits intoelastic:mainfrom
clintandrewhall:serverless/disable-plugins
Apr 26, 2023
Merged

[serverless] Add ability to disable certain plugins for Serverless.#155583
clintandrewhall merged 9 commits intoelastic:mainfrom
clintandrewhall:serverless/disable-plugins

Conversation

@clintandrewhall
Copy link
Copy Markdown
Contributor

@clintandrewhall clintandrewhall commented Apr 24, 2023 •
edited by kibanamachine
Loading

Derived from #153274

Summary

This PR extracts configuration settings for enabling/disabling plugins in Serverless projects based on current requirements.

It seemed prudent to create an independent PR to K.I.S.S, rather than include in PRs with more ornate changes, (e.g. #155582)

@clintandrewhall clintandrewhall added review loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:Serverless Work as part of the Serverless project for its initial release v8.9.0 labels Apr 24, 2023
@clintandrewhall clintandrewhall requested review from a team as code owners April 24, 2023 03:28
@clintandrewhall clintandrewhall requested a review from a team April 24, 2023 03:28
@clintandrewhall clintandrewhall requested a review from a team as a code owner April 24, 2023 03:28
@clintandrewhall clintandrewhall requested review from a team April 24, 2023 03:28
@botelastic botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Apr 24, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 24, 2023

Pinging @elastic/apm-ui (Team:APM)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 24, 2023

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 24, 2023

Pinging @elastic/uptime (Team:uptime)

@clintandrewhall clintandrewhall mentioned this pull request Apr 24, 2023
Merged
2 tasks
sphilipse
sphilipse approved these changes Apr 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ent-search changes LGTM

yngrdyn
yngrdyn approved these changes Apr 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apm changes LGTM

semd
semd approved these changes Apr 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security changes LGTM

kpollich
kpollich approved these changes Apr 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes 👍

yuliacech
yuliacech approved these changes Apr 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment management changes LGTM

CoenWarmer
CoenWarmer approved these changes Apr 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@CoenWarmer CoenWarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AO Changes LGTM

@clintandrewhall clintandrewhall enabled auto-merge (squash) April 26, 2023 03:29
YulNaumenko
YulNaumenko approved these changes Apr 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shahzad31
shahzad31 approved these changes Apr 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM !!

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Apr 26, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 128.1KB 128.1KB +8.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@clintandrewhall clintandrewhall merged commit 6690c44 into elastic:main Apr 26, 2023
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 26, 2023

💔 All backports failed

Status Branch Result
❌ 8.9 The branch "8.9" does not exist

Manual backport

To create the backport manually run:

node scripts/backport --pr 155583

Questions ?

Please refer to the Backport tool documentation

clintandrewhall added a commit that referenced this pull request Apr 26, 2023
@clintandrewhall @kibanamachine
[serverless] Create the Serverless Plugin (#155582)
8e37b38 
> Derived from #153274 for
production.

## Summary

This PR creates the `serverless` plugin for Kibana Serverless projects.


![image](https://user-images.githubusercontent.com/297604/233892935-b3713575-a2f7-4e82-a9dd-e8c11823683f.png)


It uses the methodology proven out in the proof-of-concept
(#153274) and prepares it for
production:

- Adds chrome style and related API to the `chrome` services.
- Creates the `serverless` plugin.
- Invokes the new chrome style API for all serverless projects.
- Alters `yarn` scripts to support all project types, and switching
between them.
- Creates the new "Project Switcher" component for use in the new chrome
header for Serverless.
- Creates a Storybook config for this and future components.
- Adds API endpoint to trigger project switching and `Watcher` restarts.

<img width="1598" alt="Screenshot 2023-04-26 at 10 44 01 AM"
src="https://user-images.githubusercontent.com/297604/234612654-fdcf38ea-8c48-4066-bc85-507f40c984aa.png">


## Next steps

- [x] Creating a PR for enabling/disabling related plugins for
Serverless. (#155583)
- [ ] Creating product plugin PR based on
#153274.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@ElenaStoeva ElenaStoeva mentioned this pull request May 25, 2023
Closed
5 tasks
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 21, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 21, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 155583 locally

3 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 22, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 155583 locally

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 27, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 155583 locally

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 14, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 155583 locally

@jbudz jbudz added the backport:skip This PR does not require backporting label Sep 30, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoenWarmer CoenWarmer CoenWarmer approved these changes

@yngrdyn yngrdyn yngrdyn approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@kpollich kpollich kpollich approved these changes

@semd semd semd approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@sphilipse sphilipse sphilipse approved these changes

+1 more reviewer

@yuliacech yuliacech yuliacech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes review Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0 v8.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.