Upgrade EUI to v52.2.0 by breehall · Pull Request #128313 · elastic/kibana

breehall · 2022-03-22T20:14:55Z

Summary

eui@51.1.0 ⏩ eui@52.2.0

Snapshot churn is largely due to mocked EuiIcon content including the aria-label as text. This helps the automated a11y testing suite, but the EUI team is evaluating a different approach that would be less invasive. It's possible that these snapshot changes will be negated in the next release of EUI.

`52.2.0`

Added branchUser, desktop and sessionViewer glyphs to EuiIcon (#5740)

`52.1.0`

Added anchor prop to EuiTourStep to allow for DOM selector attachment (#5696)
EuiDataGrid now forces isExpandable to be true if any cellActions are passed, as keyboard users are otherwise unable to access cell actions without the expansion popover (#5710)

Bug fixes

Fixed EuiDataGrid not rerendering correctly on row heights change (#5712)
Fixed EuiContextMenu requiring two tab keypresses to advance to the next focusable menu item (#5719)
Fixed EuiDataGrid footer cell focus bugging out after moving its column (#5720)

`52.0.0`

Added editorChecklist glyph to EuiIcon (#5705)
Updated testenv mock for EuiIcon to render aria-label as text (#5709)
Added compressed prop to EuiFilterGroup and reduced the size of the EuiFilterButton notification badge (#5717)
Increased contrast of EuiSelectableTemplateSitewide input text when in dark header (#5724)

Breaking changes

Removed Legacy theme including compiled CSS (#5688)
Removed flush and size props in EuiFilterButtonProps (#5717)

CSS-in-JS conversions

Converted EuiMark to CSS-in-JS styling (#4575)

…nfig.js

…pshots, and updated equality conditions for specific test cases

…required tests

…ing for strict text equality to account for text coming from the EuiScreenReaderOnly component. Also updated tests to account for EuiIcon text that is now rendered when the icon is imported from .testenv (PR 5709 - elastic/eui#5709).

…into upgrade-eui-52.1.0 Pulling the latest code from the upgrade-eui-52.1.0 branch

…apshots. Updated tests using getAllByLabelText and getByLabelText to getAllByText and getByText respectively as the former have been deprecated

…pshots. Updated instances of getByLabelText and getAllByLabelText to getByText and getAllByText as the former are now deprecated.

Bamieh · 2022-03-28T15:25:37Z

...bjects_management/public/management_section/object_view/components/not_found_errors.test.tsx

    expect(callOut).toMatchSnapshot();
    expect(mounted.text()).toMatchInlineSnapshot(
-      `"There is a problem with this saved objectThe saved search associated with this object no longer exists.If you know what this error means, you can use the Saved objects APIs(opens in a new tab or window) to fix it — otherwise click the delete button above."`
+      `"There is a problem with this saved objectThe saved search associated with this object no longer exists.If you know what this error means, you can use the Saved objects APIsExternal link(opens in a new tab or window) to fix it — otherwise click the delete button above."`


Hmm I am not sure this change from APIs to APIsExternal link is intended?

Hey Bamieh, this change comes from PR 5709 (elastic/eui#5709) where all of the icons being used by .testenv now render text as a <span> to notate what the icon is. Now, where an icon would be used, we will see text for that icon inline. I'm in the process of updating the tests that were affected by this.

OK cool. Thank you 👍

… Updated required snapshots. Updated various tests to account for text rendering of the EuiIcon text.

…age.json and license_checker/config.ts

elasticmachine · 2022-03-28T23:00:09Z

Pinging @elastic/uptime (Team:uptime)

YulNaumenko

security_solution and timelines changes LGTM

alisonelizabeth

deployment management changes LGTM

kibana-ci · 2022-03-29T03:38:44Z

💛 Build succeeded, but was flaky

Test Failures

[job] [logs] Security Solution Tests / risk tab filters the table
[job] [logs] Security Solution Tests / risk tab renders the table
[job] [logs] Security Solution Tests / risk tab should be able to change items count per page
[job] [logs] Security Solution Tests / risk tab should not allow page change when page is empty
[job] [logs] Security Solution Tests / value lists user with restricted access role "before each" hook for "Does not allow a t1 analyst user to upload a value list"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.8MB	2.8MB	-1.0B
`infra`	1002.1KB	1002.1KB	-9.0B
total			-10.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-css`	595.5KB	595.5KB	-47.0B
`kbnUiSharedDeps-npmDll`	4.8MB	4.8MB	+557.0B
total			+510.0B

History

💔 Build #34276 failed 12341fb
💔 Build #34249 failed 42b32ff
💔 Build #34197 failed 0075cc3
💔 Build #34098 failed 3ef5869
💔 Build #33724 failed edc6460
💔 Build #33669 failed c7471ab

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dgieselaar

APM changes LGTM

Bamieh

LGTM

thomheymann

security changes LGTM

cqliu1

Canvas changes LGTM

flash1293

VisEditors changes LGTM, code review only

kertal

LGTM, just snapshot were changed, did also a very basic cloud test, works as expected

tylersmalley · 2022-03-29T20:39:25Z

Merging ahead of the awaiting reviews at the request of the EUI team. If you have any issues here please raise them with EUI, thanks.

tylersmalley · 2022-03-29T21:51:22Z

This resulted in some Jest failures once it hit main, so, unfortunately, it will need to be reverted. Working on that now.

edit: revert at f782f8b

This reverts commit dccd829.

awahab07

Uptime and User Experience plugin changes LGTM. Only reviewed code as just a few tests are changed.

kibanamachine · 2022-03-30T21:06:18Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128313 or prevent reminders by adding the backport:skip label.

Updgraded EUI packages in package.json and src/dev/license_checker/co…

8b2b6bf

…nfig.js

breehall added release_note:skip Skip the PR/issue when compiling release notes EUI v8.3.0 ci:deploy-cloud labels Mar 22, 2022

breehall and others added 3 commits March 23, 2022 15:48

Resolved Jest test failures for Jest test suites 1 and 2. Updated sna…

c17565c

…pshots, and updated equality conditions for specific test cases

Resolve Jest test cases for Jest test suite 3. Updated snapshots for …

e3182bb

…required tests

type fixes

adca506

thompsongl mentioned this pull request Mar 24, 2022

[EUI] [Tour] Ability to target beacon location based on ID or other selectors #124052

Closed

breehall added 2 commits March 24, 2022 11:34

Merge branch 'upgrade-eui-52.1.0' of https://github.com/elastic/kibana …

c5572b8

…into upgrade-eui-52.1.0 Pulling the latest code from the upgrade-eui-52.1.0 branch

banderror mentioned this pull request Mar 24, 2022

[Security Solution] Add the ability to filter by index pattern to the rules management table #128245

Merged

eui to 52.2.0

c7471ab

thompsongl changed the title ~~Upgrade EUI to v52.1.0~~ Upgrade EUI to v52.2.0 Mar 24, 2022

breehall added 2 commits March 24, 2022 17:56

Resolved test cases for Jest test suites 1 and 2. Updated required sn…

1e55ce3

…apshots. Updated tests using getAllByLabelText and getByLabelText to getAllByText and getByText respectively as the former have been deprecated

Updated Jest tests for Jest test suites 5 and 6. Updated required sna…

edc6460

…pshots. Updated instances of getByLabelText and getAllByLabelText to getByText and getAllByText as the former are now deprecated.

yuliacech mentioned this pull request Mar 28, 2022

Jest axe a11y testing #127185

Merged

Bamieh reviewed Mar 28, 2022

View reviewed changes

breehall and others added 9 commits March 28, 2022 11:45

Updated Jest tests for Jest test suite 7. Updated required snapshots.

3ef5869

Completed test case revisions for Jest test suites 1, 3, 6, 7, and 8.…

ed0bccb

… Updated required snapshots. Updated various tests to account for text rendering of the EuiIcon text.

Merge in the latest code from main to resolve merge conflicts in pack…

0075cc3

…age.json and license_checker/config.ts

eui back to v52.2.0

45a00f8

Merge branch 'main' into upgrade-eui-52.1.0

42b32ff

removed unused test utils

553be76

use .contains for euiicon content

0b1e22c

storyshots updates

a4afff5

Merge branch 'main' into upgrade-eui-52.1.0

12341fb

thompsongl marked this pull request as ready for review March 28, 2022 22:55

thompsongl requested review from a team as code owners March 28, 2022 22:55

YulNaumenko approved these changes Mar 28, 2022

View reviewed changes

thompsongl added 2 commits March 28, 2022 18:55

linting

2de5b25

Merge branch 'main' into upgrade-eui-52.1.0

b0d8e82

alisonelizabeth approved these changes Mar 29, 2022

View reviewed changes

kqualters-elastic mentioned this pull request Mar 29, 2022

[Security Solution] Use session view plugin to render session viewer in alerts, events and timeline #127520

Merged

4 tasks

dgieselaar approved these changes Mar 29, 2022

View reviewed changes

Bamieh approved these changes Mar 29, 2022

View reviewed changes

thomheymann approved these changes Mar 29, 2022

View reviewed changes

cqliu1 approved these changes Mar 29, 2022

View reviewed changes

flash1293 approved these changes Mar 29, 2022

View reviewed changes

kertal approved these changes Mar 29, 2022

View reviewed changes

tylersmalley merged commit dccd829 into main Mar 29, 2022

tylersmalley deleted the upgrade-eui-52.1.0 branch March 29, 2022 20:39

cee-chen added the v8.2.0 label Mar 29, 2022

tylersmalley added a commit that referenced this pull request Mar 29, 2022

Revert "Upgrade EUI to v52.2.0 (#128313)"

f782f8b

This reverts commit dccd829.

cee-chen restored the upgrade-eui-52.1.0 branch March 29, 2022 22:09

tylersmalley deleted the upgrade-eui-52.1.0 branch March 29, 2022 22:10

This was referenced Mar 29, 2022

Upgrade EUI to v52.2.0 #128841

Merged

Upgrade EUI to v53.0.1 #128825

Merged

awahab07 reviewed Mar 30, 2022

View reviewed changes

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 30, 2022

thompsongl added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 30, 2022

tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022

Conversation

breehall commented Mar 22, 2022 • edited by thompsongl Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

52.2.0

52.1.0

52.0.0

Uh oh!

Bamieh Mar 28, 2022

Choose a reason for hiding this comment

Uh oh!

breehall Mar 28, 2022

Choose a reason for hiding this comment

Uh oh!

Bamieh Mar 28, 2022

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Mar 28, 2022

Uh oh!

YulNaumenko left a comment

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Mar 29, 2022

💛 Build succeeded, but was flaky

Test Failures

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

dgieselaar left a comment

Choose a reason for hiding this comment

Uh oh!

Bamieh left a comment

Choose a reason for hiding this comment

Uh oh!

thomheymann left a comment

Choose a reason for hiding this comment

Uh oh!

cqliu1 left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

tylersmalley commented Mar 29, 2022

Uh oh!

tylersmalley commented Mar 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

awahab07 left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

breehall commented Mar 22, 2022 •

edited by thompsongl

Loading

`52.2.0`

`52.1.0`

`52.0.0`

tylersmalley commented Mar 29, 2022 •

edited

Loading