-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Upgrade EUI to v52.2.0 #128313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v52.2.0 #128313
Changes from all commits
8b2b6bf
c17565c
e3182bb
adca506
8398681
c5572b8
c7471ab
1e55ce3
edc6460
3ef5869
ed0bccb
0075cc3
45a00f8
42b32ff
553be76
0b1e22c
a4afff5
12341fb
2de5b25
b0d8e82
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I am not sure this change from
APIstoAPIsExternal linkis intended?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Bamieh, this change comes from PR 5709 (elastic/eui#5709) where all of the icons being used by
.testenvnow render text as a<span>to notate what the icon is. Now, where an icon would be used, we will see text for that icon inline. I'm in the process of updating the tests that were affected by this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK cool. Thank you 👍