Upgrade EUI to v53.0.1 by cee-chen · Pull Request #128825 · elastic/kibana

cee-chen · 2022-03-29T20:59:22Z

Summary

eui@52.2.0 ⏩ eui@53.0.1

`53.0.1`

Bug fixes

Fixed EuiContext.i18n's mappingFunc not being called for EuiI18ns with multiple tokens or function callbacks (#5748)
Fixed poor rendering performance of EuiIcon when using a custom data URI type (#5751)

`53.0.0`

Added all remaining missing i18n tokens for EuiSuperDatePicker (#5743)

Breaking changes

Removed prettyDuration utility exported by EuiSuperDatePicker - this util was converted to a PrettyDuration component and usePrettyDuration hook which should be used instead (#5743)
Removed commonDurationRanges exported by EuiSuperDatePicker. The new pretty duration utils will fall back to commonDurationRanges by default if no quickRanges are passed (#5743)

elasticmachine · 2022-03-29T20:59:26Z

Pinging @elastic/eui-design (EUI)

src/core/public/i18n/i18n_eui_mapping.test.ts

x-pack/plugins/ui_actions_enhanced/public/custom_time_range_badge.tsx

thompsongl · 2022-03-29T22:19:52Z

@constancecchen Forgot to mention this in the original PR, but the checks failures can be resolved by changing

- const MockedEuiSuperDatePicker = EuiSuperDatePicker as jest.MockedClass<typeof EuiSuperDatePicker>;
+ const MockedEuiSuperDatePicker = EuiSuperDatePicker as jest.MockedFunction<typeof EuiSuperDatePicker>;

cee-chen · 2022-03-29T22:33:55Z

Thanks Greg! Was waiting for Jests tests to finish before pushing up the fix. I'm also going to go move this back to draft since #128313 was reverted, and rebase/re-open it once #128841 is in.

i18n review will remain the same though so please feel free to take a look when you can @Bamieh.

- Fix mock typeof: this changed because the exported EuiSuperDatePicker is no longer a class, but a functional component wrapper around a class - CI test: update now-capitalized datepicker select copy - Jest tests: update snapshots, find()s (`Memo()` selector change is due to the exported EuiSuperDatePicker change)

peteharverson

ML code change LGTM

nickpeihl

maps change lgtm!

cee-chen · 2022-03-30T15:24:43Z

Thanks y'all so much for the speedy approvals! Just wanted to give the remaining CODEOWNERS (@elastic/kibana-core , @elastic/kibana-app-services @elastic/security-solution) a heads up that we are on a timeline for this PR. Since it adds i18n for EuiSuperDatePicker (used extensively throughout Kibana), we're hoping to get this PR in before Friday, which will be when i18n tokens are extracted for translation. Thanks for your time!

Bamieh

LGTM

vadimkibana

Code changes LGTM.

banderror

Security Solution LGTM 👍

cee-chen · 2022-03-31T16:16:46Z

@elasticmachine merge upstream

cee-chen · 2022-03-31T20:08:58Z

@elasticmachine merge upstream

kibana-ci · 2022-03-31T23:47:09Z

💛 Build succeeded, but was flaky

Test Failures

[job] [logs] Security Solution Tests / risk tab filters the table
[job] [logs] Security Solution Tests / risk tab renders the table
[job] [logs] Security Solution Tests / risk tab should be able to change items count per page
[job] [logs] Security Solution Tests / risk tab should not allow page change when page is empty

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.8MB	2.8MB	+1.0B
`data`	116.7KB	116.8KB	+88.0B
`enterpriseSearch`	1.4MB	1.4MB	+1.0B
`fileUpload`	821.1KB	821.1KB	+1.0B
`maps`	2.5MB	2.5MB	+1.0B
`ml`	3.3MB	3.3MB	+1.0B
total			+93.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	297.9KB	309.1KB	+11.2KB
`kbnUiSharedDeps-npmDll`	4.8MB	4.8MB	+7.0KB
`uiActionsEnhanced`	22.1KB	22.2KB	+104.0B
total			+18.3KB

History

💔 Build #35275 failed 9942a02
💚 Build #34755 succeeded 44ceab2
💔 Build #34723 failed 37f391f14c281c628be37e7234e1e7888b04804c
💔 Build #34688 failed b0a708b00ed41d7b25a06568d903ae094bc35224

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Upgrade EUI to v53.0.1 * Update i18n EUI mappings with new super date picker tokens * Update deprecated prettyDuration usage * Fix misc tests/type updates caused by EuiSuperDatePicker i18n release - Fix mock typeof: this changed because the exported EuiSuperDatePicker is no longer a class, but a functional component wrapper around a class - CI test: update now-capitalized datepicker select copy - Jest tests: update snapshots, find()s (`Memo()` selector change is due to the exported EuiSuperDatePicker change) * [kibana-app-services feedback] use renderToString Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 6a44f1f)

kibanamachine · 2022-03-31T23:50:48Z

💚 All backports created successfully

Status	Branch	Result
✅	8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

* Upgrade EUI to v53.0.1 * Update i18n EUI mappings with new super date picker tokens * Update deprecated prettyDuration usage * Fix misc tests/type updates caused by EuiSuperDatePicker i18n release - Fix mock typeof: this changed because the exported EuiSuperDatePicker is no longer a class, but a functional component wrapper around a class - CI test: update now-capitalized datepicker select copy - Jest tests: update snapshots, find()s (`Memo()` selector change is due to the exported EuiSuperDatePicker change) * [kibana-app-services feedback] use renderToString Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 6a44f1f) Co-authored-by: Constance <constancecchen@users.noreply.github.com>

cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI ci:deploy-cloud v8.2.0 v8.3.0 labels Mar 29, 2022

cee-chen requested a review from Bamieh March 29, 2022 20:59

cee-chen requested review from a team as code owners March 29, 2022 20:59

cee-chen commented Mar 29, 2022

View reviewed changes

src/core/public/i18n/i18n_eui_mapping.test.ts Outdated Show resolved Hide resolved

cee-chen commented Mar 29, 2022

View reviewed changes

x-pack/plugins/ui_actions_enhanced/public/custom_time_range_badge.tsx Outdated Show resolved Hide resolved

jbudz approved these changes Mar 29, 2022

View reviewed changes

cee-chen marked this pull request as draft March 29, 2022 22:34

cee-chen force-pushed the eui-53.0.1 branch from b0a708b to 37f391f Compare March 29, 2022 22:57

cee-chen added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 30, 2022

cee-chen added 4 commits March 29, 2022 20:59

Upgrade EUI to v53.0.1

7d5615d

Update i18n EUI mappings with new super date picker tokens

5b802a7

Update deprecated prettyDuration usage

4af747a

cee-chen force-pushed the eui-53.0.1 branch from 37f391f to 44ceab2 Compare March 30, 2022 03:59

cee-chen marked this pull request as ready for review March 30, 2022 04:00

cee-chen requested review from a team as code owners March 30, 2022 04:00

peteharverson approved these changes Mar 30, 2022

View reviewed changes

nickpeihl approved these changes Mar 30, 2022

View reviewed changes

kpatticha mentioned this pull request Mar 30, 2022

[APM] Rendering the service inventory is inexplicably slow #126153

Closed

Bamieh approved these changes Mar 31, 2022

View reviewed changes

vadimkibana approved these changes Mar 31, 2022

View reviewed changes

banderror approved these changes Mar 31, 2022

View reviewed changes

cee-chen removed the ci:deploy-cloud label Mar 31, 2022

[kibana-app-services feedback] use renderToString

baf5714

Merge branch 'main' into eui-53.0.1

9942a02

cee-chen enabled auto-merge (squash) March 31, 2022 16:45

Merge branch 'main' into eui-53.0.1

d552ea2

cee-chen mentioned this pull request Mar 31, 2022

[i18n] Remove i18n token skipping from EUI pluralization defString functions #129144

Merged

1 task

cee-chen merged commit 6a44f1f into elastic:main Mar 31, 2022

cee-chen deleted the eui-53.0.1 branch March 31, 2022 23:47

kibanamachine mentioned this pull request Mar 31, 2022

[8.2] Upgrade EUI to v53.0.1 (#128825) #129150

Merged

Conversation

cee-chen commented Mar 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

53.0.1

53.0.0

Uh oh!

elasticmachine commented Mar 29, 2022

Uh oh!

Uh oh!

Uh oh!

thompsongl commented Mar 29, 2022

Uh oh!

cee-chen commented Mar 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

nickpeihl left a comment

Choose a reason for hiding this comment

Uh oh!

cee-chen commented Mar 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bamieh left a comment

Choose a reason for hiding this comment

Uh oh!

vadimkibana left a comment

Choose a reason for hiding this comment

Uh oh!

banderror left a comment

Choose a reason for hiding this comment

Uh oh!

cee-chen commented Mar 31, 2022

Uh oh!

cee-chen commented Mar 31, 2022

Uh oh!

kibana-ci commented Mar 31, 2022

💛 Build succeeded, but was flaky

Test Failures

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

kibanamachine commented Mar 31, 2022

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

cee-chen commented Mar 29, 2022 •

edited

Loading

`53.0.1`

`53.0.0`

cee-chen commented Mar 29, 2022 •

edited

Loading

cee-chen commented Mar 30, 2022 •

edited

Loading