Skip to content

Remove legacy theme#5688

Merged
thompsongl merged 11 commits intoelastic:mainfrom
thompsongl:deprecate-legacy-theme
Mar 10, 2022
Merged

Remove legacy theme#5688
thompsongl merged 11 commits intoelastic:mainfrom
thompsongl:deprecate-legacy-theme

Conversation

@thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Mar 3, 2022 •
edited
Loading

Summary

Beginning the deprecation of the legacy theme.

  • Remove all references and features from the docs site
  • Remove compiled styles from dist/
  • Remove Legacy CSS-in-JS theme
  • Leave Sass for now because we need to restructure Amsterdam overrides

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in Chrome, Safari, Edge, and Firefox
  • Checked Code Sandbox works for any docs examples
  • Checked for breaking changes and labeled appropriately
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

kibanamachine commented Mar 3, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_5688/

@thompsongl thompsongl added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Mar 8, 2022
@thompsongl thompsongl requested a review from cchaos March 8, 2022 14:53
@thompsongl thompsongl changed the title [WIP] Remove legacy theme from docs site [Docs] Remove legacy theme from docs site Mar 8, 2022
@thompsongl thompsongl marked this pull request as ready for review March 8, 2022 14:53
@kibanamachine
Copy link

kibanamachine commented Mar 8, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_5688/

@thompsongl thompsongl added breaking change PRs with breaking changes. (Don't delete - used for automation) and removed skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) labels Mar 9, 2022
@kibanamachine
Copy link

kibanamachine commented Mar 9, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_5688/

cchaos
cchaos approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a few more removals and updated the Getting Started docs. It's all happening...

@kibanamachine
Copy link

kibanamachine commented Mar 9, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_5688/

@thompsongl thompsongl changed the title [Docs] Remove legacy theme from docs site Remove legacy theme Mar 9, 2022
@kibanamachine
Copy link

kibanamachine commented Mar 9, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_5688/

@kibanamachine
Copy link

kibanamachine commented Mar 10, 2022

Preview documentation changes for this PR: https://eui.elastic.co/pr_5688/

@thompsongl thompsongl merged commit dadd420 into elastic:main Mar 10, 2022
@breehall breehall mentioned this pull request Mar 22, 2022
Merged
@cee-chen cee-chen mentioned this pull request Mar 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cchaos cchaos cchaos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking change PRs with breaking changes. (Don't delete - used for automation)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thompsongl @kibanamachine @cchaos