[Lens] Refactor xy visualization methods#125651
Merged
mbondyra merged 11 commits intoelastic:mainfrom Feb 17, 2022
Merged
Conversation
mbondyra
added
Feature:Lens
release_note:skip
mbondyra
force-pushed
the
lens/annotations
branch
4 times, most recently
from
19e8f36 to
91ae2d9
Compare
mbondyra
changed the title
Contributor
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
mbondyra
force-pushed
the
lens/annotations
branch
from
91ae2d9 to
e7cae5d
Compare
…ue the same name is used for labelInput on filters and intervals
mbondyra
force-pushed
the
lens/annotations
branch
from
0b0ac67 to
0f15216
Compare
flash1293
approved these changes
Feb 17, 2022
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
LGTM, tested and everything still works, code changes make sense to me. I'm not sure about the translations, but it's not a blocker for merging.
mbondyra
commented
Feb 17, 2022
| "xpack.lens.xyChart.bottomAxisLabel": "下の軸", | ||
| "xpack.lens.xyChart.boundaryError": "下界は上界よりも大きくなければなりません", | ||
| "xpack.lens.xyChart.chartTypeLabel": "チャートタイプ", | ||
| "xpack.lens.xyChart.chartTypeLegend": "チャートタイプ", |
Contributor
Author
There was a problem hiding this comment.
so these two belong to the component that was not used but wasn't removed (LayerContextMenu)
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
kibanamachine
removed
the
backport missing
lucasfcosta
pushed a commit
to lucasfcosta/kibana
that referenced
this pull request
Mar 2, 2022
* little helper to check layer types * refactor visualization p1 * fix eslint * divide flyout * fix typo * rename yConfig to config * move LabelInput so it can be used by visualization too - rename becasue the same name is used for labelInput on filters and intervals * i18n fix * p2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts some parts of xy visualization that touch reference lines to make it easier to add annotations.
These changes are just moving parts around, there's nothing serious here.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers