Skip to content

[Lens] Line styles form adapted to the new design #125955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbondyra merged 1 commit into from
Feb 24, 2022
Merged

[Lens] Line styles form adapted to the new design #125955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
119 changes: 63 additions & 56 deletions x-pack/plugins/lens/public/xy_visualization/xy_config_panel/shared/line_style_settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@

import React, { useState } from 'react';
import { i18n } from '@kbn/i18n';
import { EuiButtonGroup, EuiFormRow, EuiRange } from '@elastic/eui';
import {
EuiButtonGroup,
EuiFieldNumber,
EuiFlexGroup,
EuiFlexItem,
EuiFormRow,
} from '@elastic/eui';
import { YConfig } from '../../../../common/expressions';
import { LineStyle } from '../../../../common/expressions/xy_chart';
import { idPrefix } from '../dimension_editor';
Expand All @@ -29,60 +35,62 @@ export const LineStyleSettings = ({
display="columnCompressed"
fullWidth
label={i18n.translate('xpack.lens.xyChart.lineStyle.label', {
defaultMessage: 'Line style',
defaultMessage: 'Line',
})}
>
<EuiButtonGroup
isFullWidth
legend={i18n.translate('xpack.lens.xyChart.lineStyle.label', {
defaultMessage: 'Line style',
})}
data-test-subj="lnsXY_line_style"
name="lineStyle"
buttonSize="compressed"
options={[
{
id: `${idPrefix}solid`,
label: i18n.translate('xpack.lens.xyChart.lineStyle.solid', {
defaultMessage: 'Solid',
}),
'data-test-subj': 'lnsXY_line_style_solid',
},
{
id: `${idPrefix}dashed`,
label: i18n.translate('xpack.lens.xyChart.lineStyle.dashed', {
defaultMessage: 'Dashed',
}),
'data-test-subj': 'lnsXY_line_style_dashed',
},
{
id: `${idPrefix}dotted`,
label: i18n.translate('xpack.lens.xyChart.lineStyle.dotted', {
defaultMessage: 'Dotted',
}),
'data-test-subj': 'lnsXY_line_style_dotted',
},
]}
idSelected={`${idPrefix}${currentConfig?.lineStyle || 'solid'}`}
onChange={(id) => {
const newMode = id.replace(idPrefix, '') as LineStyle;
setConfig({ forAccessor: accessor, lineStyle: newMode });
}}
/>
</EuiFormRow>
<EuiFormRow
display="columnCompressed"
fullWidth
label={i18n.translate('xpack.lens.xyChart.lineThickness.label', {
defaultMessage: 'Line thickness',
})}
>
<LineThicknessSlider
value={currentConfig?.lineWidth || 1}
onChange={(value) => {
setConfig({ forAccessor: accessor, lineWidth: value });
}}
/>
<EuiFlexGroup gutterSize="s" justifyContent="spaceBetween">
<EuiFlexItem grow={true}>
<LineThicknessSlider
value={currentConfig?.lineWidth || 1}
onChange={(value) => {
setConfig({ forAccessor: accessor, lineWidth: value });
}}
/>
</EuiFlexItem>
<EuiFlexItem grow={true}>
<EuiButtonGroup
isFullWidth
legend={i18n.translate('xpack.lens.xyChart.lineStyle.label', {
defaultMessage: 'Line',
})}
data-test-subj="lnsXY_line_style"
name="lineStyle"
buttonSize="compressed"
options={[
{
id: `${idPrefix}solid`,
label: i18n.translate('xpack.lens.xyChart.lineStyle.solid', {
defaultMessage: 'Solid',
}),
'data-test-subj': 'lnsXY_line_style_solid',
iconType: 'lineSolid',
},
{
id: `${idPrefix}dashed`,
label: i18n.translate('xpack.lens.xyChart.lineStyle.dashed', {
defaultMessage: 'Dashed',
}),
'data-test-subj': 'lnsXY_line_style_dashed',
iconType: 'lineDashed',
},
{
id: `${idPrefix}dotted`,
label: i18n.translate('xpack.lens.xyChart.lineStyle.dotted', {
defaultMessage: 'Dotted',
}),
'data-test-subj': 'lnsXY_line_style_dotted',
iconType: 'lineDotted',
},
]}
idSelected={`${idPrefix}${currentConfig?.lineStyle || 'solid'}`}
onChange={(id) => {
const newMode = id.replace(idPrefix, '') as LineStyle;
setConfig({ forAccessor: accessor, lineStyle: newMode });
}}
isIconOnly
/>
</EuiFlexItem>
</EuiFlexGroup>
</EuiFormRow>
</>
);
Expand All @@ -108,11 +116,10 @@ const LineThicknessSlider = ({
const [unsafeValue, setUnsafeValue] = useState<string>(String(value));

return (
<EuiRange
fullWidth
<EuiFieldNumber
data-test-subj="lnsXYThickness"
value={unsafeValue}
showInput
fullWidth
min={minRange}
max={maxRange}
step={1}
Expand Down