[Security Solution][Exceptions] Switches modal to flyout component#123408
Merged
dplumlee merged 6 commits intoelastic:mainfrom Jan 28, 2022
Merged
[Security Solution][Exceptions] Switches modal to flyout component#123408dplumlee merged 6 commits intoelastic:mainfrom
dplumlee merged 6 commits intoelastic:mainfrom
Conversation
dplumlee
added
release_note:enhancement
v8.1.0
Team:Detection Alerts
dplumlee
force-pushed
the
exceptions-modal-to-flyout
branch
from
d6897be to
22fe269
Compare
dplumlee
added
the
auto-backport
yctercero
approved these changes
Jan 26, 2022
Contributor
yctercero
left a comment
yctercero
left a comment
There was a problem hiding this comment.
LGTM 🚀 Pulled down and tested adding an exception, adding an endpoint exception from exceptions tab and alerts table.
Can you open a ticket for the docs team to update any screenshots of the modal to this new layou?
dplumlee
force-pushed
the
exceptions-modal-to-flyout
branch
from
22fe269 to
40ef48d
Compare
auto-merge was automatically disabled
January 27, 2022 23:16
Pull Request is not mergeable
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @dplumlee |
Contributor
💔 Backport failedThe pull request could not be backported due to the following error: How to fixRe-run the backport manually: Questions ?Please refer to the Backport tool documentation |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 28, 2022
…fix-potential-race-condition-when-screenshotting * 'main' of github.com:elastic/kibana: (75 commits) [Reporting] Logging improvements while generating reports (elastic#123802) [Uptime] Default alert connectors email settings (elastic#123244) Update comparison series styles to match the main series (elastic#123858) [RAC][Uptime] remove extra dot from the uptime alert connector message (elastic#124000) [Exploratory view] Allow ability add extra actions in lens embeddable (elastic#123713) [SecuritySolution][Investigations] Add message about missing index in data view in analyzer (elastic#122859) [TSVB] Formatting in the left axis is not respected when I have two separate axis (elastic#123903) [Discover] Remove services from component dependencies (elastic#121691) Stop IM rule execution if there are no events (elastic#123811) [Security Solution][Endpoint] Update Fleet Trusted Apps and Host Isolation Exception cards to use exception list summary API (elastic#123900) [Security Solution][Exceptions] Switches modal to flyout component (elastic#123408) [Workplace Search] Fix bug where modal visible after deleting a group (elastic#123976) [Alerting] Remove state variables from action variable menu (elastic#123702) replace deprecated api usage (elastic#123970) Fix package policy merge logic for boolean values (elastic#123974) [Security Solution][Endpoint][Policy] Remove GET policy list api route (elastic#123873) Reenable alert_add test suite (elastic#123862) [Fleet] Remove usage of IFieldType in Fleet (elastic#123960) [Lists] Add an instance of `ExceptionListClient` with server extension points turned off to context object provided to callbacks (elastic#123885) [Maps] Add execution context (elastic#123651) ... # Conflicts: # x-pack/plugins/screenshotting/server/browsers/chromium/driver_factory/index.ts
awahab07
pushed a commit
to awahab07/kibana
that referenced
this pull request
Jan 31, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #89176
Switches the exceptions modal to a flyout to align with the overall app design better and give users more vertical space to build exceptions. This should also allow much more visibility on smaller screens
This PR switches both the add and edit modals to the new flyout, along with changing all terminology/references in the code to match
Screenshots
Checklist
Delete any items that are not applicable to this PR.
For maintainers