Skip to content

[Reporting] Logging improvements while generating reports#123802

Merged
jloleysens merged 6 commits intoelastic:mainfrom
jloleysens:reporting/improve-logging
Jan 28, 2022
Merged

[Reporting] Logging improvements while generating reports#123802
jloleysens merged 6 commits intoelastic:mainfrom
jloleysens:reporting/improve-logging

Conversation

@jloleysens
Copy link
Copy Markdown
Contributor

@jloleysens jloleysens commented Jan 26, 2022 •
edited by tsullivan
Loading

Summary

Closes #121588

  • Added logic to extract the message from errors logged to the console (should help with future debugging of errors thrown to the console)
  • Added logic to avoid warning about 3xx network responses returned to the browser

Testing

  1. Enable debug logging for reporting and screenshotting in kibana.yml
logging:
  loggers:
    - name: plugins.screenshotting
      level: debug
    - name: plugins.reporting
      level: debug
  1. Run a PNG report of a dashboard, using a Vega panel
  2. Any console messages or errors printed by the dashboard app to the JS console should be legible.

@jloleysens jloleysens added zDeprecated Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes Team:Reporting Services v8.1.0 v8.2.0 v8.0.1 labels Jan 26, 2022
@jloleysens jloleysens requested a review from dokmic January 26, 2022 10:39
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 26, 2022

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 26, 2022

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@jloleysens jloleysens mentioned this pull request Jan 26, 2022
Merged
@jloleysens jloleysens requested a review from tsullivan January 26, 2022 15:40
jloleysens and others added 2 commits January 27, 2022 09:51
@jloleysens @dokmic
Simplify for loop per dokmic's suggestion
9d20c7d 
Co-authored-by: Michael Dokolin <dokmic@gmail.com>
@jloleysens
formatting
5354df2
@jloleysens
Copy link
Copy Markdown
Contributor Author

jloleysens commented Jan 27, 2022

@elasticmachine merge upstream

@jloleysens
Copy link
Copy Markdown
Contributor Author

jloleysens commented Jan 28, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jan 28, 2022

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit 0ee514b into elastic:main Jan 28, 2022
@jloleysens jloleysens deleted the reporting/improve-logging branch January 28, 2022 11:18
@jloleysens jloleysens mentioned this pull request Jan 28, 2022
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 28, 2022
@jloleysens @dokmic @kibanamachine
[Reporting] Logging improvements while generating reports (elastic#12…
e6b8502 
…3802)

* extract message from error objects

* only warn for 400 and up status codes

* Simplify for loop per dokmic's suggestion

Co-authored-by: Michael Dokolin <dokmic@gmail.com>

* formatting

Co-authored-by: Michael Dokolin <dokmic@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0ee514b)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 28, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into screenshotting/…
6f3a9cd 
…fix-potential-race-condition-when-screenshotting

* 'main' of github.com:elastic/kibana: (75 commits)
  [Reporting] Logging improvements while generating reports (elastic#123802)
  [Uptime] Default alert connectors email settings (elastic#123244)
  Update comparison series styles to match the main series (elastic#123858)
  [RAC][Uptime] remove extra dot from the uptime alert connector message (elastic#124000)
  [Exploratory view] Allow ability add extra actions in lens embeddable (elastic#123713)
  [SecuritySolution][Investigations] Add message about missing index in data view in analyzer (elastic#122859)
  [TSVB] Formatting in the left axis is not respected when I have two separate axis (elastic#123903)
  [Discover] Remove services from component dependencies (elastic#121691)
  Stop IM rule execution if there are no events (elastic#123811)
  [Security Solution][Endpoint] Update Fleet Trusted Apps and Host Isolation Exception cards to use exception list summary API (elastic#123900)
  [Security Solution][Exceptions] Switches modal to flyout component (elastic#123408)
  [Workplace Search] Fix bug where modal visible after deleting a group (elastic#123976)
  [Alerting] Remove state variables from action variable menu (elastic#123702)
  replace deprecated api usage (elastic#123970)
  Fix package policy merge logic for boolean values (elastic#123974)
  [Security Solution][Endpoint][Policy] Remove GET policy list api route (elastic#123873)
  Reenable alert_add test suite (elastic#123862)
  [Fleet] Remove usage of IFieldType in Fleet (elastic#123960)
  [Lists] Add an instance of `ExceptionListClient` with server extension points turned off to context object provided to callbacks (elastic#123885)
  [Maps] Add execution context (elastic#123651)
  ...

# Conflicts:
#	x-pack/plugins/screenshotting/server/browsers/chromium/driver_factory/index.ts
@kibanamachine kibanamachine mentioned this pull request Jan 28, 2022
Merged
jloleysens added a commit that referenced this pull request Jan 28, 2022
@jloleysens @dokmic @kibanamachine
[Reporting] Logging improvements while generating reports (#123802) (#…
5f963e1 
…124014)

* extract message from error objects

* only warn for 400 and up status codes

* Simplify for loop per dokmic's suggestion

Co-authored-by: Michael Dokolin <dokmic@gmail.com>

* formatting

Co-authored-by: Michael Dokolin <dokmic@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0ee514b)
awahab07 pushed a commit to awahab07/kibana that referenced this pull request Jan 31, 2022
@jloleysens @dokmic
@kibanamachine @awahab07
[Reporting] Logging improvements while generating reports (elastic#12…
6ff4172 
…3802)

* extract message from error objects

* only warn for 400 and up status codes

* Simplify for loop per dokmic's suggestion

Co-authored-by: Michael Dokolin <dokmic@gmail.com>

* formatting

Co-authored-by: Michael Dokolin <dokmic@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dokmic dokmic dokmic approved these changes

@tsullivan tsullivan Awaiting requested review from tsullivan

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes v8.0.1 v8.1.0 v8.2.0 zDeprecated Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Reporting] Remove log warnings for 3xx responses during screenshot capture

5 participants

@jloleysens @elasticmachine @kibana-ci @dokmic @kibanamachine