Skip to content

[Security Solution] Exceptions Flyout follow-up#125159

Merged
dplumlee merged 5 commits intoelastic:mainfrom
dplumlee:exception-flyout-followup
Feb 23, 2022
Merged

[Security Solution] Exceptions Flyout follow-up#125159
dplumlee merged 5 commits intoelastic:mainfrom
dplumlee:exception-flyout-followup

Conversation

@dplumlee
Copy link
Copy Markdown
Contributor

@dplumlee dplumlee commented Feb 9, 2022

Summary

Fixes a few lingering bugs and UX issues from the previous exceptions flyout PR. Also widens the field column in the exceptions builder to better utilize and fit the increased space a flyout provides.

Specifically addresses:
#124287

Screenshots

Over timeline

Screen Shot 2022-02-09 at 6 21 38 PM

Small Screen layout

Screen Shot 2022-02-09 at 6 22 55 PM

Large Screen layout

Screen Shot 2022-02-09 at 6 15 50 PM

Checklist

Delete any items that are not applicable to this PR.

  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

For maintainers

@dplumlee dplumlee added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.1.0 Team:Detection Alerts Security Detection Alerts Area Team labels Feb 9, 2022
@dplumlee dplumlee self-assigned this Feb 9, 2022
@dplumlee dplumlee force-pushed the exception-flyout-followup branch from 03fe5c8 to 7523ea4 Compare February 9, 2022 22:01
@dplumlee dplumlee added Team:Detections and Resp Security Detection Response Team v8.2.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 9, 2022
@dplumlee dplumlee marked this pull request as ready for review February 9, 2022 23:02
@dplumlee dplumlee requested review from a team as code owners February 9, 2022 23:02
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@dplumlee dplumlee force-pushed the exception-flyout-followup branch from 4ba9b6f to 7188e70 Compare February 15, 2022 20:26
@dplumlee
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 140.7KB 140.7KB -6.0B
securitySolution 4.7MB 4.7MB +49.0B
total +43.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dplumlee

Copy link
Copy Markdown
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pulled down and played around with it. Adding from alerts table, from timeline.

Thanks for the fix!

@dplumlee dplumlee merged commit 2aafd3b into elastic:main Feb 23, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 23, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 24, 2022
(cherry picked from commit 2aafd3b)

Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
@dplumlee dplumlee deleted the exception-flyout-followup branch February 24, 2022 02:51
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Detection Alerts Security Detection Alerts Area Team Team:Detections and Resp Security Detection Response Team v8.1.0 v8.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants