[Alerting] Remove state variables from action variable menu#123702
Merged
ersin-erdal merged 5 commits intoelastic:mainfrom Jan 27, 2022
Merged
[Alerting] Remove state variables from action variable menu#123702ersin-erdal merged 5 commits intoelastic:mainfrom
ersin-erdal merged 5 commits intoelastic:mainfrom
Conversation
ersin-erdal
added
release_note:skip
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Contributor
Author
|
@elasticmachine merge upstream |
ymao1
reviewed
Jan 25, 2022
...s/triggers_actions_ui/public/application/sections/action_connector_form/action_type_form.tsx
Show resolved
Hide resolved
|
|
||
| const paramsVars = prefixKeys(filteredActionVariables.params, 'params.'); | ||
| const stateVars = | ||
| actionGroup?.id === RecoveredActionGroup.id |
Contributor
There was a problem hiding this comment.
Rule types are able to define a custom recovery action group with a custom recovery action group id that is different from RecoveredActionGroup.id. None in actual use yet :) but you can see the definition for the example.people-in-space rule type in x-pack/examples/alerting_example/server/alert_types/astros.ts for an example.
… into 122989-remove-state-from-action
mikecote
approved these changes
Jan 27, 2022
Contributor
mikecote
left a comment
mikecote
left a comment
There was a problem hiding this comment.
Changes LGTM! I pulled down locally and was able to see the state variables disappear when templating a recovery message.
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 28, 2022
…fix-potential-race-condition-when-screenshotting * 'main' of github.com:elastic/kibana: (75 commits) [Reporting] Logging improvements while generating reports (elastic#123802) [Uptime] Default alert connectors email settings (elastic#123244) Update comparison series styles to match the main series (elastic#123858) [RAC][Uptime] remove extra dot from the uptime alert connector message (elastic#124000) [Exploratory view] Allow ability add extra actions in lens embeddable (elastic#123713) [SecuritySolution][Investigations] Add message about missing index in data view in analyzer (elastic#122859) [TSVB] Formatting in the left axis is not respected when I have two separate axis (elastic#123903) [Discover] Remove services from component dependencies (elastic#121691) Stop IM rule execution if there are no events (elastic#123811) [Security Solution][Endpoint] Update Fleet Trusted Apps and Host Isolation Exception cards to use exception list summary API (elastic#123900) [Security Solution][Exceptions] Switches modal to flyout component (elastic#123408) [Workplace Search] Fix bug where modal visible after deleting a group (elastic#123976) [Alerting] Remove state variables from action variable menu (elastic#123702) replace deprecated api usage (elastic#123970) Fix package policy merge logic for boolean values (elastic#123974) [Security Solution][Endpoint][Policy] Remove GET policy list api route (elastic#123873) Reenable alert_add test suite (elastic#123862) [Fleet] Remove usage of IFieldType in Fleet (elastic#123960) [Lists] Add an instance of `ExceptionListClient` with server extension points turned off to context object provided to callbacks (elastic#123885) [Maps] Add execution context (elastic#123651) ... # Conflicts: # x-pack/plugins/screenshotting/server/browsers/chromium/driver_factory/index.ts
awahab07
pushed a commit
to awahab07/kibana
that referenced
this pull request
Jan 31, 2022
…123702) * Remove state variables from action variable menu in the create rule flyout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #122989
Since we don't pass the state variables for recovered alerts, they must be removed from the variables menu in the create rule flyout.
Screen.Recording.mp4