[Security Solution][RAC] - Update reason field text#110308
Merged
michaelolo24 merged 17 commits intoelastic:masterfrom Sep 2, 2021
Merged
[Security Solution][RAC] - Update reason field text#110308michaelolo24 merged 17 commits intoelastic:masterfrom
michaelolo24 merged 17 commits intoelastic:masterfrom
Conversation
michaelolo24
added
Team: SecuritySolution
michaelolo24
added
the
bug
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
stephmilovic
reviewed
Sep 2, 2021
| sourceAddress: getFieldTemplateValue(sourceAddress, true), | ||
| sourcePort: getFieldTemplateValue(sourcePort, true), | ||
| userName: getFieldTemplateValue(userName), | ||
| hasFieldOfInterest: fieldPresenceTracker.hasFieldOfInterest, // Tracking if we have any fields to show the 'with' word |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
stephmilovic
reviewed
Sep 2, 2021
| const reason = buildReasonMessage({ rule }); | ||
| const signal: Signal = buildSignal(events, rule, reason); | ||
| const mergedEvents = objectArrayIntersection(events.map((event) => event._source)); | ||
| const reason = buildReasonMessage({ rule, mergedDoc: mergedEvents as SignalSourceHit }); |
Contributor
There was a problem hiding this comment.
i struggled with this typecast for a while, couldn't get it either. blerg
Contributor
Author
There was a problem hiding this comment.
Yea, it was a pain. Just went with the path of least resistance 😅
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 2, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 2, 2021
Contributor
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 3, 2021
…eporting-to-v2 * 'master' of github.com:elastic/kibana: (65 commits) Move to vis_types folder part 2 (elastic#110574) [SOR] use initialNamespaces when checking for conflict for `create` and `bulkCreate` (elastic#111023) [Discover] Remove export* syntax (elastic#110934) [Event log][7.x] Updated event log client to search across legacy IDs (elastic#109365) [Security Solution][Detection Rules] Changes 'activated' text on rule details page (elastic#111044) [Metrics UI] Filter out APM nodes from the inventory view (elastic#110300) [package testing] Update logging and pid configuration (elastic#111059) [Dashboard] Read App State from URL on Soft Refresh (elastic#109354) Add correct roles to test user for functional tests in dashboard (elastic#110880) [DOCS] Adds Lens Inspector and minor edits (elastic#109736) [DOCS] Updates Spaces page (elastic#111005) normalize initialNamespaces (elastic#110936) [Reporting] Clean up `any` usage, reorganize server route files (elastic#110740) [Security Solution] [CTI] Fixes bug that caused Threshold and Indicator Match rules to ignore custom rule filters if a saved query was used in the rule definition. (elastic#109253) skip flaky suites: elastic#111001, elastic#111022 [Security Solution][RAC] - Update reason field text (elastic#110308) [RAC][Security Solution] Make analyzer work with EuiDataGrid full screen (elastic#110913) [Metrics UI] Add integration tests for Metric Threshold Rule and refactor to fire correctly (elastic#109971) [DOCS] Updates Discover docs (elastic#110346) [RAC] Persistent timeline fields fix (elastic#110685) ...
kibanamachine
added a commit
that referenced
this pull request
Sep 3, 2021
kibanamachine
added a commit
that referenced
this pull request
Sep 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The goal of this PR is to update the reason field to be more meaningful for our users by making use of potentially interesting fields to give more detailed feedback. The updated string can be seen below:
Checklist
Delete any items that are not applicable to this PR.