[Reporting] Clean up any usage, reorganize server route files#110740
Merged
tsullivan merged 8 commits intoelastic:masterfrom Sep 2, 2021
Merged
[Reporting] Clean up any usage, reorganize server route files#110740tsullivan merged 8 commits intoelastic:masterfrom
any usage, reorganize server route files#110740tsullivan merged 8 commits intoelastic:masterfrom
Conversation
tsullivan
force-pushed
the
reporting/cleanup-server-routes
branch
6 times, most recently
from
c11a8e0 to
6477a60
Compare
tsullivan
force-pushed
the
reporting/cleanup-server-routes
branch
from
6477a60 to
1d5ddbb
Compare
tsullivan
force-pushed
the
reporting/cleanup-server-routes
branch
from
966a425 to
a3db310
Compare
tsullivan
changed the title
any instances, refactor server route files
tsullivan
changed the title
any instances, refactor server route filesany usage, refactor server route files
tsullivan
changed the title
any usage, refactor server route filesany usage, reorganize server route files
tsullivan
added
zDeprecated Feature:Reporting
Contributor
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
Contributor
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
tsullivan
force-pushed
the
reporting/cleanup-server-routes
branch
from
55934cd to
a3db310
Compare
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
tsullivan
commented
Sep 2, 2021
| * 2.0. | ||
| */ | ||
|
|
||
| import Boom from '@hapi/boom'; |
Member
Author
There was a problem hiding this comment.
This code was pulled out of x-pack/plugins/reporting/server/routes/generation.ts to allow better reusability
jloleysens
approved these changes
Sep 2, 2021
Contributor
jloleysens
left a comment
jloleysens
left a comment
There was a problem hiding this comment.
Thanks for doing this clean up! Looks great to me.
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Sep 2, 2021
…tic#110740) * refactor/reflatten server routes * fix import * fix any usage in server/lib * clean up unused parameter * remove any in server/browsers * refactor handle request function into a class * more cleanup
tsullivan
added a commit
that referenced
this pull request
Sep 2, 2021
) (#111027) * refactor/reflatten server routes * fix import * fix any usage in server/lib * clean up unused parameter * remove any in server/browsers * refactor handle request function into a class * more cleanup
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 3, 2021
…eporting-to-v2 * 'master' of github.com:elastic/kibana: (65 commits) Move to vis_types folder part 2 (elastic#110574) [SOR] use initialNamespaces when checking for conflict for `create` and `bulkCreate` (elastic#111023) [Discover] Remove export* syntax (elastic#110934) [Event log][7.x] Updated event log client to search across legacy IDs (elastic#109365) [Security Solution][Detection Rules] Changes 'activated' text on rule details page (elastic#111044) [Metrics UI] Filter out APM nodes from the inventory view (elastic#110300) [package testing] Update logging and pid configuration (elastic#111059) [Dashboard] Read App State from URL on Soft Refresh (elastic#109354) Add correct roles to test user for functional tests in dashboard (elastic#110880) [DOCS] Adds Lens Inspector and minor edits (elastic#109736) [DOCS] Updates Spaces page (elastic#111005) normalize initialNamespaces (elastic#110936) [Reporting] Clean up `any` usage, reorganize server route files (elastic#110740) [Security Solution] [CTI] Fixes bug that caused Threshold and Indicator Match rules to ignore custom rule filters if a saved query was used in the rule definition. (elastic#109253) skip flaky suites: elastic#111001, elastic#111022 [Security Solution][RAC] - Update reason field text (elastic#110308) [RAC][Security Solution] Make analyzer work with EuiDataGrid full screen (elastic#110913) [Metrics UI] Add integration tests for Metric Threshold Rule and refactor to fire correctly (elastic#109971) [DOCS] Updates Discover docs (elastic#110346) [RAC] Persistent timeline fields fix (elastic#110685) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
anyusage from production (non-test) code in Reporting.RequestHandlerclass which can later be used to handle reports to create scheduled reports.layoutparameter from getScreenshotsThis remove 19 instances of
anyin production reporting code, resulting in 22 remaining instances. Here are the 22 remaininganyinstances as of this PR:Checklist
Delete any items that are not applicable to this PR.