[APM] Various improvements from #104851 by sorenlouv · Pull Request #107726 · elastic/kibana

sorenlouv · 2021-08-05T09:23:42Z

In #104851 I wanted to fix the throughput charts. While doing this I ran into a couple of issues with our types that made the change harder.

This PR doesn't contain any user facing changes (also no changes to how throughput is being calculated). It only contains various minor improvements to our types that should make changes slightly easier in the future.

elasticmachine · 2021-08-05T09:23:48Z

Pinging @elastic/apm-ui (Team:apm)

sorenlouv · 2021-08-05T09:29:11Z

x-pack/plugins/apm/server/lib/services/get_service_instance_metadata_details.ts

-export interface KeyValue {
-  key: string;
-  value: any | undefined;
-}


sorenlouv · 2021-08-05T09:29:52Z

x-pack/plugins/apm/common/utils/formatters/datetime.ts

+  /**
+   * timestamp in milliseconds or ISO timestamp
+   */
+  time: number | string,


Turns out that we actually call this function with string but due to manual type overrides we've newer noticed.

dgieselaar · 2021-08-05T09:32:07Z

x-pack/plugins/apm/public/components/shared/managed_table/index.tsx

  align?: string;
  width?: string;
  sortable?: boolean;
+  truncateText?: boolean;


is this being used somewhere?

Yes, in

kibana/x-pack/plugins/apm/public/components/app/Settings/customize_ui/custom_link/custom_link_table.tsx

Line 41 in 9d42d67

truncateText: true,

We didn't have typed table columns before so it wasn't an error until now

dgieselaar

lgtm, thanks for doing this

sorenlouv · 2021-08-05T09:32:28Z

x-pack/plugins/apm/public/components/app/Settings/agent_configurations/List/index.tsx

      name: '',
      sortable: true,
-      render: (isApplied: boolean) => (
+      render: (_, { applied_by_agent: appliedByAgent }) => (


Avoiding manual type overrides and preserving the correct type

sorenlouv · 2021-08-05T09:32:45Z

...ck/plugins/apm/public/components/app/Settings/customize_ui/custom_link/custom_link_table.tsx

  const canSave = core.application.capabilities.apm.save;

-  const columns = [
+  const columns: Array<ITableColumn<CustomLink>> = [


Adding types to table columns

sorenlouv · 2021-08-05T09:34:41Z

...ns/apm/public/components/app/service_overview/service_overview_instances_chart_and_table.tsx

-  latency: number;
-  cpuUsage: number;
-  memoryUsage: number;
-}


Avoid explicit types when the (correct) type can be infered via APIReturnType

kibanamachine · 2021-08-06T00:16:54Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	4.3MB	4.3MB	+382.0B

Unknown metric groups

Non-exported public API item count

id	before	after	diff
`apm`	30	29	-1

History

💚 Build #143234 succeeded 63275d4
💔 Build #143181 failed e00a7c9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sorenlouv · 2021-08-07T08:10:10Z

jenkins run the e2e

kibanamachine · 2021-08-07T11:23:08Z

The following labels were identified as gaps in your version labels and will be added automatically:

v7.15.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine · 2021-08-07T11:25:54Z

💔 Backport failed

Status	Branch	Result
❌	7.14	Commit could not be cherrypicked due to conflicts
✅	7.x

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 107726

Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>

…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (392 commits) update linting doc (elastic#105748) [APM] Various improvements from elastic#104851 (elastic#107726) Update dependency @elastic/charts to v33.2.0 (master) (elastic#107842) Fix default route link on kibana homepage (elastic#107809) [APM] Invalidate trackPageview on route change (elastic#107741) Service map backend links (elastic#107317) [index patterns] index pattern create modal (elastic#101853) [RAC] integrating rbac search strategy with alert table (elastic#107242) [Security Solution] Siem signals -> alerts as data field and index aliases (elastic#106049) [Metrics UI] Add checkbox to optionally drop partial buckets (elastic#107676) [Metrics UI] Fix metric threshold preview regression (elastic#107674) Disable Product check in @elastic/elasticsearch-js (elastic#107642) [App Search] Migrate Crawler Status Indicator, Crawler Status Banner, and Crawl Request polling (elastic#107603) [Security Solution, Lists] Replace legacy imports from 'elasticsearch' package (elastic#107226) [maps] asset tracking tutorial (elastic#104552) [scripts/build_ts_refs] when using `--clean` initialize caches (elastic#107777) Upgrade EUI to v36.1.0 (elastic#107231) [RAC] [TGrid] Implements cell actions in the TGrid (elastic#107771) Realign cypress/ccs_integration with cypress/integration (elastic#107743) Allow optional OSS to X-Pack dependencies (elastic#107432) ... # Conflicts: # x-pack/examples/reporting_example/public/application.tsx # x-pack/examples/reporting_example/public/components/app.tsx # x-pack/plugins/canvas/public/services/legacy/stubs/reporting.ts # x-pack/plugins/reporting/common/types.ts # x-pack/plugins/reporting/public/lib/reporting_api_client/context.tsx # x-pack/plugins/reporting/public/management/mount_management_section.tsx # x-pack/plugins/reporting/public/management/report_listing.test.tsx # x-pack/plugins/reporting/public/plugin.ts # x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx # x-pack/plugins/reporting/server/export_types/printable_pdf/execute_job/index.ts

sorenlouv added 6 commits August 5, 2021 10:37

Remove MainStatsServiceInstanceItem interface

178bd31

Improve types in tables

cc44b06

Use TickFormatter

7755770

Simplify chart selectors

5e83a7f

Remove unused KeyValue

417f361

Avoid unneeded types

d722d5b

sorenlouv requested a review from a team August 5, 2021 09:23

botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Aug 5, 2021

sorenlouv commented Aug 5, 2021

View reviewed changes

dgieselaar reviewed Aug 5, 2021

View reviewed changes

dgieselaar approved these changes Aug 5, 2021

View reviewed changes

sorenlouv commented Aug 5, 2021

View reviewed changes

Add types to table

154375e

sorenlouv commented Aug 5, 2021

View reviewed changes

Use APIReturnType instead of PromiseReturnType

e00a7c9

sorenlouv added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Aug 5, 2021

sorenlouv added 2 commits August 5, 2021 15:31

Fix last_seen in snapshot

63275d4

Removed legacy APM e2e

1dbe61a

sorenlouv mentioned this pull request Aug 7, 2021

[APM] Display throughput as tps (instead of tpm) when bucket size < 60 seconds #107850

Merged

sorenlouv merged commit b16d20b into elastic:master Aug 7, 2021

sorenlouv deleted the followup-fixes-throughput-fixes branch August 7, 2021 11:22

kibanamachine added the v7.15.0 label Aug 7, 2021

kibanamachine mentioned this pull request Aug 7, 2021

[7.x] [APM] Various improvements from #104851 (#107726) #107851

Merged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 7, 2021

[APM] Various improvements from elastic#104851 (elastic#107726)

6b9cf0c

sorenlouv mentioned this pull request Aug 7, 2021

[APM] Fix confusing throughput #104851

Closed

kibanamachine added a commit that referenced this pull request Aug 7, 2021

[APM] Various improvements from #104851 (#107726) (#107851)

575993d

Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>

streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021

[APM] Various improvements from elastic#104851 (elastic#107726)

5f4d680

Conversation

sorenlouv commented Aug 5, 2021

Uh oh!

elasticmachine commented Aug 5, 2021

Uh oh!

sorenlouv Aug 5, 2021

Choose a reason for hiding this comment

Uh oh!

sorenlouv Aug 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dgieselaar Aug 5, 2021

Choose a reason for hiding this comment

Uh oh!

sorenlouv Aug 5, 2021

Choose a reason for hiding this comment

Uh oh!

dgieselaar left a comment

Choose a reason for hiding this comment

Uh oh!

sorenlouv Aug 5, 2021

Choose a reason for hiding this comment

Uh oh!

sorenlouv Aug 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sorenlouv Aug 5, 2021

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Aug 6, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Non-exported public API item count

History

Uh oh!

sorenlouv commented Aug 7, 2021

Uh oh!

kibanamachine commented Aug 7, 2021

Uh oh!

kibanamachine commented Aug 7, 2021

💔 Backport failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sorenlouv Aug 5, 2021 •

edited

Loading

sorenlouv Aug 5, 2021 •

edited

Loading