[Metrics UI] Fix metric threshold preview regression#107674
Merged
Zacqary merged 1 commit intoelastic:masterfrom Aug 5, 2021
Merged
[Metrics UI] Fix metric threshold preview regression#107674Zacqary merged 1 commit intoelastic:masterfrom
Zacqary merged 1 commit intoelastic:masterfrom
Conversation
Zacqary
added
release_note:fix
Feature:Metrics UI
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
Zacqary
added
the
auto-backport
simianhacker
approved these changes
Aug 5, 2021
Member
simianhacker
left a comment
simianhacker
left a comment
There was a problem hiding this comment.
LGTM
Side note: The "no data" detection seems off BUT it's always seemed off. I wonder why I would get 20 instances of "no data" when I know for a fact there are ZERO gaps in the data. This is something we need to look into later.
Contributor
💔 Backport failed
To backport manually run: |
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Aug 5, 2021
# Conflicts: # x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/evaluate_alert.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/metric_query.ts
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Aug 5, 2021
# Conflicts: # x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/evaluate_alert.ts
Zacqary
added a commit
that referenced
this pull request
Aug 7, 2021
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 9, 2021
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (392 commits) update linting doc (elastic#105748) [APM] Various improvements from elastic#104851 (elastic#107726) Update dependency @elastic/charts to v33.2.0 (master) (elastic#107842) Fix default route link on kibana homepage (elastic#107809) [APM] Invalidate trackPageview on route change (elastic#107741) Service map backend links (elastic#107317) [index patterns] index pattern create modal (elastic#101853) [RAC] integrating rbac search strategy with alert table (elastic#107242) [Security Solution] Siem signals -> alerts as data field and index aliases (elastic#106049) [Metrics UI] Add checkbox to optionally drop partial buckets (elastic#107676) [Metrics UI] Fix metric threshold preview regression (elastic#107674) Disable Product check in @elastic/elasticsearch-js (elastic#107642) [App Search] Migrate Crawler Status Indicator, Crawler Status Banner, and Crawl Request polling (elastic#107603) [Security Solution, Lists] Replace legacy imports from 'elasticsearch' package (elastic#107226) [maps] asset tracking tutorial (elastic#104552) [scripts/build_ts_refs] when using `--clean` initialize caches (elastic#107777) Upgrade EUI to v36.1.0 (elastic#107231) [RAC] [TGrid] Implements cell actions in the TGrid (elastic#107771) Realign cypress/ccs_integration with cypress/integration (elastic#107743) Allow optional OSS to X-Pack dependencies (elastic#107432) ... # Conflicts: # x-pack/examples/reporting_example/public/application.tsx # x-pack/examples/reporting_example/public/components/app.tsx # x-pack/plugins/canvas/public/services/legacy/stubs/reporting.ts # x-pack/plugins/reporting/common/types.ts # x-pack/plugins/reporting/public/lib/reporting_api_client/context.tsx # x-pack/plugins/reporting/public/management/mount_management_section.tsx # x-pack/plugins/reporting/public/management/report_listing.test.tsx # x-pack/plugins/reporting/public/plugin.ts # x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx # x-pack/plugins/reporting/server/export_types/printable_pdf/execute_job/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #107672
Metric threshold alert previews will now generate enough buckets to look back an hour/day/etc., instead of just generating one bucket..
Checklist