Skip to content

[APM] Invalidate trackPageview on route change#107741

Merged
dgieselaar merged 1 commit intoelastic:masterfrom
dgieselaar:invalidate-track-pageview
Aug 6, 2021
Merged

[APM] Invalidate trackPageview on route change#107741
dgieselaar merged 1 commit intoelastic:masterfrom
dgieselaar:invalidate-track-pageview

Conversation

@dgieselaar
Copy link
Copy Markdown
Contributor

Closes #107728.

Adds an effect dependency to useTrackPageview to make sure it is invalidated on route change.

@dgieselaar dgieselaar added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0 labels Aug 5, 2021
@dgieselaar dgieselaar requested a review from a team August 5, 2021 12:28
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/apm-ui (Team:apm)

@dgieselaar dgieselaar added auto-backport Deprecated - use backport:version if exact versions are needed v7.14.1 and removed v7.14.0 labels Aug 5, 2021
@dgieselaar dgieselaar changed the title [APM] Invalidate trackPageview no route change [APM] Invalidate trackPageview on route change Aug 5, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +24.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit 2407080 into elastic:master Aug 6, 2021
@dgieselaar dgieselaar deleted the invalidate-track-pageview branch August 6, 2021 11:04
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 6, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Backport failed

Status Branch Result
7.x
7.14 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 107741

dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Aug 6, 2021
Closes elastic#107728.
# Conflicts:
#	x-pack/plugins/apm/public/components/routing/track_pageview.tsx
kibanamachine added a commit that referenced this pull request Aug 6, 2021
Closes #107728.

Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 9, 2021
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (392 commits)
  update linting doc (elastic#105748)
  [APM] Various improvements from elastic#104851 (elastic#107726)
  Update dependency @elastic/charts to v33.2.0 (master) (elastic#107842)
  Fix default route link on kibana homepage (elastic#107809)
  [APM] Invalidate trackPageview on route change (elastic#107741)
  Service map backend links (elastic#107317)
  [index patterns] index pattern create modal (elastic#101853)
  [RAC] integrating rbac search strategy with alert table (elastic#107242)
  [Security Solution] Siem signals -> alerts as data field and index aliases (elastic#106049)
  [Metrics UI] Add checkbox to optionally drop partial buckets (elastic#107676)
  [Metrics UI] Fix metric threshold preview regression (elastic#107674)
  Disable Product check in @elastic/elasticsearch-js (elastic#107642)
  [App Search] Migrate Crawler Status Indicator, Crawler Status Banner, and Crawl Request polling (elastic#107603)
  [Security Solution, Lists] Replace legacy imports from 'elasticsearch' package (elastic#107226)
  [maps] asset tracking tutorial (elastic#104552)
  [scripts/build_ts_refs] when using `--clean` initialize caches (elastic#107777)
  Upgrade EUI to v36.1.0 (elastic#107231)
  [RAC] [TGrid] Implements cell actions in the TGrid (elastic#107771)
  Realign cypress/ccs_integration with cypress/integration (elastic#107743)
  Allow optional OSS to X-Pack dependencies (elastic#107432)
  ...

# Conflicts:
#	x-pack/examples/reporting_example/public/application.tsx
#	x-pack/examples/reporting_example/public/components/app.tsx
#	x-pack/plugins/canvas/public/services/legacy/stubs/reporting.ts
#	x-pack/plugins/reporting/common/types.ts
#	x-pack/plugins/reporting/public/lib/reporting_api_client/context.tsx
#	x-pack/plugins/reporting/public/management/mount_management_section.tsx
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
#	x-pack/plugins/reporting/public/plugin.ts
#	x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
#	x-pack/plugins/reporting/server/export_types/printable_pdf/execute_job/index.ts
dgieselaar added a commit that referenced this pull request Aug 9, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.14.1 v7.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[APM] Page tracking only works on full page reload

4 participants