[Index Patterns] Move rollup config to index pattern management v2 by mattkime · Pull Request #102285 · elastic/kibana

mattkime · 2021-06-16T01:37:16Z

Summary

Changes to #102145 (which was reverted)

Move uiSettings check from setup lifecycle function to when the UI is rendered - d74614a
Check whether the uiSetting value is provided before getting the value to avoid errors - 217e304

TLDR; Removing rollup plugin's dependence on the indexPatternManagment plugin will allow the (in progress) indexPatternEditor plugin to determine if the rollup plugin is active, otherwise there's a circular dependency. This is also tech debt reduction.

Refactor index pattern creation code so its all within the index pattern management plugin. Previously rollup related code was in the rollup plugin since it was an x-pack feature. We're no longer creating one off APIs to maintain the distinction between x-pack features and OSS code.

mattkime · 2021-06-16T16:51:35Z

@elasticmachine merge upstream

elasticmachine · 2021-06-16T20:50:18Z

Pinging @elastic/kibana-app-services (Team:AppServices)

cjcenizal

Haven't tested locally but code LGTM! Had a couple questions/suggestions but nothing blocking.

cjcenizal · 2021-06-16T20:57:58Z

src/plugins/index_pattern_management/public/service/creation/manager.ts

-        const config = new Config({ httpClient });
+export class IndexPatternCreationManager {
+  start({ httpClient, uiSettings }: IndexPatternCreationManagerStart) {
+    const getConfigs = memoize(() => {


Can you help me understand why this is memoized? The provided function doesn't accept any arguments and we're not passing a second resolver argument to memoize, so I don't see how the memoize function could use any map cache keys to memoize the results of the provided function.

Maybe it makes more sense to use once instead?

Ah, that makes sense

cjcenizal · 2021-06-16T22:15:30Z

src/plugins/index_pattern_management/public/service/list/manager.ts

-        const config = new Config();
+export class IndexPatternListManager {
+  start({ uiSettings }: IndexPatternListManagerStart) {
+    const getConfigs = memoize(() => {


…om:mattkime/kibana into rollup_creation_code_to_index_pattern_mgmt

kibanamachine · 2021-06-17T01:13:25Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`indexPatternManagement`	162	167	+5
`rollup`	169	165	-4
total			+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`indexPatternManagement`	45	0	-45

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`rollup`	230.2KB	230.2KB	+9.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`indexPatternManagement`	3	0	-3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`indexPatternManagement`	12.9KB	19.1KB	+6.2KB
`rollup`	40.8KB	33.8KB	-7.0KB
total			-888.0B

Unknown metric groups

API count

id	before	after	diff
`indexPatternManagement`	45	0	-45

References to deprecated APIs

id	before	after	diff
`indexPatternManagement`	68	0	-68

History

💚 Build #131770 succeeded 57f36af
💔 Build #131719 failed 217e304
💔 Build #131561 failed d74614a
💔 Build #131556 failed cfb8417

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…lastic#102285) * move rollup config to index pattern management

kibanamachine · 2021-06-17T01:19:06Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…102285) (#102442) * move rollup config to index pattern management Co-authored-by: Matthew Kime <matt@mattki.me>

…egrations-to-global-search * 'master' of github.com:elastic/kibana: (46 commits) [Lens] Add some more documentation for dynamic coloring (elastic#101369) hide not searchable results when no term (elastic#102401) [Lens] Fix Formula functional test with multiple suggestions (elastic#102378) Fix trusted apps modified by field displayed as a date field (elastic#102377) [Lens] Docs for time shift (elastic#102048) update readme of logs-metrics-ui (elastic#101968) Refactor observability plugin breadcrumbs (elastic#102290) [Index Patterns] Move rollup config to index pattern management v2 (elastic#102285) [Security Solution][Endpoint] Isolate Action should only be available to Platinum+ licenses (elastic#102374) [build] Updates Ironbank templates (elastic#102407) Update security best practices document (elastic#100814) [Enterprise Search] Set up initial KibanaPageTemplate (elastic#102170) [Reporting/Docs] Add section to troubleshooting guide to explain the StatusCodeError logs (elastic#102278) [DOCS] Updating Elastic Security Overview topic (elastic#101922) [Uptime] refactor Synthetics Integration package UI (elastic#102080) [Task Manager] Log at different levels based on the state (elastic#101751) [APM] Fixing time comparison types (elastic#101423) [RAC] Update alert documents in lifecycle rule type helper (elastic#101598) [ML] Functional tests - fix and re-activate alerting flyout test (elastic#102368) [Reporting] remove unused reference to path.data config (elastic#102267) ... # Conflicts: # x-pack/plugins/fleet/kibana.json

mattkime added 5 commits June 14, 2021 17:43

move rollup config to index pattern management

c134740

fix imports

5cc9214

fix localization, remove comments, cleanup

af50788

provide default for uiSettings lookup

452baf6

Merge branch 'master' into rollup_creation_code_to_index_pattern_mgmt

cfb8417

mattkime added auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Rollups release_note:skip Skip the PR/issue when compiling release notes Team:AppServices v7.14.0 v8.0.0 labels Jun 16, 2021

mattkime added 2 commits June 15, 2021 22:55

refactor to only reference uiSettings after lifecycle functions have run

d74614a

check if uiSetting is declared before checking for value

217e304

Merge branch 'master' into rollup_creation_code_to_index_pattern_mgmt

57f36af

mattkime marked this pull request as ready for review June 16, 2021 20:50

mattkime requested a review from a team as a code owner June 16, 2021 20:50

mattkime requested a review from cjcenizal June 16, 2021 20:50

mattkime changed the title ~~Rollup creation code to index pattern mgmt~~ [Index Patterns] Move rollup config to index pattern management v2 Jun 16, 2021

cjcenizal approved these changes Jun 16, 2021

View reviewed changes

mattkime added 2 commits June 16, 2021 18:08

memoize => once

4dd2931

Merge branch 'rollup_creation_code_to_index_pattern_mgmt' of github.c…

0e18233

…om:mattkime/kibana into rollup_creation_code_to_index_pattern_mgmt

mattkime merged commit bfca0c3 into elastic:master Jun 17, 2021

kibanamachine mentioned this pull request Jun 17, 2021

[7.x] [Index Patterns] Move rollup config to index pattern management v2 (#102285) #102442

Merged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 17, 2021

[Index Patterns] Move rollup config to index pattern management v2 (e…

a2136c9

…lastic#102285) * move rollup config to index pattern management

kibanamachine added a commit that referenced this pull request Jun 17, 2021

[Index Patterns] Move rollup config to index pattern management v2 (#…

ad2ebc7

…102285) (#102442) * move rollup config to index pattern management Co-authored-by: Matthew Kime <matt@mattki.me>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Index Patterns] Move rollup config to index pattern management v2#102285

[Index Patterns] Move rollup config to index pattern management v2#102285
mattkime merged 10 commits intoelastic:masterfrom
mattkime:rollup_creation_code_to_index_pattern_mgmt

mattkime commented Jun 16, 2021 •

edited

Loading

Uh oh!

mattkime commented Jun 16, 2021

Uh oh!

elasticmachine commented Jun 16, 2021

Uh oh!

cjcenizal left a comment

Uh oh!

cjcenizal Jun 16, 2021

Uh oh!

mattkime Jun 16, 2021

Uh oh!

cjcenizal Jun 16, 2021

Uh oh!

kibanamachine commented Jun 17, 2021

API count

References to deprecated APIs

Uh oh!

kibanamachine commented Jun 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mattkime commented Jun 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

mattkime commented Jun 16, 2021

Uh oh!

elasticmachine commented Jun 16, 2021

Uh oh!

cjcenizal left a comment

Choose a reason for hiding this comment

Uh oh!

cjcenizal Jun 16, 2021

Choose a reason for hiding this comment

Uh oh!

mattkime Jun 16, 2021

Choose a reason for hiding this comment

Uh oh!

cjcenizal Jun 16, 2021

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jun 17, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

References to deprecated APIs

History

Uh oh!

kibanamachine commented Jun 17, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mattkime commented Jun 16, 2021 •

edited

Loading