[Index Patterns] Move rollup config to index pattern management#102145
[Index Patterns] Move rollup config to index pattern management#102145mattkime merged 3 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
|
|
||
| export { IndexPatternCreationConfig, IndexPatternCreationOption } from './config'; | ||
| export { IndexPatternCreationManager } from './manager'; | ||
| // @ts-ignore |
There was a problem hiding this comment.
Rollups had two js files that I'd prefer not to convert to typescript at this point. There are plans for rollup improvements that would make these files unnecessary.
| * in compliance with, at your election, the Elastic License 2.0 or the Server | ||
| * Side Public License, v 1. | ||
| */ | ||
|
|
There was a problem hiding this comment.
This value is duplicated from the rollup plugin. I thought it would be better than creating a dependency but open to discuss.
cjcenizal
left a comment
There was a problem hiding this comment.
Code LGTM! I think that removing this indirection and the dependency of rollups upon index pattern management makes the code easier to understand. I haven't tested locally so I'm assuming you verified that rollup index patterns can still be created, edited, and listed.
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: |
…tic#102145) * move rollup config to index pattern management
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…tic#102145) * move rollup config to index pattern management
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Summary
TLDR; Removing
rollupplugin's dependence on theindexPatternManagmentplugin will allow the (in progress)indexPatternEditorplugin to determine if therollupplugin is active, otherwise there's a circular dependency. This is also tech debt reduction.Refactor index pattern creation code so its all within the index pattern management plugin. Previously rollup related code was in the rollup plugin since it was an x-pack feature. We're no longer creating one off APIs to maintain the distinction between x-pack features and OSS code.