Skip to content

[ML] Functional tests - fix and re-activate alerting flyout test#102368

Merged
pheyos merged 1 commit intoelastic:masterfrom
pheyos:fix_ml_alerting_tests
Jun 16, 2021
Merged

[ML] Functional tests - fix and re-activate alerting flyout test#102368
pheyos merged 1 commit intoelastic:masterfrom
pheyos:fix_ml_alerting_tests

Conversation

@pheyos
Copy link
Member

@pheyos pheyos commented Jun 16, 2021

Summary

This PR fixes the ML alerting flyout tests and re-activates it.

Details

  • The initial stability fix [ML] Functional tests - stabilize alerting flyout test #102030 didn't handle the case of 1 anomaly correctly.
  • It also didn't take into account that the data "aged out" and the 2y preview lookback didn't deliver data anymore.
  • As a quick fix, the lookback period is set to 5y, but we'll need to update the test dataset some day.

Closes #102012

@pheyos pheyos added :ml test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Jun 16, 2021
@pheyos pheyos requested review from peteharverson and qn895 June 16, 2021 15:38
@pheyos pheyos self-assigned this Jun 16, 2021
@pheyos pheyos requested a review from a team as a code owner June 16, 2021 15:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member

qn895 commented Jun 16, 2021

Changes LGTM

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 16, 2021
@pheyos pheyos enabled auto-merge (squash) June 16, 2021 16:02
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

@pheyos pheyos merged commit 1541507 into elastic:master Jun 16, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 16, 2021
…stic#102368)

This PR fixes the ML alerting flyout tests and re-activates it.
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 16, 2021
…2368) (#102392)

This PR fixes the ML alerting flyout tests and re-activates it.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 17, 2021
…egrations-to-global-search

* 'master' of github.com:elastic/kibana: (46 commits)
  [Lens] Add some more documentation for dynamic coloring (elastic#101369)
  hide not searchable results when no term (elastic#102401)
  [Lens] Fix Formula functional test with multiple suggestions (elastic#102378)
  Fix trusted apps modified by field displayed as a date field (elastic#102377)
  [Lens] Docs for time shift (elastic#102048)
  update readme of logs-metrics-ui (elastic#101968)
  Refactor observability plugin breadcrumbs (elastic#102290)
  [Index Patterns] Move rollup config to index pattern management v2 (elastic#102285)
  [Security Solution][Endpoint] Isolate Action should only be available to Platinum+ licenses (elastic#102374)
  [build] Updates Ironbank templates (elastic#102407)
  Update security best practices document (elastic#100814)
  [Enterprise Search] Set up initial KibanaPageTemplate  (elastic#102170)
  [Reporting/Docs] Add section to troubleshooting guide to explain the StatusCodeError logs (elastic#102278)
  [DOCS] Updating Elastic Security Overview topic  (elastic#101922)
  [Uptime] refactor Synthetics Integration package UI (elastic#102080)
  [Task Manager] Log at different levels based on the state (elastic#101751)
  [APM] Fixing time comparison types (elastic#101423)
  [RAC] Update alert documents in lifecycle rule type helper (elastic#101598)
  [ML] Functional tests - fix and re-activate alerting flyout test (elastic#102368)
  [Reporting] remove unused reference to path.data config (elastic#102267)
  ...

# Conflicts:
#	x-pack/plugins/fleet/kibana.json
@pheyos pheyos deleted the fix_ml_alerting_tests branch September 1, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.14.0 v8.0.0

Projects

None yet

5 participants