[Reporting] remove unused reference to path.data config#102267
Merged
tsullivan merged 1 commit intoelastic:masterfrom Jun 16, 2021
Merged
[Reporting] remove unused reference to path.data config#102267tsullivan merged 1 commit intoelastic:masterfrom
tsullivan merged 1 commit intoelastic:masterfrom
Conversation
tsullivan
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
dokmic
approved these changes
Jun 16, 2021
jloleysens
approved these changes
Jun 16, 2021
Contributor
jloleysens
left a comment
jloleysens
left a comment
There was a problem hiding this comment.
Did not test locally, but happy if CI is passing with this change 👍.
Did a search for any other instances of path.data being used in reporting and did note see any.
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jun 16, 2021
tsullivan
added a commit
that referenced
this pull request
Jun 16, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 17, 2021
…egrations-to-global-search * 'master' of github.com:elastic/kibana: (46 commits) [Lens] Add some more documentation for dynamic coloring (elastic#101369) hide not searchable results when no term (elastic#102401) [Lens] Fix Formula functional test with multiple suggestions (elastic#102378) Fix trusted apps modified by field displayed as a date field (elastic#102377) [Lens] Docs for time shift (elastic#102048) update readme of logs-metrics-ui (elastic#101968) Refactor observability plugin breadcrumbs (elastic#102290) [Index Patterns] Move rollup config to index pattern management v2 (elastic#102285) [Security Solution][Endpoint] Isolate Action should only be available to Platinum+ licenses (elastic#102374) [build] Updates Ironbank templates (elastic#102407) Update security best practices document (elastic#100814) [Enterprise Search] Set up initial KibanaPageTemplate (elastic#102170) [Reporting/Docs] Add section to troubleshooting guide to explain the StatusCodeError logs (elastic#102278) [DOCS] Updating Elastic Security Overview topic (elastic#101922) [Uptime] refactor Synthetics Integration package UI (elastic#102080) [Task Manager] Log at different levels based on the state (elastic#101751) [APM] Fixing time comparison types (elastic#101423) [RAC] Update alert documents in lifecycle rule type helper (elastic#101598) [ML] Functional tests - fix and re-activate alerting flyout test (elastic#102368) [Reporting] remove unused reference to path.data config (elastic#102267) ... # Conflicts: # x-pack/plugins/fleet/kibana.json
sophiec20
added
the
zDeprecated Feature:Reporting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A few developers had to examine usage of
path.datain Kibana. They found that Reporting had a reference to it, but didn't seem to be using it.This PR removes the reference to simplify the code.
Checklist
Delete any items that are not applicable to this PR.
For maintainers