Ensure comments on parameters in arrow functions are captured in the docs and ci metrics.#100823
Merged
stacey-gammon merged 3 commits intoelastic:masterfrom May 28, 2021
Conversation
stacey-gammon
added
release_note:skip
…05-27-fix-no-comments-arrow-fns
Contributor
💚 Build SucceededMetrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 28, 2021
* master: (77 commits) [RAC][Security Solution] Register Security Detection Rules with Rule Registry (elastic#96015) [Enterprise Search] Log warning for Kibana/EntSearch version mismatches (elastic#100809) updating the saved objects test to include more saved object types (elastic#100828) [ML] Fix categorization job view examples link when datafeed uses multiple indices (elastic#100789) Fixing ES archive mapping failure (elastic#100835) Fix bug with Observability > APM header navigation (elastic#100845) [Security Solution][Endpoint] Add event filters summary card to the fleet endpoint tab (elastic#100668) [Actions] Taking space id into account when creating email footer link (elastic#100734) Ensure comments on parameters in arrow functions are captured in the docs and ci metrics. (elastic#100823) [Security Solution] Improve find rule and find rule status route performance (elastic#99678) [DOCS] Adds video to introduction (elastic#100906) [Fleet] Improve combo box for fleet settings (elastic#100603) [Security Solution][Endpoint] Endpoint generator and data loader support for Host Isolation (elastic#100813) [DOCS] Adds Lens video (elastic#100898) [TSVB] [Table tab] Fix "Math" aggregation (elastic#100765) chore(NA): moving @kbn/io-ts-utils into bazel (elastic#100810) [Alerting] Adding feature flag for enabling/disabling rule import and export (elastic#100718) [TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB (elastic#100864) [Lens] Adds dynamic table cell coloring (elastic#95217) [Security Solution][Endpoint] Do not display searchbar in security-trusted apps if there are no items (elastic#100853) ...
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
stacey-gammon
added
the
auto-backport
Contributor
💔 Backport failed
To backport manually run: |
stacey-gammon
pushed a commit
to stacey-gammon/kibana
that referenced
this pull request
Jun 1, 2021
…docs and ci metrics. (elastic#100823) * Make sure arrow functions capture parameter comments. * Update docs # Conflicts: # api_docs/apm.json # api_docs/core.json # api_docs/data.json # api_docs/data_index_patterns.json # api_docs/data_search.json # api_docs/licensing.json # api_docs/reporting.json # api_docs/spaces.json
stacey-gammon
pushed a commit
that referenced
this pull request
Jun 1, 2021
…docs and ci metrics. (#100823) (#101087) * Make sure arrow functions capture parameter comments. * Update docs # Conflicts: # api_docs/apm.json # api_docs/core.json # api_docs/data.json # api_docs/data_index_patterns.json # api_docs/data_search.json # api_docs/licensing.json # api_docs/reporting.json # api_docs/spaces.json
kibanamachine
removed
the
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #98744.
Simple fix, just needed to pass the jsdocs from the parent node into the function parsing out each child.